Commit ce59412c authored by Todd Volkert's avatar Todd Volkert Committed by GitHub

Remove hard-coded "Runner" from iOS simulator logs filtering (#12306)

parent 283f27d4
...@@ -450,6 +450,7 @@ class IOSSimulator extends Device { ...@@ -450,6 +450,7 @@ class IOSSimulator extends Device {
@override @override
DeviceLogReader getLogReader({ApplicationPackage app}) { DeviceLogReader getLogReader({ApplicationPackage app}) {
assert(app is IOSApp);
_logReaders ??= <ApplicationPackage, _IOSSimulatorLogReader>{}; _logReaders ??= <ApplicationPackage, _IOSSimulatorLogReader>{};
return _logReaders.putIfAbsent(app, () => new _IOSSimulatorLogReader(this, app)); return _logReaders.putIfAbsent(app, () => new _IOSSimulatorLogReader(this, app));
} }
...@@ -519,7 +520,7 @@ Future<Process> launchSystemLogTool(IOSSimulator device) async { ...@@ -519,7 +520,7 @@ Future<Process> launchSystemLogTool(IOSSimulator device) async {
class _IOSSimulatorLogReader extends DeviceLogReader { class _IOSSimulatorLogReader extends DeviceLogReader {
String _appName; String _appName;
_IOSSimulatorLogReader(this.device, ApplicationPackage app) { _IOSSimulatorLogReader(this.device, IOSApp app) {
_linesController = new StreamController<String>.broadcast( _linesController = new StreamController<String>.broadcast(
onListen: _start, onListen: _start,
onCancel: _stop onCancel: _stop
...@@ -583,7 +584,7 @@ class _IOSSimulatorLogReader extends DeviceLogReader { ...@@ -583,7 +584,7 @@ class _IOSSimulatorLogReader extends DeviceLogReader {
final String content = match.group(4); final String content = match.group(4);
// Filter out non-Flutter originated noise from the engine. // Filter out non-Flutter originated noise from the engine.
if (category != 'Runner') if (_appName != null && category != _appName)
return null; return null;
if (tag != null && tag != '(Flutter)') if (tag != null && tag != '(Flutter)')
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment