Unverified Commit cb50d4a8 authored by auto-submit[bot]'s avatar auto-submit[bot] Committed by GitHub

Reverts "[web] Re-enable test now that source of flakiness is fixed" (#140515)

Reverts flutter/flutter#140462
Initiated by: cbracken
This change reverts the following previous change:
Original Description:
The test was flaky before due to overflowing GPU memory during the test. The memory leak was fixed here https://github.com/flutter/engine/pull/49214

Fixes https://github.com/flutter/flutter/issues/137669

As a side effect of the fix, this test also runs much faster, from about 3 minutes on my Macbook down to about 25 seconds.
parent f5ac225c
...@@ -8390,10 +8390,13 @@ void main() { ...@@ -8390,10 +8390,13 @@ void main() {
final EditableText editableText = tester.firstWidget(find.byType(EditableText)); final EditableText editableText = tester.firstWidget(find.byType(EditableText));
expect(editableText.clipBehavior, Clip.none); expect(editableText.clipBehavior, Clip.none);
await expectLater( // TODO(harryterkelsen): see https://github.com/flutter/flutter/issues/137669
find.byKey(const ValueKey<int>(1)), if (!kIsWeb || !isCanvasKit) {
matchesGoldenFile('overflow_clipbehavior_none.cupertino.0.png'), await expectLater(
); find.byKey(const ValueKey<int>(1)),
matchesGoldenFile('overflow_clipbehavior_none.cupertino.0.png'),
);
}
}); });
testWidgets('can shift + tap to select with a keyboard (Apple platforms)', (WidgetTester tester) async { testWidgets('can shift + tap to select with a keyboard (Apple platforms)', (WidgetTester tester) async {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment