Unverified Commit c7408be1 authored by Alexandre Ardhuin's avatar Alexandre Ardhuin Committed by GitHub

prepare for lint update of prefer_final_fields (#35059)

parent 2cf82134
...@@ -2707,7 +2707,7 @@ class DiagnosticsProperty<T> extends DiagnosticsNode { ...@@ -2707,7 +2707,7 @@ class DiagnosticsProperty<T> extends DiagnosticsNode {
/// [defaultValue] has type [T] or is [kNoDefaultValue]. /// [defaultValue] has type [T] or is [kNoDefaultValue].
final Object defaultValue; final Object defaultValue;
DiagnosticLevel _defaultLevel; final DiagnosticLevel _defaultLevel;
/// Priority level of the diagnostic used to control which diagnostics should /// Priority level of the diagnostic used to control which diagnostics should
/// be shown and filtered. /// be shown and filtered.
......
...@@ -561,7 +561,7 @@ abstract class InkFeature { ...@@ -561,7 +561,7 @@ abstract class InkFeature {
/// Typically used by subclasses to call /// Typically used by subclasses to call
/// [MaterialInkController.markNeedsPaint] when they need to repaint. /// [MaterialInkController.markNeedsPaint] when they need to repaint.
MaterialInkController get controller => _controller; MaterialInkController get controller => _controller;
_RenderInkFeatures _controller; final _RenderInkFeatures _controller;
/// The render box whose visual position defines the frame of reference for this ink feature. /// The render box whose visual position defines the frame of reference for this ink feature.
final RenderBox referenceBox; final RenderBox referenceBox;
......
...@@ -721,7 +721,7 @@ class _RenderRangeSlider extends RenderBox { ...@@ -721,7 +721,7 @@ class _RenderRangeSlider extends RenderBox {
static const Duration _minimumInteractionTime = Duration(milliseconds: 500); static const Duration _minimumInteractionTime = Duration(milliseconds: 500);
_RangeSliderState _state; final _RangeSliderState _state;
Animation<double> _overlayAnimation; Animation<double> _overlayAnimation;
Animation<double> _valueIndicatorAnimation; Animation<double> _valueIndicatorAnimation;
Animation<double> _enableAnimation; Animation<double> _enableAnimation;
......
...@@ -706,7 +706,7 @@ class _RenderSlider extends RenderBox { ...@@ -706,7 +706,7 @@ class _RenderSlider extends RenderBox {
]; ];
double get _minPreferredTrackHeight => _sliderTheme.trackHeight; double get _minPreferredTrackHeight => _sliderTheme.trackHeight;
_SliderState _state; final _SliderState _state;
Animation<double> _overlayAnimation; Animation<double> _overlayAnimation;
Animation<double> _valueIndicatorAnimation; Animation<double> _valueIndicatorAnimation;
Animation<double> _enableAnimation; Animation<double> _enableAnimation;
......
...@@ -84,7 +84,7 @@ class RenderView extends RenderObject with RenderObjectWithChildMixin<RenderBox> ...@@ -84,7 +84,7 @@ class RenderView extends RenderObject with RenderObjectWithChildMixin<RenderBox>
markNeedsLayout(); markNeedsLayout();
} }
ui.Window _window; final ui.Window _window;
/// Whether Flutter should automatically compute the desired system UI. /// Whether Flutter should automatically compute the desired system UI.
/// ///
......
...@@ -505,9 +505,9 @@ class AndroidViewController { ...@@ -505,9 +505,9 @@ class AndroidViewController {
_AndroidViewState _state; _AndroidViewState _state;
dynamic _creationParams; final dynamic _creationParams;
MessageCodec<dynamic> _creationParamsCodec; final MessageCodec<dynamic> _creationParamsCodec;
final List<PlatformViewCreatedCallback> _platformViewCreatedCallbacks = <PlatformViewCreatedCallback>[]; final List<PlatformViewCreatedCallback> _platformViewCreatedCallbacks = <PlatformViewCreatedCallback>[];
......
...@@ -14,7 +14,7 @@ import 'package:flutter_test/flutter_test.dart'; ...@@ -14,7 +14,7 @@ import 'package:flutter_test/flutter_test.dart';
class TestAssetBundle extends CachingAssetBundle { class TestAssetBundle extends CachingAssetBundle {
TestAssetBundle(this._assetBundleMap); TestAssetBundle(this._assetBundleMap);
Map<String, List<String>> _assetBundleMap; final Map<String, List<String>> _assetBundleMap;
Map<String, int> loadCallCount = <String, int>{}; Map<String, int> loadCallCount = <String, int>{};
......
...@@ -769,7 +769,7 @@ typedef _TickerDisposeCallback = void Function(_TestTicker ticker); ...@@ -769,7 +769,7 @@ typedef _TickerDisposeCallback = void Function(_TestTicker ticker);
class _TestTicker extends Ticker { class _TestTicker extends Ticker {
_TestTicker(TickerCallback onTick, this._onDispose) : super(onTick); _TestTicker(TickerCallback onTick, this._onDispose) : super(onTick);
_TickerDisposeCallback _onDispose; final _TickerDisposeCallback _onDispose;
@override @override
void dispose() { void dispose() {
......
...@@ -30,7 +30,7 @@ class AndroidEmulator extends Emulator { ...@@ -30,7 +30,7 @@ class AndroidEmulator extends Emulator {
AndroidEmulator(String id, [this._properties]) AndroidEmulator(String id, [this._properties])
: super(id, _properties != null && _properties.isNotEmpty); : super(id, _properties != null && _properties.isNotEmpty);
Map<String, String> _properties; final Map<String, String> _properties;
// Android Studio uses the ID with underscores replaced with spaces // Android Studio uses the ID with underscores replaced with spaces
// for the name if displayname is not set so we do the same. // for the name if displayname is not set so we do the same.
......
...@@ -260,7 +260,7 @@ class LocalEngineArtifacts extends Artifacts { ...@@ -260,7 +260,7 @@ class LocalEngineArtifacts extends Artifacts {
final String _engineSrcPath; final String _engineSrcPath;
final String engineOutPath; // TODO(goderbauer): This should be private. final String engineOutPath; // TODO(goderbauer): This should be private.
String _hostEngineOutPath; final String _hostEngineOutPath;
@override @override
String getArtifactPath(Artifact artifact, { TargetPlatform platform, BuildMode mode }) { String getArtifactPath(Artifact artifact, { TargetPlatform platform, BuildMode mode }) {
......
...@@ -450,8 +450,8 @@ class ResidentCompiler { ...@@ -450,8 +450,8 @@ class ResidentCompiler {
String _sdkRoot; String _sdkRoot;
Process _server; Process _server;
final StdoutHandler _stdoutHandler; final StdoutHandler _stdoutHandler;
String _initializeFromDill; final String _initializeFromDill;
bool _unsafePackageSerialization; final bool _unsafePackageSerialization;
final List<String> _experimentalFlags; final List<String> _experimentalFlags;
bool _compileRequestNeedsConfirmation = false; bool _compileRequestNeedsConfirmation = false;
......
...@@ -369,7 +369,7 @@ class DevFS { ...@@ -369,7 +369,7 @@ class DevFS {
final _DevFSHttpWriter _httpWriter; final _DevFSHttpWriter _httpWriter;
final String fsName; final String fsName;
final Directory rootDirectory; final Directory rootDirectory;
String _packagesFilePath; final String _packagesFilePath;
final Set<String> assetPathsToEvict = <String>{}; final Set<String> assetPathsToEvict = <String>{};
List<Uri> sources = <Uri>[]; List<Uri> sources = <Uri>[];
DateTime lastCompiled; DateTime lastCompiled;
......
...@@ -59,8 +59,8 @@ class _FuchsiaLogReader extends DeviceLogReader { ...@@ -59,8 +59,8 @@ class _FuchsiaLogReader extends DeviceLogReader {
// \S matches non-whitespace characters. // \S matches non-whitespace characters.
static final RegExp _flutterLogOutput = RegExp(r'INFO: \S+\(flutter\): '); static final RegExp _flutterLogOutput = RegExp(r'INFO: \S+\(flutter\): ');
FuchsiaDevice _device; final FuchsiaDevice _device;
ApplicationPackage _app; final ApplicationPackage _app;
@override @override
String get name => _device.name; String get name => _device.name;
......
...@@ -355,7 +355,7 @@ class MockDevice extends Mock implements Device { ...@@ -355,7 +355,7 @@ class MockDevice extends Mock implements Device {
@override @override
final bool ephemeral; final bool ephemeral;
bool _isSupported; final bool _isSupported;
@override @override
bool isSupportedForProject(FlutterProject flutterProject) => _isSupported; bool isSupportedForProject(FlutterProject flutterProject) => _isSupported;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment