Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
c72f18fc
Unverified
Commit
c72f18fc
authored
Mar 20, 2019
by
Jonah Williams
Committed by
GitHub
Mar 20, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add builders and engine hash to fingerprint (#29434)
parent
3618199a
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
20 additions
and
4 deletions
+20
-4
build.dart
packages/flutter_tools/lib/src/base/build.dart
+9
-0
codegen.dart
packages/flutter_tools/lib/src/codegen.dart
+2
-4
compile.dart
packages/flutter_tools/lib/src/compile.dart
+9
-0
No files found.
packages/flutter_tools/lib/src/base/build.dart
View file @
c72f18fc
...
...
@@ -12,10 +12,12 @@ import '../android/android_sdk.dart';
import
'../artifacts.dart'
;
import
'../build_info.dart'
;
import
'../bundle.dart'
;
import
'../cache.dart'
;
import
'../compile.dart'
;
import
'../dart/package_map.dart'
;
import
'../globals.dart'
;
import
'../ios/mac.dart'
;
import
'../project.dart'
;
import
'context.dart'
;
import
'file_system.dart'
;
import
'fingerprint.dart'
;
...
...
@@ -79,6 +81,11 @@ class AOTSnapshotter {
IOSArch
iosArch
,
List
<
String
>
extraGenSnapshotOptions
=
const
<
String
>[],
})
async
{
FlutterProject
flutterProject
;
if
(
fs
.
file
(
'pubspec.yaml'
).
existsSync
())
{
flutterProject
=
await
FlutterProject
.
current
();
}
final
FlutterEngine
engine
=
FlutterEngine
(
cache
);
if
(!
_isValidAotPlatform
(
platform
,
buildMode
))
{
printError
(
'
${getNameForTargetPlatform(platform)}
does not support AOT compilation.'
);
return
1
;
...
...
@@ -180,6 +187,8 @@ class AOTSnapshotter {
'entryPoint'
:
mainPath
,
'sharedLib'
:
buildSharedLibrary
.
toString
(),
'extraGenSnapshotOptions'
:
extraGenSnapshotOptions
.
join
(
' '
),
'engineHash'
:
engine
.
version
,
'buildersUsed'
:
'
${flutterProject != null ? await flutterProject.hasBuilders : false}
'
,
},
depfilePaths:
<
String
>[],
);
...
...
packages/flutter_tools/lib/src/codegen.dart
View file @
c72f18fc
...
...
@@ -148,8 +148,7 @@ class CodeGeneratingKernelCompiler implements KernelCompiler {
fileSystemScheme:
kMultiRootScheme
,
depFilePath:
depFilePath
,
targetModel:
targetModel
,
// Pass an invalid file name to prevent frontend_server from initializing from dill.
initializeFromDill:
'none_file'
,
initializeFromDill:
initializeFromDill
,
);
}
}
...
...
@@ -185,8 +184,7 @@ class CodeGeneratingResidentCompiler implements ResidentCompiler {
fileSystemScheme:
kMultiRootScheme
,
targetModel:
TargetModel
.
flutter
,
unsafePackageSerialization:
unsafePackageSerialization
,
// Pass an invalid file name to prevent frontend_server from initializing from dill.
initializeFromDill:
'none_file'
,
initializeFromDill:
initializeFromDill
,
);
if
(
runCold
)
{
return
residentCompiler
;
...
...
packages/flutter_tools/lib/src/compile.dart
View file @
c72f18fc
...
...
@@ -16,9 +16,11 @@ import 'base/io.dart';
import
'base/platform.dart'
;
import
'base/process_manager.dart'
;
import
'base/terminal.dart'
;
import
'cache.dart'
;
import
'convert.dart'
;
import
'dart/package_map.dart'
;
import
'globals.dart'
;
import
'project.dart'
;
KernelCompiler
get
kernelCompiler
=>
context
[
KernelCompiler
];
...
...
@@ -214,6 +216,11 @@ class KernelCompiler {
final
String
frontendServer
=
artifacts
.
getArtifactPath
(
Artifact
.
frontendServerSnapshotForEngineDartSdk
);
FlutterProject
flutterProject
;
if
(
fs
.
file
(
'pubspec.yaml'
).
existsSync
())
{
flutterProject
=
await
FlutterProject
.
current
();
}
final
FlutterEngine
engine
=
FlutterEngine
(
cache
);
// TODO(cbracken): eliminate pathFilter.
// Currently the compiler emits buildbot paths for the core libs in the
...
...
@@ -227,6 +234,8 @@ class KernelCompiler {
'entryPoint'
:
mainPath
,
'trackWidgetCreation'
:
trackWidgetCreation
.
toString
(),
'linkPlatformKernelIn'
:
linkPlatformKernelIn
.
toString
(),
'engineHash'
:
engine
.
version
,
'buildersUsed'
:
'
${flutterProject != null ? await flutterProject.hasBuilders : false}
'
,
},
depfilePaths:
<
String
>[
depFilePath
],
pathFilter:
(
String
path
)
=>
!
path
.
startsWith
(
'/b/build/slave/'
),
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment