Commit c5ba689e authored by Kate Lovett's avatar Kate Lovett

Commented out skips in golden framework tests and transitioned from...

Commented out skips in golden framework tests and transitioned from matchesGoldenFile to matchesSkiaGoldFile.
parent 8c59c524
...@@ -2033,7 +2033,7 @@ void main() { ...@@ -2033,7 +2033,7 @@ void main() {
// skip: !Platform.isLinux, // skip: !Platform.isLinux,
); );
}, },
skip: !Platform.isLinux, // skip: !Platform.isLinux,
); );
testWidgets('InputDecorationTheme.toString()', (WidgetTester tester) async { testWidgets('InputDecorationTheme.toString()', (WidgetTester tester) async {
......
...@@ -72,8 +72,9 @@ void main() { ...@@ -72,8 +72,9 @@ void main() {
await expectLater( await expectLater(
find.byType(RepaintBoundary), find.byType(RepaintBoundary),
matchesGoldenFile('continuous_rectangle_border.golden_test_even_radii.png'), matchesSkiaGoldFile('continuous_rectangle_border.golden_test_even_radii.png'),
skip: !Platform.isLinux, // matchesGoldenFile('continuous_rectangle_border.golden_test_even_radii.png'),
// skip: !Platform.isLinux,
); );
}); });
...@@ -94,8 +95,9 @@ void main() { ...@@ -94,8 +95,9 @@ void main() {
await expectLater( await expectLater(
find.byType(RepaintBoundary), find.byType(RepaintBoundary),
matchesGoldenFile('continuous_rectangle_border.golden_test_varying_radii.png'), matchesSkiaGoldFile('continuous_rectangle_border.golden_test_varying_radii.png'),
skip: !Platform.isLinux, // matchesGoldenFile('continuous_rectangle_border.golden_test_varying_radii.png'),
// skip: !Platform.isLinux,
); );
}); });
...@@ -113,8 +115,9 @@ void main() { ...@@ -113,8 +115,9 @@ void main() {
await expectLater( await expectLater(
find.byType(RepaintBoundary), find.byType(RepaintBoundary),
matchesGoldenFile('continuous_rectangle_border.golden_test_large_radii.png'), matchesSkiaGoldFile('continuous_rectangle_border.golden_test_large_radii.png'),
skip: !Platform.isLinux, // matchesGoldenFile('continuous_rectangle_border.golden_test_large_radii.png'),
// skip: !Platform.isLinux,
); );
}); });
......
...@@ -51,10 +51,11 @@ void main() { ...@@ -51,10 +51,11 @@ void main() {
await expectLater( await expectLater(
find.byType(RichText), find.byType(RichText),
matchesGoldenFile('localized_fonts.rich_text.styled_text_span.png'), matchesSkiaGoldFile('localized_fonts.rich_text.styled_text_span.png'),
// matchesGoldenFile('localized_fonts.rich_text.styled_text_span.png'),
); );
}, },
skip: !Platform.isLinux, //skip: !Platform.isLinux,
); );
testWidgets( testWidgets(
...@@ -103,10 +104,11 @@ void main() { ...@@ -103,10 +104,11 @@ void main() {
await expectLater( await expectLater(
find.byType(Row), find.byType(Row),
matchesGoldenFile('localized_fonts.text_ambient_locale.chars.png'), matchesSkiaGoldFile('localized_fonts.text_ambient_locale.chars.png'),
// matchesGoldenFile('localized_fonts.text_ambient_locale.chars.png'),
); );
}, },
skip: !Platform.isLinux, // skip: !Platform.isLinux,
); );
testWidgets( testWidgets(
...@@ -147,10 +149,11 @@ void main() { ...@@ -147,10 +149,11 @@ void main() {
await expectLater( await expectLater(
find.byType(Row), find.byType(Row),
matchesGoldenFile('localized_fonts.text_explicit_locale.chars.png'), matchesSkiaGoldFile('localized_fonts.text_explicit_locale.chars.png'),
// matchesGoldenFile('localized_fonts.text_explicit_locale.chars.png'),
); );
}, },
skip: !Platform.isLinux, // skip: !Platform.isLinux,
); );
} }
...@@ -43,8 +43,9 @@ void main() { ...@@ -43,8 +43,9 @@ void main() {
); );
await expectLater( await expectLater(
find.byType(RepaintBoundary).first, find.byType(RepaintBoundary).first,
matchesGoldenFile('backdrop_filter_test.cull_rect.1.png'), matchesSkiaGoldFile('backdrop_filter_test.cull_rect.png')
skip: !Platform.isLinux, // matchesGoldenFile('backdrop_filter_test.cull_rect.1.png'),
// skip: !Platform.isLinux,
); );
}); });
} }
...@@ -288,7 +288,8 @@ void main() { ...@@ -288,7 +288,8 @@ void main() {
); );
await expectLater( await expectLater(
find.byType(RepaintBoundary).first, find.byType(RepaintBoundary).first,
matchesGoldenFile('clip.ClipRect.1.png'), matchesSkiaGoldFile('clip.ClipRect.png'),
// matchesGoldenFile('clip.ClipRect.1.png'),
); );
}); });
...@@ -328,7 +329,8 @@ void main() { ...@@ -328,7 +329,8 @@ void main() {
); );
await expectLater( await expectLater(
find.byType(RepaintBoundary).first, find.byType(RepaintBoundary).first,
matchesGoldenFile('clip.ClipRectOverlay.1.png'), matchesSkiaGoldFile('clip.ClipRectOverlay.png')
// matchesGoldenFile('clip.ClipRectOverlay.1.png'),
); );
}); });
...@@ -377,7 +379,8 @@ void main() { ...@@ -377,7 +379,8 @@ void main() {
); );
await expectLater( await expectLater(
find.byType(RepaintBoundary).first, find.byType(RepaintBoundary).first,
matchesGoldenFile('clip.ClipRRect.1.png'), matchesSkiaGoldFile('clip.ClipRRect.png'),
// matchesGoldenFile('clip.ClipRRect.1.png'),
); );
}); });
...@@ -420,7 +423,8 @@ void main() { ...@@ -420,7 +423,8 @@ void main() {
); );
await expectLater( await expectLater(
find.byType(RepaintBoundary).first, find.byType(RepaintBoundary).first,
matchesGoldenFile('clip.ClipOval.1.png'), matchesSkiaGoldFile('clip.ClipOval.png'),
// matchesGoldenFile('clip.ClipOval.1.png'),
); );
}); });
...@@ -468,7 +472,8 @@ void main() { ...@@ -468,7 +472,8 @@ void main() {
); );
await expectLater( await expectLater(
find.byType(RepaintBoundary).first, find.byType(RepaintBoundary).first,
matchesGoldenFile('clip.ClipPath.1.png'), matchesSkiaGoldFile('clip.ClipPath.png'),
// matchesGoldenFile('clip.ClipPath.1.png'),
); );
}); });
...@@ -513,7 +518,8 @@ void main() { ...@@ -513,7 +518,8 @@ void main() {
await tester.pumpWidget(genPhysicalModel(Clip.antiAlias)); await tester.pumpWidget(genPhysicalModel(Clip.antiAlias));
await expectLater( await expectLater(
find.byType(RepaintBoundary).first, find.byType(RepaintBoundary).first,
matchesGoldenFile('clip.PhysicalModel.antiAlias.1.png'), matchesSkiaGoldFile('clip.PhysicalModel.antiAlias.png'),
// matchesGoldenFile('clip.PhysicalModel.antiAlias.1.png'),
); );
}); });
...@@ -521,7 +527,8 @@ void main() { ...@@ -521,7 +527,8 @@ void main() {
await tester.pumpWidget(genPhysicalModel(Clip.hardEdge)); await tester.pumpWidget(genPhysicalModel(Clip.hardEdge));
await expectLater( await expectLater(
find.byType(RepaintBoundary).first, find.byType(RepaintBoundary).first,
matchesGoldenFile('clip.PhysicalModel.hardEdge.1.png'), matchesSkiaGoldFile('clip.PhysicalModel.hardEdge.png'),
// matchesGoldenFile('clip.PhysicalModel.hardEdge.1.png'),
); );
}); });
...@@ -531,7 +538,8 @@ void main() { ...@@ -531,7 +538,8 @@ void main() {
await tester.pumpWidget(genPhysicalModel(Clip.antiAliasWithSaveLayer)); await tester.pumpWidget(genPhysicalModel(Clip.antiAliasWithSaveLayer));
await expectLater( await expectLater(
find.byType(RepaintBoundary).first, find.byType(RepaintBoundary).first,
matchesGoldenFile('clip.PhysicalModel.antiAliasWithSaveLayer.png'), matchesSkiaGoldFile('clip.PhysicalModel.antiAliasWithSaveLayer.png'),
// matchesGoldenFile('clip.PhysicalModel.antiAliasWithSaveLayer.png'),
); );
}); });
...@@ -573,7 +581,8 @@ void main() { ...@@ -573,7 +581,8 @@ void main() {
); );
await expectLater( await expectLater(
find.byType(RepaintBoundary).first, find.byType(RepaintBoundary).first,
matchesGoldenFile('clip.PhysicalModel.default.1.png'), matchesSkiaGoldFile('clip.PhysicalModel.default.png'),
// matchesGoldenFile('clip.PhysicalModel.default.1.png'),
); );
}); });
...@@ -622,7 +631,8 @@ void main() { ...@@ -622,7 +631,8 @@ void main() {
await tester.pumpWidget(genPhysicalShape(Clip.antiAlias)); await tester.pumpWidget(genPhysicalShape(Clip.antiAlias));
await expectLater( await expectLater(
find.byType(RepaintBoundary).first, find.byType(RepaintBoundary).first,
matchesGoldenFile('clip.PhysicalShape.antiAlias.1.png'), matchesSkiaGoldFile('clip.PhysicalShape.antiAlias.png'),
// matchesGoldenFile('clip.PhysicalShape.antiAlias.1.png'),
); );
}); });
...@@ -630,7 +640,8 @@ void main() { ...@@ -630,7 +640,8 @@ void main() {
await tester.pumpWidget(genPhysicalShape(Clip.hardEdge)); await tester.pumpWidget(genPhysicalShape(Clip.hardEdge));
await expectLater( await expectLater(
find.byType(RepaintBoundary).first, find.byType(RepaintBoundary).first,
matchesGoldenFile('clip.PhysicalShape.hardEdge.1.png'), matchesSkiaGoldFile('clip.PhysicalShape.hardEdge.png'),
// matchesGoldenFile('clip.PhysicalShape.hardEdge.1.png'),
); );
}); });
...@@ -638,7 +649,8 @@ void main() { ...@@ -638,7 +649,8 @@ void main() {
await tester.pumpWidget(genPhysicalShape(Clip.antiAliasWithSaveLayer)); await tester.pumpWidget(genPhysicalShape(Clip.antiAliasWithSaveLayer));
await expectLater( await expectLater(
find.byType(RepaintBoundary).first, find.byType(RepaintBoundary).first,
matchesGoldenFile('clip.PhysicalShape.antiAliasWithSaveLayer.png'), matchesSkiaGoldFile('clip.PhysicalShape.antiAliasWithSaveLayer.png'),
// matchesGoldenFile('clip.PhysicalShape.antiAliasWithSaveLayer.png'),
); );
}); });
...@@ -684,7 +696,8 @@ void main() { ...@@ -684,7 +696,8 @@ void main() {
); );
await expectLater( await expectLater(
find.byType(RepaintBoundary).first, find.byType(RepaintBoundary).first,
matchesGoldenFile('clip.PhysicalShape.default.1.png'), matchesSkiaGoldFile('clip.PhysicalShape.default.png'),
// matchesGoldenFile('clip.PhysicalShape.default.1.png'),
); );
}); });
......
...@@ -91,9 +91,12 @@ void main() { ...@@ -91,9 +91,12 @@ void main() {
await expectLater( await expectLater(
find.byKey(const ValueKey<int>(1)), find.byKey(const ValueKey<int>(1)),
matchesGoldenFile('editable_text_test.0.0.png'), matchesSkiaGoldFile('editable_text_test.0.png'),
// matchesGoldenFile('editable_text_test.0.0.png'),
);
},
//skip: !Platform.isLinux
); );
}, skip: !Platform.isLinux);
testWidgets('cursor layout has correct radius', (WidgetTester tester) async { testWidgets('cursor layout has correct radius', (WidgetTester tester) async {
final GlobalKey<EditableTextState> editableTextKey = GlobalKey<EditableTextState>(); final GlobalKey<EditableTextState> editableTextKey = GlobalKey<EditableTextState>();
...@@ -142,9 +145,11 @@ void main() { ...@@ -142,9 +145,11 @@ void main() {
await expectLater( await expectLater(
find.byKey(const ValueKey<int>(1)), find.byKey(const ValueKey<int>(1)),
matchesGoldenFile('editable_text_test.1.0.png'), matchesSkiaGoldFile('editable_text_test.1.png'),
// matchesGoldenFile('editable_text_test.1.0.png'),
);
}, //skip: !Platform.isLinux
); );
}, skip: !Platform.isLinux);
testWidgets('Cursor animates on iOS', (WidgetTester tester) async { testWidgets('Cursor animates on iOS', (WidgetTester tester) async {
final Widget widget = MaterialApp( final Widget widget = MaterialApp(
......
...@@ -22,8 +22,9 @@ void main() { ...@@ -22,8 +22,9 @@ void main() {
await expectLater( await expectLater(
find.byType(RepaintBoundary), find.byType(RepaintBoundary),
matchesGoldenFile('invert_colors_test.0.png'), matchesSkiaGoldFile('invert_colors_test.0.png')
skip: !Platform.isLinux, // matchesGoldenFile('invert_colors_test.0.png'),
// skip: !Platform.isLinux,
); );
}); });
...@@ -41,8 +42,9 @@ void main() { ...@@ -41,8 +42,9 @@ void main() {
await expectLater( await expectLater(
find.byType(RepaintBoundary), find.byType(RepaintBoundary),
matchesGoldenFile('invert_colors_test.1.png'), matchesSkiaGoldFile('invert_colors_test.1.png'),
skip: !Platform.isLinux, // matchesGoldenFile('invert_colors_test.1.png'),
// skip: !Platform.isLinux,
); );
}); });
} }
......
...@@ -492,8 +492,9 @@ void main() { ...@@ -492,8 +492,9 @@ void main() {
await expectLater( await expectLater(
find.byKey(const Key('list_wheel_scroll_view')), find.byKey(const Key('list_wheel_scroll_view')),
matchesGoldenFile('list_wheel_scroll_view.center_child.magnified.png'), matchesSkiaGoldFile('list_wheel_scroll_view.center_child.magnified.png'),
skip: !Platform.isLinux, // matchesGoldenFile('list_wheel_scroll_view.center_child.magnified.png'),
// skip: !Platform.isLinux,
); );
}); });
...@@ -547,8 +548,9 @@ void main() { ...@@ -547,8 +548,9 @@ void main() {
await expectLater( await expectLater(
find.byKey(const Key('list_wheel_scroll_view')), find.byKey(const Key('list_wheel_scroll_view')),
matchesGoldenFile('list_wheel_scroll_view.curved_wheel.left.png'), matchesSkiaGoldFile('list_wheel_scroll_view.curved_wheel.left.png'),
skip: !Platform.isLinux, // matchesGoldenFile('list_wheel_scroll_view.curved_wheel.left.png'),
// skip: !Platform.isLinux,
); );
}); });
......
...@@ -179,8 +179,9 @@ void main() { ...@@ -179,8 +179,9 @@ void main() {
); );
await expectLater( await expectLater(
find.byType(RepaintBoundary).first, find.byType(RepaintBoundary).first,
matchesGoldenFile('opacity_test.offset.1.png'), matchesSkiaGoldFile('opacity_test.offset.png'),
skip: !Platform.isLinux, // matchesGoldenFile('opacity_test.offset.1.png'),
// skip: !Platform.isLinux,
); );
}); });
} }
...@@ -66,8 +66,9 @@ void main() { ...@@ -66,8 +66,9 @@ void main() {
expect(tester.takeException(), startsWith('A RenderFlex overflowed by ')); expect(tester.takeException(), startsWith('A RenderFlex overflowed by '));
await expectLater( await expectLater(
find.byKey(key), find.byKey(key),
matchesGoldenFile('physical_model_overflow.png'), matchesSkiaGoldFile('physical_model_overflow.png'),
skip: !Platform.isLinux, // matchesGoldenFile('physical_model_overflow.png'),
// skip: !Platform.isLinux,
); );
}); });
......
...@@ -25,18 +25,18 @@ void main() { ...@@ -25,18 +25,18 @@ void main() {
); );
await expectLater( await expectLater(
find.byType(Container), find.byType(Container),
matchesGoldenFile('shadow.BoxDecoration.disabled.png'), matchesSkiaGoldFile('shadow.BoxDecoration.disabled.png'),
// matchesGoldenFile('shadow.BoxDecoration.disabled.png'),
); );
debugDisableShadows = false; debugDisableShadows = false;
tester.binding.reassembleApplication(); tester.binding.reassembleApplication();
await tester.pump(); await tester.pump();
if (Platform.isLinux) { // TODO(ianh): [May no longer apply] use the skip argument instead once that doesn't hang, https://github.com/dart-lang/test/issues/830
// TODO(ianh): use the skip argument instead once that doesn't hang, https://github.com/dart-lang/test/issues/830
await expectLater( await expectLater(
find.byType(Container), find.byType(Container),
matchesGoldenFile('shadow.BoxDecoration.enabled.png'), matchesSkiaGoldFile('shadow.BoxDecoration.enabled.png'),
); // shadows render differently on different platforms // matchesGoldenFile('shadow.BoxDecoration.enabled.png'),
} );
debugDisableShadows = true; debugDisableShadows = true;
}); });
...@@ -61,11 +61,14 @@ void main() { ...@@ -61,11 +61,14 @@ void main() {
await tester.pumpWidget(build(elevation)); await tester.pumpWidget(build(elevation));
await expectLater( await expectLater(
find.byType(Container), find.byType(Container),
matchesGoldenFile('shadow.ShapeDecoration.$elevation.png'), matchesSkiaGoldFile('shadow.ShapeDecoration.$elevation.png'),
// matchesGoldenFile('shadow.ShapeDecoration.$elevation.png'),
); );
} }
debugDisableShadows = true; debugDisableShadows = true;
}, skip: !Platform.isLinux); // shadows render differently on different platforms },
// skip: !Platform.isLinux
); // shadows render differently on different platforms
testWidgets('Shadows with PhysicalLayer', (WidgetTester tester) async { testWidgets('Shadows with PhysicalLayer', (WidgetTester tester) async {
await tester.pumpWidget( await tester.pumpWidget(
...@@ -88,18 +91,18 @@ void main() { ...@@ -88,18 +91,18 @@ void main() {
); );
await expectLater( await expectLater(
find.byType(Container), find.byType(Container),
matchesGoldenFile('shadow.PhysicalModel.disabled.png'), matchesSkiaGoldFile('shadow.PhysicalModel.disabled.png'),
// matchesGoldenFile('shadow.PhysicalModel.disabled.png'),
); );
debugDisableShadows = false; debugDisableShadows = false;
tester.binding.reassembleApplication(); tester.binding.reassembleApplication();
await tester.pump(); await tester.pump();
if (Platform.isLinux) { // TODO(ianh): [May no longer apply] use the skip argument instead once that doesn't hang, https://github.com/dart-lang/test/issues/830
// TODO(ianh): use the skip argument instead once that doesn't hang, https://github.com/dart-lang/test/issues/830
await expectLater( await expectLater(
find.byType(Container), find.byType(Container),
matchesGoldenFile('shadow.PhysicalModel.enabled.png'), matchesSkiaGoldFile('shadow.PhysicalModel.enabled.png'),
); // shadows render differently on different platforms // matchesGoldenFile('shadow.PhysicalModel.enabled.png'),
} );
debugDisableShadows = true; debugDisableShadows = true;
}); });
...@@ -128,9 +131,11 @@ void main() { ...@@ -128,9 +131,11 @@ void main() {
await tester.pumpWidget(build(elevation.toDouble())); await tester.pumpWidget(build(elevation.toDouble()));
await expectLater( await expectLater(
find.byType(Container), find.byType(Container),
matchesGoldenFile('shadow.PhysicalShape.$elevation.1.png'), matchesSkiaGoldFile('shadow.PhysicalModel.disabled.png'),
// matchesGoldenFile('shadow.PhysicalModel.disabled.png'),
); );
} }
debugDisableShadows = true; debugDisableShadows = true;
}, skip: !Platform.isLinux); // shadows render differently on different platforms },
} // skip: !Platform.isLinux
);
\ No newline at end of file
...@@ -31,7 +31,8 @@ void main() { ...@@ -31,7 +31,8 @@ void main() {
await expectLater( await expectLater(
find.byType(Container), find.byType(Container),
matchesGoldenFile('text_golden.Centered.png'), matchesSkiaGoldFile('text_golden.Centered.png'),
// matchesGoldenFile('text_golden.Centered.png'),
); );
await tester.pumpWidget( await tester.pumpWidget(
...@@ -55,9 +56,12 @@ void main() { ...@@ -55,9 +56,12 @@ void main() {
await expectLater( await expectLater(
find.byType(Container), find.byType(Container),
matchesGoldenFile('text_golden.Centered.wrap.png'), matchesSkiaGoldFile('text_golden.Centered.wrap.png'),
// matchesGoldenFile('text_golden.Centered.wrap.png'),
);
},
// skip: !Platform.isLinux
); );
}, skip: !Platform.isLinux);
testWidgets('Text Foreground', (WidgetTester tester) async { testWidgets('Text Foreground', (WidgetTester tester) async {
...@@ -86,7 +90,8 @@ void main() { ...@@ -86,7 +90,8 @@ void main() {
await expectLater( await expectLater(
find.byType(RepaintBoundary), find.byType(RepaintBoundary),
matchesGoldenFile('text_golden.Foreground.gradient.png'), matchesSkiaGoldFile('text_golden.Foreground.gradient.png'),
// matchesGoldenFile('text_golden.Foreground.gradient.png'),
); );
await tester.pumpWidget( await tester.pumpWidget(
...@@ -108,7 +113,8 @@ void main() { ...@@ -108,7 +113,8 @@ void main() {
await expectLater( await expectLater(
find.byType(RepaintBoundary), find.byType(RepaintBoundary),
matchesGoldenFile('text_golden.Foreground.stroke.png'), matchesSkiaGoldFile('text_golden.Foreground.stroke.png'),
// matchesGoldenFile('text_golden.Foreground.stroke.png'),
); );
await tester.pumpWidget( await tester.pumpWidget(
...@@ -131,9 +137,12 @@ void main() { ...@@ -131,9 +137,12 @@ void main() {
await expectLater( await expectLater(
find.byType(RepaintBoundary), find.byType(RepaintBoundary),
matchesGoldenFile('text_golden.Foreground.stroke_and_gradient.png'), matchesSkiaGoldFile('text_golden.Foreground.stroke_and_gradient.png'),
// matchesGoldenFile('text_golden.Foreground.stroke_and_gradient.png'),
);
},
// skip: !Platform.isLinux
); );
}, skip: !Platform.isLinux);
// TODO(garyq): This test requires an update when the background // TODO(garyq): This test requires an update when the background
// drawing from the beginning of the line bug is fixed. The current // drawing from the beginning of the line bug is fixed. The current
...@@ -181,9 +190,12 @@ void main() { ...@@ -181,9 +190,12 @@ void main() {
await expectLater( await expectLater(
find.byType(RepaintBoundary), find.byType(RepaintBoundary),
matchesGoldenFile('text_golden.Background.png'), matchesSkiaGoldFile('text_golden.Background.png'),
// matchesGoldenFile('text_golden.Background.png'),
);
},
// skip: !Platform.isLinux
); );
}, skip: !Platform.isLinux);
testWidgets('Text Fade', (WidgetTester tester) async { testWidgets('Text Fade', (WidgetTester tester) async {
await tester.pumpWidget( await tester.pumpWidget(
...@@ -217,9 +229,12 @@ void main() { ...@@ -217,9 +229,12 @@ void main() {
await expectLater( await expectLater(
find.byType(RepaintBoundary).first, find.byType(RepaintBoundary).first,
matchesGoldenFile('text_golden.Fade.1.png'), matchesSkiaGoldFile('text_golden.Fade.1.png'),
// matchesGoldenFile('text_golden.Fade.1.png'),
);
},
// skip: !Platform.isLinux
); );
}, skip: !Platform.isLinux);
testWidgets('Default Strut text', (WidgetTester tester) async { testWidgets('Default Strut text', (WidgetTester tester) async {
await tester.pumpWidget( await tester.pumpWidget(
...@@ -242,10 +257,13 @@ void main() { ...@@ -242,10 +257,13 @@ void main() {
); );
await expectLater( await expectLater(
find.byType(Container), find.byType(Container),
matchesGoldenFile('text_golden.StrutDefault.png'), matchesSkiaGoldFile('text_golden.StrutDefault.png'),
// matchesGoldenFile('text_golden.StrutDefault.png'),
); );
}, skip: true); // Should only be on linux (skip: !Platform.isLinux). },
// skip: true // Should only be on linux (skip: !Platform.isLinux).
// Disabled for now until font inconsistency is resolved. // Disabled for now until font inconsistency is resolved.
);
testWidgets('Strut text 1', (WidgetTester tester) async { testWidgets('Strut text 1', (WidgetTester tester) async {
await tester.pumpWidget( await tester.pumpWidget(
...@@ -270,10 +288,12 @@ void main() { ...@@ -270,10 +288,12 @@ void main() {
); );
await expectLater( await expectLater(
find.byType(Container), find.byType(Container),
matchesGoldenFile('text_golden.Strut.1.1.png'), matchesSkiaGoldFile('text_golden.Strut.1.png')
// matchesGoldenFile('text_golden.Strut.1.1.png'),
); );
}, skip: true); // Should only be on linux (skip: !Platform.isLinux). },
// Disabled for now until font inconsistency is resolved. // skip: true // Should only be on linux (skip: !Platform.isLinux).
); // Disabled for now until font inconsistency is resolved.
testWidgets('Strut text 2', (WidgetTester tester) async { testWidgets('Strut text 2', (WidgetTester tester) async {
await tester.pumpWidget( await tester.pumpWidget(
...@@ -299,10 +319,12 @@ void main() { ...@@ -299,10 +319,12 @@ void main() {
); );
await expectLater( await expectLater(
find.byType(Container), find.byType(Container),
matchesGoldenFile('text_golden.Strut.2.1.png'), matchesSkiaGoldFile('text_golden.Strut.2.png')
// matchesGoldenFile('text_golden.Strut.2.1.png'),
); );
}, skip: true); // Should only be on linux (skip: !Platform.isLinux). },
// Disabled for now until font inconsistency is resolved. // skip: true // Should only be on linux (skip: !Platform.isLinux).
); // Disabled for now until font inconsistency is resolved.
testWidgets('Strut text rich', (WidgetTester tester) async { testWidgets('Strut text rich', (WidgetTester tester) async {
await tester.pumpWidget( await tester.pumpWidget(
...@@ -351,10 +373,12 @@ void main() { ...@@ -351,10 +373,12 @@ void main() {
); );
await expectLater( await expectLater(
find.byType(Container), find.byType(Container),
matchesGoldenFile('text_golden.Strut.3.1.png'), matchesSkiaGoldFile('text_golden.Strut.3.png')
// matchesGoldenFile('text_golden.Strut.3.1.png'),
); );
}, skip: true); // Should only be on linux (skip: !Platform.isLinux). },
// Disabled for now until font inconsistency is resolved. // skip: true // Should only be on linux (skip: !Platform.isLinux).
); // Disabled for now until font inconsistency is resolved.
testWidgets('Strut text font fallback', (WidgetTester tester) async { testWidgets('Strut text font fallback', (WidgetTester tester) async {
// Font Fallback // Font Fallback
...@@ -387,10 +411,12 @@ void main() { ...@@ -387,10 +411,12 @@ void main() {
); );
await expectLater( await expectLater(
find.byType(Container), find.byType(Container),
matchesGoldenFile('text_golden.Strut.4.1.png'), matchesSkiaGoldFile('text_golden.Strut.4.png')
// matchesGoldenFile('text_golden.Strut.4.1.png'),
); );
}, skip: true); // Should only be on linux (skip: !Platform.isLinux). },
// Disabled for now until font inconsistency is resolved. // skip: true // Should only be on linux (skip: !Platform.isLinux).
); // Disabled for now until font inconsistency is resolved.
testWidgets('Strut text rich forceStrutHeight', (WidgetTester tester) async { testWidgets('Strut text rich forceStrutHeight', (WidgetTester tester) async {
await tester.pumpWidget( await tester.pumpWidget(
...@@ -439,10 +465,12 @@ void main() { ...@@ -439,10 +465,12 @@ void main() {
); );
await expectLater( await expectLater(
find.byType(Container), find.byType(Container),
matchesGoldenFile('text_golden.StrutForce.1.1.png'), matchesSkiaGoldFile('text_golden.StrutForce.1.png')
// matchesGoldenFile('text_golden.StrutForce.1.1.png'),
); );
}, skip: true); // Should only be on linux (skip: !Platform.isLinux). },
// Disabled for now until font inconsistency is resolved. // skip: true // Should only be on linux (skip: !Platform.isLinux).
); // Disabled for now until font inconsistency is resolved.
testWidgets('Decoration thickness', (WidgetTester tester) async { testWidgets('Decoration thickness', (WidgetTester tester) async {
final TextDecoration allDecorations = TextDecoration.combine( final TextDecoration allDecorations = TextDecoration.combine(
...@@ -478,9 +506,12 @@ void main() { ...@@ -478,9 +506,12 @@ void main() {
); );
await expectLater( await expectLater(
find.byType(Container), find.byType(Container),
matchesGoldenFile('text_golden.Decoration.1.0.png'), matchesSkiaGoldFile('text_golden.Decoration.1.png'),
// matchesGoldenFile('text_golden.Decoration.1.0.png'),
); );
}, skip: !Platform.isLinux); // Coretext uses different thicknesses for decoration },
// skip: !Platform.isLinux
); // Coretext uses different thicknesses for decoration
testWidgets('Decoration thickness', (WidgetTester tester) async { testWidgets('Decoration thickness', (WidgetTester tester) async {
final TextDecoration allDecorations = TextDecoration.combine( final TextDecoration allDecorations = TextDecoration.combine(
...@@ -517,7 +548,10 @@ void main() { ...@@ -517,7 +548,10 @@ void main() {
); );
await expectLater( await expectLater(
find.byType(Container), find.byType(Container),
matchesGoldenFile('text_golden.DecorationThickness.1.0.png'), matchesSkiaGoldFile('text_golden.DecorationThickness.1.png'),
// matchesGoldenFile('text_golden.DecorationThickness.1.0.png'),
); );
}, skip: !Platform.isLinux); // Coretext uses different thicknesses for decoration },
// skip: !Platform.isLinux
); // Coretext uses different thicknesses for decoration
} }
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment