Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
c0b5db6c
Unverified
Commit
c0b5db6c
authored
Feb 23, 2021
by
Kate Lovett
Committed by
GitHub
Feb 23, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add fix for BottomNavigationBarItem.title -> label (#76339)
parent
9ce3f76c
Changes
7
Hide whitespace changes
Inline
Side-by-side
Showing
7 changed files
with
47 additions
and
0 deletions
+47
-0
fix_data.yaml
packages/flutter/lib/fix_data.yaml
+23
-0
cupertino.dart
packages/flutter/test_fixes/cupertino.dart
+4
-0
cupertino.dart.expect
packages/flutter/test_fixes/cupertino.dart.expect
+4
-0
material.dart
packages/flutter/test_fixes/material.dart
+4
-0
material.dart.expect
packages/flutter/test_fixes/material.dart.expect
+4
-0
widgets.dart
packages/flutter/test_fixes/widgets.dart
+4
-0
widgets.dart.expect
packages/flutter/test_fixes/widgets.dart.expect
+4
-0
No files found.
packages/flutter/lib/fix_data.yaml
View file @
c0b5db6c
...
...
@@ -11,6 +11,29 @@
version
:
1
transforms
:
# Changes made in https://github.com/flutter/flutter/pull/59127
-
title
:
"
Migrate
to
'label'"
date
:
2020-07-09
element
:
uris
:
[
'
material.dart'
,
'
widgets.dart'
,
'
cupertino.dart'
]
field
:
'
title'
inClass
:
'
BottomNavigationBarItem'
changes
:
-
kind
:
'
rename'
newName
:
'
label'
# Changes made in https://github.com/flutter/flutter/pull/59127
-
title
:
"
Migrate
to
'label'"
date
:
2020-07-09
element
:
uris
:
[
'
material.dart'
,
'
widgets.dart'
,
'
cupertino.dart'
]
constructor
:
'
'
inClass
:
'
BottomNavigationBarItem'
changes
:
-
kind
:
'
renameParameter'
oldName
:
'
title'
newName
:
'
label'
# Changes made in https://github.com/flutter/flutter/pull/66043
-
title
:
"
Use
withKind"
date
:
2020-09-17
...
...
packages/flutter/test_fixes/cupertino.dart
View file @
c0b5db6c
...
...
@@ -123,4 +123,8 @@ void main() {
CupertinoTextField
.
borderless
(
maxLengthEnforced:
false
);
final
CupertinoTextField
textField
;
textField
.
maxLengthEnforced
;
// Changes made in https://github.com/flutter/flutter/pull/59127
const
BottomNavigationBarItem
bottomNavigationBarItem
=
BottomNavigationBarItem
(
title:
myTitle
);
bottomNavigationBarItem
.
title
;
}
packages/flutter/test_fixes/cupertino.dart.expect
View file @
c0b5db6c
...
...
@@ -123,4 +123,8 @@ void main() {
CupertinoTextField.borderless(maxLengthEnforcement: MaxLengthEnforcement.none);
final CupertinoTextField textField;
textField.maxLengthEnforcement;
// Changes made in https://github.com/flutter/flutter/pull/59127
const BottomNavigationBarItem bottomNavigationBarItem = BottomNavigationBarItem(label: myTitle);
bottomNavigationBarItem.label;
}
packages/flutter/test_fixes/material.dart
View file @
c0b5db6c
...
...
@@ -174,4 +174,8 @@ void main() {
textField
.
maxLengthEnforced
;
TextFormField
(
maxLengthEnforced:
true
);
TextFormField
(
maxLengthEnforced:
false
);
// Changes made in https://github.com/flutter/flutter/pull/59127
const
BottomNavigationBarItem
bottomNavigationBarItem
=
BottomNavigationBarItem
(
title:
myTitle
);
bottomNavigationBarItem
.
title
;
}
packages/flutter/test_fixes/material.dart.expect
View file @
c0b5db6c
...
...
@@ -174,4 +174,8 @@ void main() {
textField.maxLengthEnforcement;
TextFormField(maxLengthEnforcement: MaxLengthEnforcement.enforce);
TextFormField(maxLengthEnforcement: MaxLengthEnforcement.none);
// Changes made in https://github.com/flutter/flutter/pull/59127
const BottomNavigationBarItem bottomNavigationBarItem = BottomNavigationBarItem(label: myTitle);
bottomNavigationBarItem.label;
}
packages/flutter/test_fixes/widgets.dart
View file @
c0b5db6c
...
...
@@ -91,4 +91,8 @@ void main() {
AnimatedList
.
of
(
context
,
nullOk:
false
);
SliverAnimatedList
.
of
(
context
,
nullOk:
true
);
SliverAnimatedList
.
of
(
context
,
nullOk:
false
);
// Changes made in https://github.com/flutter/flutter/pull/59127
const
BottomNavigationBarItem
bottomNavigationBarItem
=
BottomNavigationBarItem
(
title:
myTitle
);
bottomNavigationBarItem
.
title
;
}
packages/flutter/test_fixes/widgets.dart.expect
View file @
c0b5db6c
...
...
@@ -91,4 +91,8 @@ void main() {
AnimatedList.of(context);
SliverAnimatedList.maybeOf(context);
SliverAnimatedList.of(context);
// Changes made in https://github.com/flutter/flutter/pull/59127
const BottomNavigationBarItem bottomNavigationBarItem = BottomNavigationBarItem(label: myTitle);
bottomNavigationBarItem.label;
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment