Unverified Commit bfd3f115 authored by Kate Lovett's avatar Kate Lovett Committed by GitHub

Clean up NestedScrollView TODOs (#84594)

parent fdc3fb3f
...@@ -341,7 +341,7 @@ typedef NestedScrollViewHeaderSliversBuilder = List<Widget> Function(BuildContex ...@@ -341,7 +341,7 @@ typedef NestedScrollViewHeaderSliversBuilder = List<Widget> Function(BuildContex
/// ///
/// ### Stretching [SliverAppBar]s /// ### Stretching [SliverAppBar]s
/// ///
// TODO(Piinks): Support stretching, https://github.com/flutter/flutter/issues/54059 // See https://github.com/flutter/flutter/issues/54059
/// Currently, [NestedScrollView] does not support stretching the outer /// Currently, [NestedScrollView] does not support stretching the outer
/// scrollable, e.g. when using [SliverAppBar.stretch]. /// scrollable, e.g. when using [SliverAppBar.stretch].
/// ///
...@@ -1250,10 +1250,6 @@ class _NestedScrollCoordinator implements ScrollActivityDelegate, ScrollHoldCont ...@@ -1250,10 +1250,6 @@ class _NestedScrollCoordinator implements ScrollActivityDelegate, ScrollHoldCont
outerDelta -= _outerPosition!.applyClampedDragUpdate(outerDelta); outerDelta -= _outerPosition!.applyClampedDragUpdate(outerDelta);
// Now deal with any overscroll // Now deal with any overscroll
// TODO(Piinks): Configure which scrollable receives overscroll to
// support stretching app bars. createOuterBallisticScrollActivity will
// need to be updated as it currently assumes the outer position will
// never overscroll, https://github.com/flutter/flutter/issues/54059
for (int i = 0; i < innerPositions.length; ++i) { for (int i = 0; i < innerPositions.length; ++i) {
final double remainingDelta = overscrolls[i] - outerDelta; final double remainingDelta = overscrolls[i] - outerDelta;
if (remainingDelta > 0.0) if (remainingDelta > 0.0)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment