Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
bc11c2a8
Unverified
Commit
bc11c2a8
authored
Sep 17, 2020
by
Jonah Williams
Committed by
GitHub
Sep 17, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[flutter_tools] update windows config feature (#65867)
parent
50fd10fc
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
8 additions
and
4 deletions
+8
-4
features.dart
packages/flutter_tools/lib/src/features.dart
+4
-0
features_test.dart
packages/flutter_tools/test/general.shard/features_test.dart
+4
-4
No files found.
packages/flutter_tools/lib/src/features.dart
View file @
bc11c2a8
...
...
@@ -173,6 +173,10 @@ const Feature flutterWindowsDesktopFeature = Feature(
available:
true
,
enabledByDefault:
false
,
),
dev:
FeatureChannelSetting
(
available:
true
,
enabledByDefault:
false
,
),
);
/// The [Feature] for Android devices.
...
...
packages/flutter_tools/test/general.shard/features_test.dart
View file @
bc11c2a8
...
...
@@ -98,7 +98,7 @@ void main() {
test
(
'flutter Windows desktop help string'
,
()
{
expect
(
flutterWindowsDesktopFeature
.
generateHelpMessage
(),
'Enable or disable Flutter for desktop on Windows. '
'This setting will take effect on the master
channel
.'
);
'This setting will take effect on the master
and dev channels
.'
);
});
test
(
'help string on multiple channels'
,
()
{
...
...
@@ -387,18 +387,18 @@ void main() {
expect
(
featureFlags
.
isWindowsEnabled
,
false
);
}));
test
(
'flutter windows desktop
not
enabled with config on dev'
,
()
=>
testbed
.
run
(()
{
test
(
'flutter windows desktop enabled with config on dev'
,
()
=>
testbed
.
run
(()
{
when
(
mockFlutterVerion
.
channel
).
thenReturn
(
'dev'
);
when
<
bool
>(
mockFlutterConfig
.
getValue
(
'enable-windows-desktop'
)
as
bool
).
thenReturn
(
true
);
expect
(
featureFlags
.
isWindowsEnabled
,
fals
e
);
expect
(
featureFlags
.
isWindowsEnabled
,
tru
e
);
}));
test
(
'flutter windows desktop not enabled with environment variable on dev'
,
()
=>
testbed
.
run
(()
{
when
(
mockFlutterVerion
.
channel
).
thenReturn
(
'dev'
);
when
(
mockPlatform
.
environment
).
thenReturn
(<
String
,
String
>{
'FLUTTER_WINDOWS'
:
'true'
});
expect
(
featureFlags
.
isWindowsEnabled
,
fals
e
);
expect
(
featureFlags
.
isWindowsEnabled
,
tru
e
);
}));
test
(
'flutter windows desktop off by default on beta'
,
()
=>
testbed
.
run
(()
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment