Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
b96c3c22
Unverified
Commit
b96c3c22
authored
Jun 23, 2021
by
Dan Field
Committed by
GitHub
Jun 23, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove per-test timeouts from integration tests (#85098)
parent
5a83c874
Changes
22
Hide whitespace changes
Inline
Side-by-side
Showing
22 changed files
with
18 additions
and
35 deletions
+18
-35
measure_scroll_smoothness_test.dart
...ex_layout/test_driver/measure_scroll_smoothness_test.dart
+0
-1
cull_opacity_perf_e2e.dart
...enchmarks/macrobenchmarks/test/cull_opacity_perf_e2e.dart
+0
-1
multi_widget_construction_perf_e2e.dart
...robenchmarks/test/multi_widget_construction_perf_e2e.dart
+0
-1
util.dart
dev/benchmarks/macrobenchmarks/test/util.dart
+1
-2
cull_opacity_perf_test.dart
...s/macrobenchmarks/test_driver/cull_opacity_perf_test.dart
+0
-1
e2e_test.dart
dev/benchmarks/macrobenchmarks/test_driver/e2e_test.dart
+0
-1
frame_policy_test.dart
...hmarks/macrobenchmarks/test_driver/frame_policy_test.dart
+0
-1
multi_widget_construction_perf_test.dart
...arks/test_driver/multi_widget_construction_perf_test.dart
+0
-1
picture_cache_perf_test.dart
.../macrobenchmarks/test_driver/picture_cache_perf_test.dart
+0
-1
stack_size_perf_test.dart
...rks/macrobenchmarks/test_driver/stack_size_perf_test.dart
+1
-1
util.dart
dev/benchmarks/macrobenchmarks/test_driver/util.dart
+8
-11
stock_view_test.dart
...chmarks/test_apps/stocks/test_driver/stock_view_test.dart
+1
-2
main_test.dart
...ntegration_tests/android_views/test_driver/main_test.dart
+0
-1
main_test.dart
dev/integration_tests/channels/test_driver/main_test.dart
+1
-1
transitions_perf_e2e.dart
...sts/flutter_gallery/test_driver/transitions_perf_e2e.dart
+0
-1
transitions_perf_e2e_test.dart
...lutter_gallery/test_driver/transitions_perf_e2e_test.dart
+0
-1
transitions_perf_test.dart
...ts/flutter_gallery/test_driver/transitions_perf_test.dart
+1
-2
commands_none_test.dart
dev/integration_tests/ui/test_driver/commands_none_test.dart
+1
-1
commands_performance_overlay_test.dart
...sts/ui/test_driver/commands_performance_overlay_test.dart
+1
-1
empty_test.dart
dev/integration_tests/ui/test_driver/empty_test.dart
+1
-1
screenshot_test.dart
dev/integration_tests/ui/test_driver/screenshot_test.dart
+1
-1
integration_test_driver.dart
packages/integration_test/lib/integration_test_driver.dart
+1
-1
No files found.
dev/benchmarks/complex_layout/test_driver/measure_scroll_smoothness_test.dart
View file @
b96c3c22
...
...
@@ -7,7 +7,6 @@ import 'dart:async';
import
'package:integration_test/integration_test_driver.dart'
as
driver
;
Future
<
void
>
main
()
=>
driver
.
integrationDriver
(
timeout:
const
Duration
(
minutes:
5
),
responseDataCallback:
(
Map
<
String
,
dynamic
>?
data
)
async
{
await
driver
.
writeResponseData
(
data
,
...
...
dev/benchmarks/macrobenchmarks/test/cull_opacity_perf_e2e.dart
View file @
b96c3c22
...
...
@@ -15,6 +15,5 @@ Future<void> main() async {
kCullOpacityRouteName
,
pageDelay:
const
Duration
(
seconds:
1
),
duration:
const
Duration
(
seconds:
10
),
timeout:
const
Duration
(
seconds:
45
),
);
}
dev/benchmarks/macrobenchmarks/test/multi_widget_construction_perf_e2e.dart
View file @
b96c3c22
...
...
@@ -12,6 +12,5 @@ void main() {
kMultiWidgetConstructionRouteName
,
pageDelay:
const
Duration
(
seconds:
1
),
duration:
const
Duration
(
seconds:
10
),
timeout:
const
Duration
(
seconds:
45
),
);
}
dev/benchmarks/macrobenchmarks/test/util.dart
View file @
b96c3c22
...
...
@@ -15,7 +15,6 @@ void macroPerfTestE2E(
String
routeName
,
{
Duration
pageDelay
,
Duration
duration
=
const
Duration
(
seconds:
3
),
Duration
timeout
=
const
Duration
(
seconds:
30
),
ControlCallback
body
,
ControlCallback
setup
,
})
{
...
...
@@ -63,5 +62,5 @@ void macroPerfTestE2E(
}
await
durationFuture
;
});
},
semanticsEnabled:
false
,
timeout:
Timeout
(
timeout
)
);
},
semanticsEnabled:
false
);
}
dev/benchmarks/macrobenchmarks/test_driver/cull_opacity_perf_test.dart
View file @
b96c3c22
...
...
@@ -12,6 +12,5 @@ void main() {
kCullOpacityRouteName
,
pageDelay:
const
Duration
(
seconds:
1
),
duration:
const
Duration
(
seconds:
10
),
timeout:
const
Duration
(
minutes:
2
),
);
}
dev/benchmarks/macrobenchmarks/test_driver/e2e_test.dart
View file @
b96c3c22
...
...
@@ -5,7 +5,6 @@
import
'package:integration_test/integration_test_driver.dart'
as
driver
;
Future
<
void
>
main
()
=>
driver
.
integrationDriver
(
timeout:
const
Duration
(
minutes:
5
),
responseDataCallback:
(
Map
<
String
,
dynamic
>
data
)
async
{
await
driver
.
writeResponseData
(
data
[
'performance'
]
as
Map
<
String
,
dynamic
>,
...
...
dev/benchmarks/macrobenchmarks/test_driver/frame_policy_test.dart
View file @
b96c3c22
...
...
@@ -7,7 +7,6 @@ import 'dart:io';
import
'package:integration_test/integration_test_driver.dart'
as
driver
;
Future
<
void
>
main
()
=>
driver
.
integrationDriver
(
timeout:
const
Duration
(
minutes:
1
),
responseDataCallback:
(
Map
<
String
,
dynamic
>
data
)
async
{
final
Map
<
String
,
dynamic
>
benchmarkLiveResult
=
data
[
'benchmarkLive'
]
as
Map
<
String
,
dynamic
>;
...
...
dev/benchmarks/macrobenchmarks/test_driver/multi_widget_construction_perf_test.dart
View file @
b96c3c22
...
...
@@ -12,6 +12,5 @@ void main() {
kMultiWidgetConstructionRouteName
,
pageDelay:
const
Duration
(
seconds:
1
),
duration:
const
Duration
(
seconds:
10
),
timeout:
const
Duration
(
seconds:
45
),
);
}
dev/benchmarks/macrobenchmarks/test_driver/picture_cache_perf_test.dart
View file @
b96c3c22
...
...
@@ -11,7 +11,6 @@ void main() {
macroPerfTest
(
'picture_cache_perf'
,
kPictureCacheRouteName
,
timeout:
const
Duration
(
seconds:
60
),
pageDelay:
const
Duration
(
seconds:
1
),
driverOps:
(
FlutterDriver
driver
)
async
{
final
SerializableFinder
tabBarView
=
find
.
byValueKey
(
'tabbar_view'
);
...
...
dev/benchmarks/macrobenchmarks/test_driver/stack_size_perf_test.dart
View file @
b96c3c22
...
...
@@ -30,7 +30,7 @@ void main() {
await
file
.
writeAsString
(
_encodeJson
(<
String
,
dynamic
>{
'stack_size'
:
stackSizeInBytes
,
}));
}
,
timeout:
const
Timeout
(
kTimeout
)
);
});
}
String
_encodeJson
(
Map
<
String
,
dynamic
>
jsonObject
)
{
...
...
dev/benchmarks/macrobenchmarks/test_driver/util.dart
View file @
b96c3c22
...
...
@@ -6,8 +6,6 @@ import 'package:flutter_driver/flutter_driver.dart';
import
'package:macrobenchmarks/common.dart'
;
import
'package:test/test.dart'
hide
TypeMatcher
,
isInstanceOf
;
const
Duration
kTimeout
=
Duration
(
seconds:
30
);
typedef
DriverTestCallBack
=
Future
<
void
>
Function
(
FlutterDriver
driver
);
Future
<
void
>
runDriverTestForRoute
(
String
routeName
,
DriverTestCallBack
body
)
async
{
...
...
@@ -34,14 +32,13 @@ Future<void> runDriverTestForRoute(String routeName, DriverTestCallBack body) as
}
void
macroPerfTest
(
String
testName
,
String
routeName
,
{
Duration
pageDelay
,
Duration
duration
=
const
Duration
(
seconds:
3
),
Duration
timeout
=
kTimeout
,
Future
<
void
>
Function
(
FlutterDriver
driver
)
driverOps
,
Future
<
void
>
Function
(
FlutterDriver
driver
)
setupOps
,
})
{
String
testName
,
String
routeName
,
{
Duration
pageDelay
,
Duration
duration
=
const
Duration
(
seconds:
3
),
Future
<
void
>
Function
(
FlutterDriver
driver
)
driverOps
,
Future
<
void
>
Function
(
FlutterDriver
driver
)
setupOps
,
})
{
test
(
testName
,
()
async
{
Timeline
timeline
;
await
runDriverTestForRoute
(
routeName
,
(
FlutterDriver
driver
)
async
{
...
...
@@ -67,5 +64,5 @@ void macroPerfTest(
final
TimelineSummary
summary
=
TimelineSummary
.
summarize
(
timeline
);
await
summary
.
writeTimelineToFile
(
testName
,
pretty:
true
);
}
,
timeout:
Timeout
(
timeout
)
);
});
}
dev/benchmarks/test_apps/stocks/test_driver/stock_view_test.dart
View file @
b96c3c22
...
...
@@ -36,8 +36,7 @@ void main() {
final
SerializableFinder
stockOption
=
find
.
byValueKey
(
'AAPL_symbol_name'
);
final
String
symbol
=
await
driver
.
getText
(
stockOption
,
timeout:
const
Duration
(
milliseconds:
500
));
final
String
symbol
=
await
driver
.
getText
(
stockOption
);
expect
(
symbol
,
'AAPL'
);
},
skip:
'Needs to be fixed on Fuchsia.'
);
...
...
dev/integration_tests/android_views/test_driver/main_test.dart
View file @
b96c3c22
...
...
@@ -59,7 +59,6 @@ Future<void> main() async {
await
driver
.
tap
(
tapWindow
);
final
String
windowClickCount
=
await
driver
.
getText
(
find
.
byValueKey
(
'WindowClickCount'
),
timeout:
const
Duration
(
seconds:
5
),
);
expect
(
windowClickCount
,
'Click count: 1'
);
});
...
...
dev/integration_tests/channels/test_driver/main_test.dart
View file @
b96c3c22
...
...
@@ -25,7 +25,7 @@ void main() {
if
(
status
!=
'complete'
)
{
fail
(
'Failed at step
$step
with status
$status
'
);
}
}
,
timeout:
const
Timeout
(
Duration
(
minutes:
1
))
);
});
tearDownAll
(()
async
{
driver
.
close
();
...
...
dev/integration_tests/flutter_gallery/test_driver/transitions_perf_e2e.dart
View file @
b96c3c22
...
...
@@ -48,7 +48,6 @@ void main([List<String> args = const <String>[]]) {
..
removeAll
(
kProfiledDemos
);
await
runDemos
(
unprofiledDemos
.
toList
(),
tester
);
},
timeout:
const
Timeout
(
Duration
(
minutes:
5
)),
semanticsEnabled:
withSemantics
,
);
});
...
...
dev/integration_tests/flutter_gallery/test_driver/transitions_perf_e2e_test.dart
View file @
b96c3c22
...
...
@@ -5,7 +5,6 @@
import
'package:integration_test/integration_test_driver.dart'
as
driver
;
Future
<
void
>
main
()
=>
driver
.
integrationDriver
(
timeout:
const
Duration
(
minutes:
5
),
responseDataCallback:
(
Map
<
String
,
dynamic
>?
data
)
async
{
await
driver
.
writeResponseData
(
data
![
'performance'
]
as
Map
<
String
,
dynamic
>,
...
...
dev/integration_tests/flutter_gallery/test_driver/transitions_perf_test.dart
View file @
b96c3c22
...
...
@@ -130,7 +130,6 @@ Future<void> runDemos(List<String> demos, FlutterDriver driver) async {
await
driver
.
scrollUntilVisible
(
demoList
,
demoItem
,
dyScroll:
-
48.0
,
alignment:
0.5
,
timeout:
const
Duration
(
seconds:
30
),
);
for
(
int
i
=
0
;
i
<
2
;
i
+=
1
)
{
...
...
@@ -218,6 +217,6 @@ void main([List<String> args = const <String>[]]) {
await
runDemos
(
unprofiledDemos
.
toList
(),
driver
);
}
}
,
timeout:
const
Timeout
(
Duration
(
minutes:
5
))
);
});
});
}
dev/integration_tests/ui/test_driver/commands_none_test.dart
View file @
b96c3c22
...
...
@@ -18,6 +18,6 @@ void main() {
test
(
'check that we are in normal mode'
,
()
async
{
expect
(
await
driver
.
requestData
(
'status'
),
'log: paint'
);
await
driver
.
waitForAbsent
(
find
.
byType
(
'PerformanceOverlay'
)
,
timeout:
Duration
.
zero
);
await
driver
.
waitForAbsent
(
find
.
byType
(
'PerformanceOverlay'
));
});
}
dev/integration_tests/ui/test_driver/commands_performance_overlay_test.dart
View file @
b96c3c22
...
...
@@ -18,6 +18,6 @@ void main() {
test
(
'check that we are showing the performance overlay'
,
()
async
{
await
driver
.
requestData
(
'status'
);
// force a reassemble
await
driver
.
waitFor
(
find
.
byType
(
'PerformanceOverlay'
)
,
timeout:
Duration
.
zero
);
await
driver
.
waitFor
(
find
.
byType
(
'PerformanceOverlay'
));
});
}
dev/integration_tests/ui/test_driver/empty_test.dart
View file @
b96c3c22
...
...
@@ -18,6 +18,6 @@ void main() {
await
driver
.
close
();
});
test
(
'empty'
,
()
async
{}
,
timeout:
const
Timeout
(
Duration
(
minutes:
1
))
);
test
(
'empty'
,
()
async
{});
});
}
dev/integration_tests/ui/test_driver/screenshot_test.dart
View file @
b96c3c22
...
...
@@ -48,6 +48,6 @@ void main() {
imageBefore
=
imageAfter
;
}
}
,
timeout:
const
Timeout
(
Duration
(
minutes:
2
))
);
});
});
}
packages/integration_test/lib/integration_test_driver.dart
View file @
b96c3c22
...
...
@@ -64,7 +64,7 @@ Future<void> writeResponseData(
///
/// ```
Future
<
void
>
integrationDriver
({
Duration
timeout
=
const
Duration
(
minutes:
1
),
Duration
timeout
=
const
Duration
(
minutes:
20
),
ResponseDataCallback
?
responseDataCallback
=
writeResponseData
,
})
async
{
final
FlutterDriver
driver
=
await
FlutterDriver
.
connect
();
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment