Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
b730ba1a
Unverified
Commit
b730ba1a
authored
Jul 13, 2021
by
Kate Lovett
Committed by
GitHub
Jul 13, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Dart Fixes for clipBehavior breaks (#86323)
parent
caf21362
Changes
9
Hide whitespace changes
Inline
Side-by-side
Showing
9 changed files
with
335 additions
and
0 deletions
+335
-0
fix_data.yaml
packages/flutter/lib/fix_data.yaml
+219
-0
cupertino.dart
packages/flutter/test_fixes/cupertino.dart
+13
-0
cupertino.dart.expect
packages/flutter/test_fixes/cupertino.dart.expect
+13
-0
material.dart
packages/flutter/test_fixes/material.dart
+13
-0
material.dart.expect
packages/flutter/test_fixes/material.dart.expect
+13
-0
rendering.dart
packages/flutter/test_fixes/rendering.dart
+19
-0
rendering.dart.expect
packages/flutter/test_fixes/rendering.dart.expect
+19
-0
widgets.dart
packages/flutter/test_fixes/widgets.dart
+13
-0
widgets.dart.expect
packages/flutter/test_fixes/widgets.dart.expect
+13
-0
No files found.
packages/flutter/lib/fix_data.yaml
View file @
b730ba1a
...
...
@@ -15,6 +15,225 @@
version
:
1
transforms
:
# Changes made in https://flutter.dev/docs/release/breaking-changes/clip-behavior
-
title
:
"
Migrate
to
'clipBehavior'"
date
:
2020-08-20
element
:
uris
:
[
'
rendering.dart'
]
field
:
'
clipToSize'
inClass
:
'
RenderListWheelViewport'
changes
:
-
kind
:
'
rename'
newName
:
'
clipBehavior'
# Changes made in https://flutter.dev/docs/release/breaking-changes/clip-behavior
-
title
:
"
Migrate
to
'clipBehavior'"
date
:
2020-08-20
element
:
uris
:
[
'
rendering.dart'
]
constructor
:
'
'
inClass
:
'
RenderListWheelViewport'
oneOf
:
-
if
:
"
clipToSize
==
'true'"
changes
:
-
kind
:
'
addParameter'
index
:
13
name
:
'
clipBehavior'
style
:
optional_named
argumentValue
:
expression
:
'
Clip.hardEdge'
requiredIf
:
"
clipToSize
==
'true'"
-
kind
:
'
removeParameter'
name
:
'
clipToSize'
-
if
:
"
clipToSize
==
'false'"
changes
:
-
kind
:
'
addParameter'
index
:
13
name
:
'
clipBehavior'
style
:
optional_named
argumentValue
:
expression
:
'
Clip.none'
requiredIf
:
"
clipToSize
==
'false'"
-
kind
:
'
removeParameter'
name
:
'
clipToSize'
variables
:
clipToSize
:
kind
:
'
fragment'
value
:
'
arguments[clipToSize]'
# Changes made in https://flutter.dev/docs/release/breaking-changes/clip-behavior
-
title
:
"
Migrate
to
'clipBehavior'"
date
:
2020-08-20
element
:
uris
:
[
'
widgets.dart'
,
'
material.dart'
,
'
cupertino.dart'
]
field
:
'
clipToSize'
inClass
:
'
ListWheelViewport'
changes
:
-
kind
:
'
rename'
newName
:
'
clipBehavior'
# Changes made in https://flutter.dev/docs/release/breaking-changes/clip-behavior
-
title
:
"
Migrate
to
'clipBehavior'"
date
:
2020-08-20
element
:
uris
:
[
'
widgets.dart'
,
'
material.dart'
,
'
cupertino.dart'
]
constructor
:
'
'
inClass
:
'
ListWheelViewport'
oneOf
:
-
if
:
"
clipToSize
==
'true'"
changes
:
-
kind
:
'
addParameter'
index
:
13
name
:
'
clipBehavior'
style
:
optional_named
argumentValue
:
expression
:
'
Clip.hardEdge'
requiredIf
:
"
clipToSize
==
'true'"
-
kind
:
'
removeParameter'
name
:
'
clipToSize'
-
if
:
"
clipToSize
==
'false'"
changes
:
-
kind
:
'
addParameter'
index
:
13
name
:
'
clipBehavior'
style
:
optional_named
argumentValue
:
expression
:
'
Clip.none'
requiredIf
:
"
clipToSize
==
'false'"
-
kind
:
'
removeParameter'
name
:
'
clipToSize'
variables
:
clipToSize
:
kind
:
'
fragment'
value
:
'
arguments[clipToSize]'
# Changes made in https://flutter.dev/docs/release/breaking-changes/clip-behavior
-
title
:
"
Migrate
to
'clipBehavior'"
date
:
2020-08-20
element
:
uris
:
[
'
widgets.dart'
,
'
material.dart'
,
'
cupertino.dart'
]
constructor
:
'
useDelegate'
inClass
:
'
ListWheelScrollView'
oneOf
:
-
if
:
"
clipToSize
==
'true'"
changes
:
-
kind
:
'
addParameter'
index
:
13
name
:
'
clipBehavior'
style
:
optional_named
argumentValue
:
expression
:
'
Clip.hardEdge'
requiredIf
:
"
clipToSize
==
'true'"
-
kind
:
'
removeParameter'
name
:
'
clipToSize'
-
if
:
"
clipToSize
==
'false'"
changes
:
-
kind
:
'
addParameter'
index
:
13
name
:
'
clipBehavior'
style
:
optional_named
argumentValue
:
expression
:
'
Clip.none'
requiredIf
:
"
clipToSize
==
'false'"
-
kind
:
'
removeParameter'
name
:
'
clipToSize'
variables
:
clipToSize
:
kind
:
'
fragment'
value
:
'
arguments[clipToSize]'
# Changes made in https://flutter.dev/docs/release/breaking-changes/clip-behavior
-
title
:
"
Migrate
to
'clipBehavior'"
date
:
2020-08-20
element
:
uris
:
[
'
widgets.dart'
,
'
material.dart'
,
'
cupertino.dart'
]
field
:
'
clipToSize'
inClass
:
'
ListWheelScrollView'
changes
:
-
kind
:
'
rename'
newName
:
'
clipBehavior'
# Changes made in https://flutter.dev/docs/release/breaking-changes/clip-behavior
-
title
:
"
Migrate
to
'clipBehavior'"
date
:
2020-08-20
element
:
uris
:
[
'
widgets.dart'
,
'
material.dart'
,
'
cupertino.dart'
]
constructor
:
'
'
inClass
:
'
ListWheelScrollView'
oneOf
:
-
if
:
"
clipToSize
==
'true'"
changes
:
-
kind
:
'
addParameter'
index
:
13
name
:
'
clipBehavior'
style
:
optional_named
argumentValue
:
expression
:
'
Clip.hardEdge'
requiredIf
:
"
clipToSize
==
'true'"
-
kind
:
'
removeParameter'
name
:
'
clipToSize'
-
if
:
"
clipToSize
==
'false'"
changes
:
-
kind
:
'
addParameter'
index
:
13
name
:
'
clipBehavior'
style
:
optional_named
argumentValue
:
expression
:
'
Clip.none'
requiredIf
:
"
clipToSize
==
'false'"
-
kind
:
'
removeParameter'
name
:
'
clipToSize'
variables
:
clipToSize
:
kind
:
'
fragment'
value
:
'
arguments[clipToSize]'
# Changes made in https://github.com/flutter/flutter/pull/66305
-
title
:
"
Migrate
to
'clipBehavior'"
date
:
2020-09-22
element
:
uris
:
[
'
rendering.dart'
]
field
:
'
overflow'
inClass
:
'
RenderStack'
changes
:
-
kind
:
'
rename'
newName
:
'
clipBehavior'
# Changes made in https://github.com/flutter/flutter/pull/66305
-
title
:
"
Migrate
to
'clipBehavior'"
date
:
2020-09-22
element
:
uris
:
[
'
rendering.dart'
]
constructor
:
'
'
inClass
:
'
RenderStack'
oneOf
:
-
if
:
"
overflow
==
'Overflow.clip'"
changes
:
-
kind
:
'
addParameter'
index
:
0
name
:
'
clipBehavior'
style
:
optional_named
argumentValue
:
expression
:
'
Clip.hardEdge'
requiredIf
:
"
overflow
==
'Overflow.clip'"
-
kind
:
'
removeParameter'
name
:
'
overflow'
-
if
:
"
overflow
==
'Overflow.visible'"
changes
:
-
kind
:
'
addParameter'
index
:
0
name
:
'
clipBehavior'
style
:
optional_named
argumentValue
:
expression
:
'
Clip.none'
requiredIf
:
"
overflow
==
'Overflow.visible'"
-
kind
:
'
removeParameter'
name
:
'
overflow'
variables
:
overflow
:
kind
:
'
fragment'
value
:
'
arguments[overflow]'
# Changes made in https://github.com/flutter/flutter/pull/81303
-
title
:
"
Migrate
to
'setEnabledSystemUIMode'"
date
:
2021-06-08
...
...
packages/flutter/test_fixes/cupertino.dart
View file @
b730ba1a
...
...
@@ -168,4 +168,17 @@ void main() {
renderObjectToWidgetElement
.
insertChildRenderObject
(
renderObject
,
object
);
renderObjectToWidgetElement
.
moveChildRenderObject
(
renderObject
,
object
);
renderObjectToWidgetElement
.
removeChildRenderObject
(
renderObject
);
// Changes made in https://flutter.dev/docs/release/breaking-changes/clip-behavior
ListWheelScrollView
listWheelScrollView
=
ListWheelScrollView
();
listWheelScrollView
=
ListWheelScrollView
(
clipToSize:
true
);
listWheelScrollView
=
ListWheelScrollView
(
clipToSize:
false
);
listWheelScrollView
=
ListWheelScrollView
.
useDelegate
();
listWheelScrollView
=
ListWheelScrollView
.
useDelegate
(
clipToSize:
true
);
listWheelScrollView
=
ListWheelScrollView
.
useDelegate
(
clipToSize:
false
);
listWheelScrollView
.
clipToSize
;
ListWheelViewport
listWheelViewport
=
ListWheelViewport
();
listWheelViewport
=
ListWheelViewport
(
clipToSize:
true
);
listWheelViewport
=
ListWheelViewport
(
clipToSize:
false
);
listWheelViewport
.
clipToSize
;
}
packages/flutter/test_fixes/cupertino.dart.expect
View file @
b730ba1a
...
...
@@ -168,4 +168,17 @@ void main() {
renderObjectToWidgetElement.insertRenderObjectChild(renderObject, object);
renderObjectToWidgetElement.moveRenderObjectChild(renderObject, object);
renderObjectToWidgetElement.removeRenderObjectChild(renderObject);
// Changes made in https://flutter.dev/docs/release/breaking-changes/clip-behavior
ListWheelScrollView listWheelScrollView = ListWheelScrollView();
listWheelScrollView = ListWheelScrollView(clipBehavior: Clip.hardEdge);
listWheelScrollView = ListWheelScrollView(clipBehavior: Clip.none);
listWheelScrollView = ListWheelScrollView.useDelegate();
listWheelScrollView = ListWheelScrollView.useDelegate(clipBehavior: Clip.hardEdge);
listWheelScrollView = ListWheelScrollView.useDelegate(clipBehavior: Clip.none);
listWheelScrollView.clipBehavior;
ListWheelViewport listWheelViewport = ListWheelViewport();
listWheelViewport = ListWheelViewport(clipBehavior: Clip.hardEdge);
listWheelViewport = ListWheelViewport(clipBehavior: Clip.none);
listWheelViewport.clipBehavior;
}
packages/flutter/test_fixes/material.dart
View file @
b730ba1a
...
...
@@ -330,4 +330,17 @@ void main() {
renderObjectToWidgetElement
.
insertChildRenderObject
(
renderObject
,
object
);
renderObjectToWidgetElement
.
moveChildRenderObject
(
renderObject
,
object
);
renderObjectToWidgetElement
.
removeChildRenderObject
(
renderObject
);
// Changes made in https://flutter.dev/docs/release/breaking-changes/clip-behavior
ListWheelScrollView
listWheelScrollView
=
ListWheelScrollView
();
listWheelScrollView
=
ListWheelScrollView
(
clipToSize:
true
);
listWheelScrollView
=
ListWheelScrollView
(
clipToSize:
false
);
listWheelScrollView
=
ListWheelScrollView
.
useDelegate
();
listWheelScrollView
=
ListWheelScrollView
.
useDelegate
(
clipToSize:
true
);
listWheelScrollView
=
ListWheelScrollView
.
useDelegate
(
clipToSize:
false
);
listWheelScrollView
.
clipToSize
;
ListWheelViewport
listWheelViewport
=
ListWheelViewport
();
listWheelViewport
=
ListWheelViewport
(
clipToSize:
true
);
listWheelViewport
=
ListWheelViewport
(
clipToSize:
false
);
listWheelViewport
.
clipToSize
;
}
packages/flutter/test_fixes/material.dart.expect
View file @
b730ba1a
...
...
@@ -302,4 +302,17 @@ void main() {
renderObjectToWidgetElement.insertRenderObjectChild(renderObject, object);
renderObjectToWidgetElement.moveRenderObjectChild(renderObject, object);
renderObjectToWidgetElement.removeRenderObjectChild(renderObject);
// Changes made in https://flutter.dev/docs/release/breaking-changes/clip-behavior
ListWheelScrollView listWheelScrollView = ListWheelScrollView();
listWheelScrollView = ListWheelScrollView(clipBehavior: Clip.hardEdge);
listWheelScrollView = ListWheelScrollView(clipBehavior: Clip.none);
listWheelScrollView = ListWheelScrollView.useDelegate();
listWheelScrollView = ListWheelScrollView.useDelegate(clipBehavior: Clip.hardEdge);
listWheelScrollView = ListWheelScrollView.useDelegate(clipBehavior: Clip.none);
listWheelScrollView.clipBehavior;
ListWheelViewport listWheelViewport = ListWheelViewport();
listWheelViewport = ListWheelViewport(clipBehavior: Clip.hardEdge);
listWheelViewport = ListWheelViewport(clipBehavior: Clip.none);
listWheelViewport.clipBehavior;
}
packages/flutter/test_fixes/rendering.dart
0 → 100644
View file @
b730ba1a
// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import
'package:flutter/rendering.dart'
;
void
main
(
)
{
// Changes made in https://github.com/flutter/flutter/pull/66305
RenderStack
renderStack
=
RenderStack
();
renderStack
=
RenderStack
(
overflow:
Overflow
.
visible
);
renderStack
=
RenderStack
(
overflow:
Overflow
.
clip
);
renderStack
.
overflow
;
// Changes made in https://flutter.dev/docs/release/breaking-changes/clip-behavior
RenderListWheelViewport
renderListWheelViewport
=
RenderListWheelViewport
();
renderListWheelViewport
=
RenderListWheelViewport
(
clipToSize:
true
);
renderListWheelViewport
=
RenderListWheelViewport
(
clipToSize:
false
);
renderListWheelViewport
.
clipToSize
;
}
packages/flutter/test_fixes/rendering.dart.expect
0 → 100644
View file @
b730ba1a
// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import 'package:flutter/rendering.dart';
void main() {
// Changes made in https://github.com/flutter/flutter/pull/66305
RenderStack renderStack = RenderStack();
renderStack = RenderStack(clipBehavior: Clip.none);
renderStack = RenderStack(clipBehavior: Clip.hardEdge);
renderStack.clipBehavior;
// Changes made in https://flutter.dev/docs/release/breaking-changes/clip-behavior
RenderListWheelViewport renderListWheelViewport = RenderListWheelViewport();
renderListWheelViewport = RenderListWheelViewport(clipBehavior: Clip.hardEdge);
renderListWheelViewport = RenderListWheelViewport(clipBehavior: Clip.none);
renderListWheelViewport.clipBehavior;
}
packages/flutter/test_fixes/widgets.dart
View file @
b730ba1a
...
...
@@ -136,4 +136,17 @@ void main() {
renderObjectToWidgetElement
.
insertChildRenderObject
(
renderObject
,
object
);
renderObjectToWidgetElement
.
moveChildRenderObject
(
renderObject
,
object
);
renderObjectToWidgetElement
.
removeChildRenderObject
(
renderObject
);
// Changes made in https://flutter.dev/docs/release/breaking-changes/clip-behavior
ListWheelScrollView
listWheelScrollView
=
ListWheelScrollView
();
listWheelScrollView
=
ListWheelScrollView
(
clipToSize:
true
);
listWheelScrollView
=
ListWheelScrollView
(
clipToSize:
false
);
listWheelScrollView
=
ListWheelScrollView
.
useDelegate
();
listWheelScrollView
=
ListWheelScrollView
.
useDelegate
(
clipToSize:
true
);
listWheelScrollView
=
ListWheelScrollView
.
useDelegate
(
clipToSize:
false
);
listWheelScrollView
.
clipToSize
;
ListWheelViewport
listWheelViewport
=
ListWheelViewport
();
listWheelViewport
=
ListWheelViewport
(
clipToSize:
true
);
listWheelViewport
=
ListWheelViewport
(
clipToSize:
false
);
listWheelViewport
.
clipToSize
;
}
packages/flutter/test_fixes/widgets.dart.expect
View file @
b730ba1a
...
...
@@ -136,4 +136,17 @@ void main() {
renderObjectToWidgetElement.insertRenderObjectChild(renderObject, object);
renderObjectToWidgetElement.moveRenderObjectChild(renderObject, object);
renderObjectToWidgetElement.removeRenderObjectChild(renderObject);
// Changes made in https://flutter.dev/docs/release/breaking-changes/clip-behavior
ListWheelScrollView listWheelScrollView = ListWheelScrollView();
listWheelScrollView = ListWheelScrollView(clipBehavior: Clip.hardEdge);
listWheelScrollView = ListWheelScrollView(clipBehavior: Clip.none);
listWheelScrollView = ListWheelScrollView.useDelegate();
listWheelScrollView = ListWheelScrollView.useDelegate(clipBehavior: Clip.hardEdge);
listWheelScrollView = ListWheelScrollView.useDelegate(clipBehavior: Clip.none);
listWheelScrollView.clipBehavior;
ListWheelViewport listWheelViewport = ListWheelViewport();
listWheelViewport = ListWheelViewport(clipBehavior: Clip.hardEdge);
listWheelViewport = ListWheelViewport(clipBehavior: Clip.none);
listWheelViewport.clipBehavior;
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment