Unverified Commit b63683b6 authored by Jonah Williams's avatar Jonah Williams Committed by GitHub

Update configuration for flutter features (#45914)

parent 8cf20f3b
...@@ -91,6 +91,10 @@ const Feature flutterWebFeature = Feature( ...@@ -91,6 +91,10 @@ const Feature flutterWebFeature = Feature(
available: true, available: true,
enabledByDefault: false, enabledByDefault: false,
), ),
beta: FeatureChannelSetting(
available: true,
enabledByDefault: false,
),
); );
/// The [Feature] for macOS desktop. /// The [Feature] for macOS desktop.
......
...@@ -78,7 +78,7 @@ void main() { ...@@ -78,7 +78,7 @@ void main() {
})); }));
test('flutter web help string', () { test('flutter web help string', () {
expect(flutterWebFeature.generateHelpMessage(), 'Enable or disable Flutter for web. This setting will take effect on the master and dev channels.'); expect(flutterWebFeature.generateHelpMessage(), 'Enable or disable Flutter for web. This setting will take effect on the master, dev, and beta channels.');
}); });
test('flutter macOS desktop help string', () { test('flutter macOS desktop help string', () {
...@@ -155,18 +155,18 @@ void main() { ...@@ -155,18 +155,18 @@ void main() {
expect(featureFlags.isWebEnabled, false); expect(featureFlags.isWebEnabled, false);
})); }));
test('flutter web not enabled with config on beta', () => testbed.run(() { test('flutter web enabled with config on beta', () => testbed.run(() {
when(mockFlutterVerion.channel).thenReturn('beta'); when(mockFlutterVerion.channel).thenReturn('beta');
when<bool>(mockFlutterConfig.getValue('enable-web') as bool).thenReturn(true); when<bool>(mockFlutterConfig.getValue('enable-web') as bool).thenReturn(true);
expect(featureFlags.isWebEnabled, false); expect(featureFlags.isWebEnabled, true);
})); }));
test('flutter web not enabled with environment variable on beta', () => testbed.run(() { test('flutter web not enabled with environment variable on beta', () => testbed.run(() {
when(mockFlutterVerion.channel).thenReturn('beta'); when(mockFlutterVerion.channel).thenReturn('beta');
when(mockPlatform.environment).thenReturn(<String, String>{'FLUTTER_WEB': 'true'}); when(mockPlatform.environment).thenReturn(<String, String>{'FLUTTER_WEB': 'true'});
expect(featureFlags.isWebEnabled, false); expect(featureFlags.isWebEnabled, true);
})); }));
test('flutter web off by default on stable', () => testbed.run(() { test('flutter web off by default on stable', () => testbed.run(() {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment