Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
b432af51
Commit
b432af51
authored
Apr 27, 2017
by
Michael Goderbauer
Committed by
GitHub
Apr 27, 2017
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Don't crash when ADB exits with non-zero exit code (#9653)
parent
36052e68
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
7 additions
and
1 deletion
+7
-1
android_device.dart
packages/flutter_tools/lib/src/android/android_device.dart
+7
-1
No files found.
packages/flutter_tools/lib/src/android/android_device.dart
View file @
b432af51
...
...
@@ -238,14 +238,20 @@ class AndroidDevice extends Device {
return
false
;
final
Status
status
=
logger
.
startProgress
(
'Installing
${apk.apkPath}
...'
,
expectSlowOperation:
true
);
final
RunResult
installResult
=
await
run
Checked
Async
(
adbCommandForDevice
(<
String
>[
'install'
,
'-r'
,
apk
.
apkPath
]));
final
RunResult
installResult
=
await
runAsync
(
adbCommandForDevice
(<
String
>[
'install'
,
'-r'
,
apk
.
apkPath
]));
status
.
stop
();
// Some versions of adb exit with exit code 0 even on failure :(
// Parsing the output to check for failures.
final
RegExp
failureExp
=
new
RegExp
(
r'^Failure.*$'
,
multiLine:
true
);
final
String
failure
=
failureExp
.
stringMatch
(
installResult
.
stdout
);
if
(
failure
!=
null
)
{
printError
(
'Package install error:
$failure
'
);
return
false
;
}
if
(
installResult
.
exitCode
!=
0
)
{
printError
(
'Error: ADB exited with exit code
${installResult.exitCode}
'
);
return
false
;
}
await
runCheckedAsync
(
adbCommandForDevice
(<
String
>[
'shell'
,
'echo'
,
'-n'
,
_getSourceSha1
(
app
),
'>'
,
_getDeviceSha1Path
(
app
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment