Do not process a command from the terminal if we are still processing a command (#6966)

b40b54e3 · John McCutchan · GitHub · c1a3100e · b40b54e3
Commit b40b54e3 authored Nov 21, 2016 by John McCutchan Committed by GitHub Nov 21, 2016
Hide whitespace changes
Inline Side-by-side

Showing with 14 additions and 3 deletions

resident_runner.dart packages/flutter_tools/lib/src/resident_runner.dart +14 -3

No files found.
--- a/packages/flutter_tools/lib/src/resident_runner.dart
+++ b/packages/flutter_tools/lib/src/resident_runner.dart
@@ -163,10 +163,21 @@ abstract class ResidentRunner {
    return false;
  }
+  bool _processingTerminalRequest = false;
  Future<Null> processTerminalInput(String command) async {
-    bool handled = await _commonTerminalInputHandler(command);
+    if (_processingTerminalRequest) {
-    if (!handled)
+      printTrace('Ignoring terminal input: "$command" because we are busy.');
-      await handleTerminalCommand(command);
+      return;
+    }
+    _processingTerminalRequest = true;
+    try {
+      bool handled = await _commonTerminalInputHandler(command);
+      if (!handled)
+        await handleTerminalCommand(command);
+    } finally {
+      _processingTerminalRequest = false;
+    }
  }
  void appFinished() {