Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
b1b0d20a
Unverified
Commit
b1b0d20a
authored
Jul 07, 2021
by
Jonah Williams
Committed by
GitHub
Jul 07, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[flutter_tools] revert change to SETLOCAL ENABLEDELAYEDEXPANSION (#86000)
parent
8a022dc2
Changes
5
Show whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
70 additions
and
4 deletions
+70
-4
dart.bat
bin/dart.bat
+2
-0
flutter.bat
bin/flutter.bat
+2
-0
exit_code_test.dart
.../flutter_tools/test/integration.shard/exit_code_test.dart
+62
-0
overall_experience_test.dart
...tools/test/integration.shard/overall_experience_test.dart
+3
-3
variable_expansion_windows_test.dart
...st/integration.shard/variable_expansion_windows_test.dart
+1
-1
No files found.
bin/dart.bat
View file @
b1b0d20a
...
...
@@ -11,6 +11,8 @@ REM work across all platforms!
REM
REM --------------------------------------------------------------------------
SETLOCAL ENABLEDELAYEDEXPANSION
FOR %%i IN ("%~dp0..") DO SET FLUTTER_ROOT=%%~fi
REM Include shared scripts in shared.bat
...
...
bin/flutter.bat
View file @
b1b0d20a
...
...
@@ -11,6 +11,8 @@ REM work across all platforms!
REM
REM --------------------------------------------------------------------------
SETLOCAL ENABLEDELAYEDEXPANSION
FOR %%i IN ("%~dp0..") DO SET FLUTTER_ROOT=%%~fi
REM If available, add location of bundled mingit to PATH
...
...
packages/flutter_tools/test/integration.shard/exit_code_test.dart
0 → 100644
View file @
b1b0d20a
// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// @dart = 2.8
import
'package:file/file.dart'
;
import
'package:flutter_tools/src/base/io.dart'
;
import
'../src/common.dart'
;
import
'test_utils.dart'
;
void
main
(
)
{
final
String
dartBin
=
fileSystem
.
path
.
join
(
getFlutterRoot
(),
'bin'
,
'dart'
);
Directory
tempDir
;
setUp
(()
{
tempDir
=
createResolvedTempDirectorySync
(
'exit_code_test.'
);
});
tearDown
(()
{
tryToDelete
(
tempDir
);
});
testWithoutContext
(
'dart.sh/bat can return a zero exit code'
,
()
async
{
tempDir
.
childFile
(
'main.dart'
)
.
writeAsStringSync
(
'''
import '
dart:
io
';
void main() {
exit(0);
}
'''
);
final
ProcessResult
result
=
await
processManager
.
run
(<
String
>[
dartBin
,
fileSystem
.
path
.
join
(
tempDir
.
path
,
'main.dart'
),
]);
print
(
result
.
stdout
);
print
(
result
.
stderr
);
expect
(
result
.
exitCode
,
0
);
});
testWithoutContext
(
'dart.sh/bat can return a non-zero exit code'
,
()
async
{
tempDir
.
childFile
(
'main.dart'
)
.
writeAsStringSync
(
'''
import '
dart:
io
';
void main() {
exit(1);
}
'''
);
final
ProcessResult
result
=
await
processManager
.
run
(<
String
>[
dartBin
,
fileSystem
.
path
.
join
(
tempDir
.
path
,
'main.dart'
),
]);
print
(
result
.
stdout
);
print
(
result
.
stderr
);
expect
(
result
.
exitCode
,
1
);
});
}
packages/flutter_tools/test/integration.shard/overall_experience_test.dart
View file @
b1b0d20a
...
...
@@ -33,7 +33,7 @@ import 'package:pedantic/pedantic.dart';
import
'package:process/process.dart'
;
import
'../src/common.dart'
;
import
'test_utils.dart'
show
fileSystem
;
import
'test_utils.dart'
show
fileSystem
,
platform
;
const
ProcessManager
processManager
=
LocalProcessManager
();
final
String
flutterRoot
=
getFlutterRoot
();
...
...
@@ -315,7 +315,7 @@ void main() {
}
finally
{
tryToDelete
(
fileSystem
.
directory
(
tempDirectory
));
}
});
}
,
skip:
platform
.
isWindows
);
testWithoutContext
(
'flutter run handle SIGUSR1/2'
,
()
async
{
final
String
tempDirectory
=
fileSystem
.
systemTempDirectory
.
createTempSync
(
'flutter_overall_experience_test.'
).
resolveSymbolicLinksSync
();
...
...
@@ -591,5 +591,5 @@ void main() {
''
,
'Application finished.'
,
]);
}
);
}
,
skip:
Platform
.
isWindows
);
// TODO(jonahwilliams): Re-enable when this test is reliable on device lab, https://github.com/flutter/flutter/issues/81556
}
packages/flutter_tools/test/integration.shard/variable_expansion_windows_test.dart
View file @
b1b0d20a
...
...
@@ -17,5 +17,5 @@ void main() {
'"^(?!Golden).+"'
,
]);
expect
(
result
.
stdout
,
contains
(
'args: ["(?!Golden).+"]'
));
},
skip:
!
platform
.
isWindows
);
},
skip:
'Reverted in https://github.com/flutter/flutter/pull/86000'
);
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment