Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
b15798fa
Unverified
Commit
b15798fa
authored
Jun 30, 2020
by
Christopher Fujino
Committed by
GitHub
Jun 30, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Revert "Revert "[flutter_tools] update libimobiledevice (#59512)" (#60551)" (#60569)
This reverts commit
09cca73a
.
parent
59aed976
Changes
9
Show whitespace changes
Inline
Side-by-side
Showing
9 changed files
with
15 additions
and
14 deletions
+15
-14
ideviceinstaller.version
bin/internal/ideviceinstaller.version
+0
-1
libimobiledevice.version
bin/internal/libimobiledevice.version
+1
-1
libplist.version
bin/internal/libplist.version
+1
-1
openssl.version
bin/internal/openssl.version
+1
-1
usbmuxd.version
bin/internal/usbmuxd.version
+1
-1
devices.dart
packages/flutter_tools/lib/src/ios/devices.dart
+3
-3
mac.dart
packages/flutter_tools/lib/src/ios/mac.dart
+3
-1
ios_device_port_forwarder_test.dart
...est/general.shard/ios/ios_device_port_forwarder_test.dart
+2
-2
mac_test.dart
packages/flutter_tools/test/general.shard/ios/mac_test.dart
+3
-3
No files found.
bin/internal/ideviceinstaller.version
deleted
100644 → 0
View file @
59aed976
73b9c81e02f83060aa44bece963a62827908de68
bin/internal/libimobiledevice.version
View file @
b15798fa
6150fcd888a0ee8a69dd47328509ee608c2e02dc
569016da35ccea9d9b7c81954342fabb98149fb5
bin/internal/libplist.version
View file @
b15798fa
2
8812e5bed8621bd637b4129ab15a9c1abb9f57d
2
0a2f8dbddcf1a96ad4c720b9afd1d0876d17ffc
bin/internal/openssl.version
View file @
b15798fa
2ef3f4c83bce209247479e707eebd5a84f606e28
e2e09d9fba1187f8d6aafaa34d4172f56f1ffb72
bin/internal/usbmuxd.version
View file @
b15798fa
eb45fd21469fa35e9bbc3b0a15a962460b8d23a2
ce98c346b7c1dc2a21faea4fd3f32c88e27ca2af
packages/flutter_tools/lib/src/ios/devices.dart
View file @
b15798fa
...
@@ -513,7 +513,7 @@ class IOSDevice extends Device {
...
@@ -513,7 +513,7 @@ class IOSDevice extends Device {
@override
@override
Future
<
void
>
takeScreenshot
(
File
outputFile
)
async
{
Future
<
void
>
takeScreenshot
(
File
outputFile
)
async
{
await
_iMobileDevice
.
takeScreenshot
(
outputFile
);
await
_iMobileDevice
.
takeScreenshot
(
outputFile
,
id
);
}
}
@override
@override
...
@@ -835,8 +835,8 @@ class IOSDevicePortForwarder extends DevicePortForwarder {
...
@@ -835,8 +835,8 @@ class IOSDevicePortForwarder extends DevicePortForwarder {
process
=
await
_processUtils
.
start
(
process
=
await
_processUtils
.
start
(
<
String
>[
<
String
>[
_iproxyPath
,
_iproxyPath
,
hostPort
.
toString
()
,
'
$hostPort
:
$devicePort
'
,
devicePort
.
toString
()
,
'--udid'
,
_id
,
_id
,
],
],
environment:
Map
<
String
,
String
>.
fromEntries
(
environment:
Map
<
String
,
String
>.
fromEntries
(
...
...
packages/flutter_tools/lib/src/ios/mac.dart
View file @
b15798fa
...
@@ -66,11 +66,13 @@ class IMobileDevice {
...
@@ -66,11 +66,13 @@ class IMobileDevice {
}
}
/// Captures a screenshot to the specified outputFile.
/// Captures a screenshot to the specified outputFile.
Future
<
void
>
takeScreenshot
(
File
outputFile
)
{
Future
<
void
>
takeScreenshot
(
File
outputFile
,
String
deviceID
)
{
return
_processUtils
.
run
(
return
_processUtils
.
run
(
<
String
>[
<
String
>[
_idevicescreenshotPath
,
_idevicescreenshotPath
,
outputFile
.
path
,
outputFile
.
path
,
'--udid'
,
deviceID
,
],
],
throwOnError:
true
,
throwOnError:
true
,
environment:
Map
<
String
,
String
>.
fromEntries
(
environment:
Map
<
String
,
String
>.
fromEntries
(
...
...
packages/flutter_tools/test/general.shard/ios/ios_device_port_forwarder_test.dart
View file @
b15798fa
...
@@ -22,14 +22,14 @@ void main() {
...
@@ -22,14 +22,14 @@ void main() {
const
int
devicePort
=
456
;
const
int
devicePort
=
456
;
final
FakeProcessManager
processManager
=
FakeProcessManager
.
list
(<
FakeCommand
>[
final
FakeProcessManager
processManager
=
FakeProcessManager
.
list
(<
FakeCommand
>[
const
FakeCommand
(
const
FakeCommand
(
command:
<
String
>[
'iproxy'
,
'49154
'
,
'456
'
,
'1234'
],
command:
<
String
>[
'iproxy'
,
'49154
:456'
,
'--udid
'
,
'1234'
],
// iproxy does not exit with 0 when it cannot forward.
// iproxy does not exit with 0 when it cannot forward.
exitCode:
0
,
exitCode:
0
,
stdout:
null
,
// no stdout indicates failure.
stdout:
null
,
// no stdout indicates failure.
environment:
kDyLdLibEntry
,
environment:
kDyLdLibEntry
,
),
),
const
FakeCommand
(
const
FakeCommand
(
command:
<
String
>[
'iproxy'
,
'49155
'
,
'456
'
,
'1234'
],
command:
<
String
>[
'iproxy'
,
'49155
:456'
,
'--udid
'
,
'1234'
],
exitCode:
0
,
exitCode:
0
,
stdout:
'not empty'
,
stdout:
'not empty'
,
environment:
kDyLdLibEntry
,
environment:
kDyLdLibEntry
,
...
...
packages/flutter_tools/test/general.shard/ios/mac_test.dart
View file @
b15798fa
...
@@ -85,7 +85,7 @@ void main() {
...
@@ -85,7 +85,7 @@ void main() {
logger:
logger
,
logger:
logger
,
);
);
expect
(()
async
=>
await
iMobileDevice
.
takeScreenshot
(
mockOutputFile
),
throwsA
(
anything
));
expect
(()
async
=>
await
iMobileDevice
.
takeScreenshot
(
mockOutputFile
,
'1234'
),
throwsA
(
anything
));
});
});
testWithoutContext
(
'idevicescreenshot captures and returns screenshot'
,
()
async
{
testWithoutContext
(
'idevicescreenshot captures and returns screenshot'
,
()
async
{
...
@@ -100,8 +100,8 @@ void main() {
...
@@ -100,8 +100,8 @@ void main() {
logger:
logger
,
logger:
logger
,
);
);
await
iMobileDevice
.
takeScreenshot
(
mockOutputFile
);
await
iMobileDevice
.
takeScreenshot
(
mockOutputFile
,
'1234'
);
verify
(
mockProcessManager
.
run
(<
String
>[
idevicescreenshotPath
,
outputPath
],
verify
(
mockProcessManager
.
run
(<
String
>[
idevicescreenshotPath
,
outputPath
,
'--udid'
,
'1234'
],
environment:
<
String
,
String
>{
'DYLD_LIBRARY_PATH'
:
libimobiledevicePath
},
environment:
<
String
,
String
>{
'DYLD_LIBRARY_PATH'
:
libimobiledevicePath
},
workingDirectory:
null
,
workingDirectory:
null
,
));
));
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment