Unverified Commit b0b2c007 authored by Siva's avatar Siva Committed by GitHub

Turn support for sync-async on in Flutter. (#16543)

* Turn support for sync-async on in Flutter. With this feature
execution of async functions starts immediately instead of it
being delayed by one microtask tick.

* Address review comments.

* Adjust some stack trace expectations which are slightly different with
--sync-async turned on.
parent 6c049ec2
...@@ -43,7 +43,7 @@ Who lives, who dies, who tells your story\? ...@@ -43,7 +43,7 @@ Who lives, who dies, who tells your story\?
When the exception was thrown, this was the stack: When the exception was thrown, this was the stack:
#[0-9]+ +main.<anonymous closure> \(.+[/\\]dev[/\\]automated_tests[/\\]flutter_test[/\\]exception_handling_test\.dart:16:9\) #[0-9]+ +main.<anonymous closure> \(.+[/\\]dev[/\\]automated_tests[/\\]flutter_test[/\\]exception_handling_test\.dart:16:9\)
#[0-9]+ +main.<anonymous closure> \(.+[/\\]dev[/\\]automated_tests[/\\]flutter_test[/\\]exception_handling_test\.dart:15:77\) <<skip until matching line>>
#[0-9]+ +.+ \(package:flutter_test[/\\]src[/\\]widget_tester\.dart:[0-9]+:[0-9]+\) #[0-9]+ +.+ \(package:flutter_test[/\\]src[/\\]widget_tester\.dart:[0-9]+:[0-9]+\)
<<skip until matching line>> <<skip until matching line>>
^\(elided [0-9]+ .+\)$ ^\(elided [0-9]+ .+\)$
......
...@@ -18,6 +18,10 @@ When the exception was thrown, this was the stack: ...@@ -18,6 +18,10 @@ When the exception was thrown, this was the stack:
The test description was: The test description was:
TestAsyncUtils - custom guarded sections TestAsyncUtils - custom guarded sections
════════════════════════════════════════════════════════════════════════════════════════════════════ ════════════════════════════════════════════════════════════════════════════════════════════════════
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following message was thrown:
Multiple exceptions \(2\) were detected during the running of the current test, and at least one was unexpected.
════════════════════════════════════════════════════════════════════════════════════════════════════
.*(this line has more of the test framework's output)? .*(this line has more of the test framework's output)?
Test failed\. See exception logs above\. Test failed\. See exception logs above\.
The test description was: TestAsyncUtils - custom guarded sections The test description was: TestAsyncUtils - custom guarded sections
......
...@@ -90,6 +90,7 @@ Future<CompilerOutput> compile( ...@@ -90,6 +90,7 @@ Future<CompilerOutput> compile(
'--sdk-root', '--sdk-root',
sdkRoot, sdkRoot,
'--strong', '--strong',
'--sync-async',
'--target=flutter', '--target=flutter',
]; ];
if (trackWidgetCreation) if (trackWidgetCreation)
...@@ -215,6 +216,7 @@ class ResidentCompiler { ...@@ -215,6 +216,7 @@ class ResidentCompiler {
_sdkRoot, _sdkRoot,
'--incremental', '--incremental',
'--strong', '--strong',
'--sync-async',
'--target=flutter', '--target=flutter',
]; ];
if (outputPath != null) { if (outputPath != null) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment