Unverified Commit afa24b1a authored by Jonah Williams's avatar Jonah Williams Committed by GitHub

[flutter_tools] only strip when bitcode is enabled (#49595)

parent fdb0225f
......@@ -137,7 +137,11 @@ class AOTSnapshotter {
outputPaths.add(assembly);
genSnapshotArgs.add('--snapshot_kind=app-aot-assembly');
genSnapshotArgs.add('--assembly=$assembly');
genSnapshotArgs.add('--strip');
// TODO(jonahwilliams): determine the correct time to use strip
// since this is required for the future dwarf strack traces option.
if (bitcode) {
genSnapshotArgs.add('--strip');
}
} else {
final String aotSharedLibrary = globals.fs.path.join(outputDir.path, 'app.so');
outputPaths.add(aotSharedLibrary);
......
......@@ -445,7 +445,6 @@ void main() {
'--deterministic',
'--snapshot_kind=app-aot-assembly',
'--assembly=$assembly',
'--strip',
'--no-sim-use-hardfp',
'--no-use-integer-division',
'--no-causal-async-stacks',
......@@ -495,7 +494,6 @@ void main() {
'--deterministic',
'--snapshot_kind=app-aot-assembly',
'--assembly=${globals.fs.path.join(outputPath, 'snapshot_assembly.S')}',
'--strip',
'--no-causal-async-stacks',
'--lazy-async-stacks',
'main.dill',
......@@ -534,7 +532,6 @@ void main() {
'--deterministic',
'--snapshot_kind=app-aot-assembly',
'--assembly=${globals.fs.path.join(outputPath, 'snapshot_assembly.S')}',
'--strip',
'--no-sim-use-hardfp',
'--no-use-integer-division',
'--no-causal-async-stacks',
......@@ -575,7 +572,6 @@ void main() {
'--deterministic',
'--snapshot_kind=app-aot-assembly',
'--assembly=${globals.fs.path.join(outputPath, 'snapshot_assembly.S')}',
'--strip',
'--no-causal-async-stacks',
'--lazy-async-stacks',
'main.dill',
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment