Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
afa24b1a
Unverified
Commit
afa24b1a
authored
Jan 28, 2020
by
Jonah Williams
Committed by
GitHub
Jan 28, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[flutter_tools] only strip when bitcode is enabled (#49595)
parent
fdb0225f
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
5 additions
and
5 deletions
+5
-5
build.dart
packages/flutter_tools/lib/src/base/build.dart
+5
-1
build_test.dart
...ges/flutter_tools/test/general.shard/base/build_test.dart
+0
-4
No files found.
packages/flutter_tools/lib/src/base/build.dart
View file @
afa24b1a
...
...
@@ -137,7 +137,11 @@ class AOTSnapshotter {
outputPaths
.
add
(
assembly
);
genSnapshotArgs
.
add
(
'--snapshot_kind=app-aot-assembly'
);
genSnapshotArgs
.
add
(
'--assembly=
$assembly
'
);
genSnapshotArgs
.
add
(
'--strip'
);
// TODO(jonahwilliams): determine the correct time to use strip
// since this is required for the future dwarf strack traces option.
if
(
bitcode
)
{
genSnapshotArgs
.
add
(
'--strip'
);
}
}
else
{
final
String
aotSharedLibrary
=
globals
.
fs
.
path
.
join
(
outputDir
.
path
,
'app.so'
);
outputPaths
.
add
(
aotSharedLibrary
);
...
...
packages/flutter_tools/test/general.shard/base/build_test.dart
View file @
afa24b1a
...
...
@@ -445,7 +445,6 @@ void main() {
'--deterministic'
,
'--snapshot_kind=app-aot-assembly'
,
'--assembly=
$assembly
'
,
'--strip'
,
'--no-sim-use-hardfp'
,
'--no-use-integer-division'
,
'--no-causal-async-stacks'
,
...
...
@@ -495,7 +494,6 @@ void main() {
'--deterministic'
,
'--snapshot_kind=app-aot-assembly'
,
'--assembly=
${globals.fs.path.join(outputPath, 'snapshot_assembly.S')}
'
,
'--strip'
,
'--no-causal-async-stacks'
,
'--lazy-async-stacks'
,
'main.dill'
,
...
...
@@ -534,7 +532,6 @@ void main() {
'--deterministic'
,
'--snapshot_kind=app-aot-assembly'
,
'--assembly=
${globals.fs.path.join(outputPath, 'snapshot_assembly.S')}
'
,
'--strip'
,
'--no-sim-use-hardfp'
,
'--no-use-integer-division'
,
'--no-causal-async-stacks'
,
...
...
@@ -575,7 +572,6 @@ void main() {
'--deterministic'
,
'--snapshot_kind=app-aot-assembly'
,
'--assembly=
${globals.fs.path.join(outputPath, 'snapshot_assembly.S')}
'
,
'--strip'
,
'--no-causal-async-stacks'
,
'--lazy-async-stacks'
,
'main.dill'
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment