Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
af1b7494
Unverified
Commit
af1b7494
authored
Sep 05, 2023
by
Polina Cherkasova
Committed by
GitHub
Sep 05, 2023
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
RenderParagraph should dispose instances of SelectableFragments. (#133915)
parent
c9f70e9f
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
2 additions
and
4 deletions
+2
-4
paragraph.dart
packages/flutter/lib/src/rendering/paragraph.dart
+1
-3
elevated_button_test.dart
packages/flutter/test/material/elevated_button_test.dart
+1
-1
No files found.
packages/flutter/lib/src/rendering/paragraph.dart
View file @
af1b7494
...
...
@@ -437,9 +437,7 @@ class RenderParagraph extends RenderBox with ContainerRenderObjectMixin<RenderBo
@override
void
dispose
()
{
_removeSelectionRegistrarSubscription
();
// _lastSelectableFragments may hold references to this RenderParagraph.
// Release them manually to avoid retain cycles.
_lastSelectableFragments
=
null
;
_disposeSelectableFragments
();
_textPainter
.
dispose
();
super
.
dispose
();
}
...
...
packages/flutter/test/material/elevated_button_test.dart
View file @
af1b7494
...
...
@@ -1684,7 +1684,7 @@ void main() {
expect
(
RendererBinding
.
instance
.
mouseTracker
.
debugDeviceActiveCursor
(
1
),
SystemMouseCursors
.
basic
);
});
testWidgets
(
'ElevatedButton in SelectionArea changes mouse cursor when hovered'
,
(
WidgetTester
tester
)
async
{
testWidgets
WithLeakTracking
(
'ElevatedButton in SelectionArea changes mouse cursor when hovered'
,
(
WidgetTester
tester
)
async
{
// Regression test for https://github.com/flutter/flutter/issues/104595.
await
tester
.
pumpWidget
(
MaterialApp
(
home:
SelectionArea
(
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment