Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
ade6a1b3
Unverified
Commit
ade6a1b3
authored
Mar 10, 2020
by
Michael Goderbauer
Committed by
GitHub
Mar 10, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix a11y scrolling for reversed lists (#52332)
parent
733fc200
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
154 additions
and
5 deletions
+154
-5
scroll_position.dart
packages/flutter/lib/src/widgets/scroll_position.dart
+13
-5
list_view_semantics_test.dart
packages/flutter/test/widgets/list_view_semantics_test.dart
+141
-0
No files found.
packages/flutter/lib/src/widgets/scroll_position.dart
View file @
ade6a1b3
...
...
@@ -447,15 +447,23 @@ abstract class ScrollPosition extends ViewportOffset with ScrollMetrics {
void
_updateSemanticActions
()
{
SemanticsAction
forward
;
SemanticsAction
backward
;
switch
(
axis
)
{
case
Axis
.
vertical
:
forward
=
SemanticsAction
.
scroll
Up
;
backward
=
SemanticsAction
.
scroll
Down
;
switch
(
axis
Direction
)
{
case
Axis
Direction
.
up
:
forward
=
SemanticsAction
.
scroll
Down
;
backward
=
SemanticsAction
.
scroll
Up
;
break
;
case
Axis
.
horizontal
:
case
Axis
Direction
.
right
:
forward
=
SemanticsAction
.
scrollLeft
;
backward
=
SemanticsAction
.
scrollRight
;
break
;
case
AxisDirection
.
down
:
forward
=
SemanticsAction
.
scrollUp
;
backward
=
SemanticsAction
.
scrollDown
;
break
;
case
AxisDirection
.
left
:
forward
=
SemanticsAction
.
scrollRight
;
backward
=
SemanticsAction
.
scrollLeft
;
break
;
}
final
Set
<
SemanticsAction
>
actions
=
<
SemanticsAction
>{};
...
...
packages/flutter/test/widgets/list_view_semantics_test.dart
0 → 100644
View file @
ade6a1b3
// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import
'package:flutter_test/flutter_test.dart'
;
import
'package:flutter/widgets.dart'
;
import
'semantics_tester.dart'
;
void
main
(
)
{
group
(
'Available semantic scroll actions'
,
()
{
// Regression tests for https://github.com/flutter/flutter/issues/52032.
const
int
itemCount
=
10
;
const
double
itemHeight
=
150.0
;
testWidgets
(
'forward vertical'
,
(
WidgetTester
tester
)
async
{
final
SemanticsTester
semantics
=
SemanticsTester
(
tester
);
final
ScrollController
controller
=
ScrollController
();
await
tester
.
pumpWidget
(
Directionality
(
textDirection:
TextDirection
.
ltr
,
child:
ListView
.
builder
(
controller:
controller
,
itemCount:
itemCount
,
itemBuilder:
(
BuildContext
context
,
int
index
)
{
return
SizedBox
(
height:
itemHeight
,
child:
Text
(
'Tile
$index
'
),
);
},
),
),
);
expect
(
semantics
,
includesNodeWith
(
actions:
<
SemanticsAction
>[
SemanticsAction
.
scrollUp
]));
// Jump to the end.
controller
.
jumpTo
(
itemCount
*
itemHeight
);
await
tester
.
pumpAndSettle
();
expect
(
semantics
,
includesNodeWith
(
actions:
<
SemanticsAction
>[
SemanticsAction
.
scrollDown
]));
semantics
.
dispose
();
});
testWidgets
(
'reverse vertical'
,
(
WidgetTester
tester
)
async
{
final
SemanticsTester
semantics
=
SemanticsTester
(
tester
);
final
ScrollController
controller
=
ScrollController
();
await
tester
.
pumpWidget
(
Directionality
(
textDirection:
TextDirection
.
ltr
,
child:
ListView
.
builder
(
reverse:
true
,
controller:
controller
,
itemCount:
itemCount
,
itemBuilder:
(
BuildContext
context
,
int
index
)
{
return
SizedBox
(
height:
itemHeight
,
child:
Text
(
'Tile
$index
'
),
);
},
),
),
);
expect
(
semantics
,
includesNodeWith
(
actions:
<
SemanticsAction
>[
SemanticsAction
.
scrollDown
]));
// Jump to the end.
controller
.
jumpTo
(
itemCount
*
itemHeight
);
await
tester
.
pumpAndSettle
();
expect
(
semantics
,
includesNodeWith
(
actions:
<
SemanticsAction
>[
SemanticsAction
.
scrollUp
]));
semantics
.
dispose
();
});
testWidgets
(
'forward horizontal'
,
(
WidgetTester
tester
)
async
{
final
SemanticsTester
semantics
=
SemanticsTester
(
tester
);
final
ScrollController
controller
=
ScrollController
();
await
tester
.
pumpWidget
(
Directionality
(
textDirection:
TextDirection
.
ltr
,
child:
ListView
.
builder
(
scrollDirection:
Axis
.
horizontal
,
controller:
controller
,
itemCount:
itemCount
,
itemBuilder:
(
BuildContext
context
,
int
index
)
{
return
SizedBox
(
height:
itemHeight
,
child:
Text
(
'Tile
$index
'
),
);
},
),
),
);
expect
(
semantics
,
includesNodeWith
(
actions:
<
SemanticsAction
>[
SemanticsAction
.
scrollLeft
]));
// Jump to the end.
controller
.
jumpTo
(
itemCount
*
itemHeight
);
await
tester
.
pumpAndSettle
();
expect
(
semantics
,
includesNodeWith
(
actions:
<
SemanticsAction
>[
SemanticsAction
.
scrollRight
]));
semantics
.
dispose
();
});
testWidgets
(
'reverse horizontal'
,
(
WidgetTester
tester
)
async
{
final
SemanticsTester
semantics
=
SemanticsTester
(
tester
);
final
ScrollController
controller
=
ScrollController
();
await
tester
.
pumpWidget
(
Directionality
(
textDirection:
TextDirection
.
ltr
,
child:
ListView
.
builder
(
scrollDirection:
Axis
.
horizontal
,
reverse:
true
,
controller:
controller
,
itemCount:
itemCount
,
itemBuilder:
(
BuildContext
context
,
int
index
)
{
return
SizedBox
(
height:
itemHeight
,
child:
Text
(
'Tile
$index
'
),
);
},
),
),
);
expect
(
semantics
,
includesNodeWith
(
actions:
<
SemanticsAction
>[
SemanticsAction
.
scrollRight
]));
// Jump to the end.
controller
.
jumpTo
(
itemCount
*
itemHeight
);
await
tester
.
pumpAndSettle
();
expect
(
semantics
,
includesNodeWith
(
actions:
<
SemanticsAction
>[
SemanticsAction
.
scrollLeft
]));
semantics
.
dispose
();
});
});
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment