Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
ac3189c3
Unverified
Commit
ac3189c3
authored
Feb 08, 2022
by
chunhtai
Committed by
GitHub
Feb 08, 2022
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove RenderEditable dependency from TextSelectionHandleOverlay (#97967)
parent
3afbec88
Changes
4
Expand all
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
209 additions
and
200 deletions
+209
-200
text_selection.dart
packages/flutter/lib/src/widgets/text_selection.dart
+206
-197
text_field_test.dart
packages/flutter/test/material/text_field_test.dart
+1
-1
editable_text_test.dart
packages/flutter/test/widgets/editable_text_test.dart
+1
-1
selectable_text_test.dart
packages/flutter/test/widgets/selectable_text_test.dart
+1
-1
No files found.
packages/flutter/lib/src/widgets/text_selection.dart
View file @
ac3189c3
This diff is collapsed.
Click to expand it.
packages/flutter/test/material/text_field_test.dart
View file @
ac3189c3
...
...
@@ -9138,7 +9138,7 @@ void main() {
await
tester
.
pumpAndSettle
();
final
List
<
FadeTransition
>
transitions
=
find
.
descendant
(
of:
find
.
byWidgetPredicate
((
Widget
w
)
=>
'
${w.runtimeType}
'
==
'_
Text
SelectionHandleOverlay'
),
of:
find
.
byWidgetPredicate
((
Widget
w
)
=>
'
${w.runtimeType}
'
==
'_SelectionHandleOverlay'
),
matching:
find
.
byType
(
FadeTransition
),
).
evaluate
().
map
((
Element
e
)
=>
e
.
widget
).
cast
<
FadeTransition
>().
toList
();
expect
(
transitions
.
length
,
2
);
...
...
packages/flutter/test/widgets/editable_text_test.dart
View file @
ac3189c3
...
...
@@ -4697,7 +4697,7 @@ void main() {
// direction.
final
List
<
FadeTransition
>
transitions
=
find
.
descendant
(
of:
find
.
byWidgetPredicate
((
Widget
w
)
=>
'
${w.runtimeType}
'
==
'_
Text
SelectionHandleOverlay'
),
of:
find
.
byWidgetPredicate
((
Widget
w
)
=>
'
${w.runtimeType}
'
==
'_SelectionHandleOverlay'
),
matching:
find
.
byType
(
FadeTransition
),
).
evaluate
().
map
((
Element
e
)
=>
e
.
widget
).
cast
<
FadeTransition
>().
toList
();
expect
(
transitions
.
length
,
2
);
...
...
packages/flutter/test/widgets/selectable_text_test.dart
View file @
ac3189c3
...
...
@@ -4128,7 +4128,7 @@ void main() {
await
tester
.
pumpAndSettle
();
final
List
<
FadeTransition
>
transitions
=
find
.
descendant
(
of:
find
.
byWidgetPredicate
((
Widget
w
)
=>
'
${w.runtimeType}
'
==
'_
Text
SelectionHandleOverlay'
),
of:
find
.
byWidgetPredicate
((
Widget
w
)
=>
'
${w.runtimeType}
'
==
'_SelectionHandleOverlay'
),
matching:
find
.
byType
(
FadeTransition
),
).
evaluate
().
map
((
Element
e
)
=>
e
.
widget
).
cast
<
FadeTransition
>().
toList
();
expect
(
transitions
.
length
,
2
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment