Skip to content

F
Front-End
Commit aaee3b93 authored by Hixie's avatar Hixie
Browse files
Options

Add more Gesture Arena tests 

...and clean them up so it's easier to understand them.
parent 255ed0b9
Hide whitespace changes
Inline Side-by-side
Showing with 137 additions and 215 deletions
packages/unit/test/gestures/arena_test.dart
View file @ aaee3b93
...@@ -3,239 +3,161 @@ import 'package:test/test.dart'; ...@@ -3,239 +3,161 @@ import 'package:test/test.dart';
typedef void GestureArenaCallback(Object key); typedef void GestureArenaCallback(Object key);
const int primaryKey = 4;
class TestGestureArenaMember extends GestureArenaMember { class TestGestureArenaMember extends GestureArenaMember {
TestGestureArenaMember({ this.onAcceptGesture, this.onRejectGesture }); bool acceptRan = false;
void acceptGesture(Object key) {
expect(key, equals(primaryKey));
acceptRan = true;
}
bool rejectRan = false;
void rejectGesture(Object key) {
expect(key, equals(primaryKey));
rejectRan = true;
}
}
final GestureArenaCallback onAcceptGesture; class GestureTester {
final GestureArenaCallback onRejectGesture; GestureArena arena = new GestureArena();
TestGestureArenaMember first = new TestGestureArenaMember();
TestGestureArenaMember second = new TestGestureArenaMember();
void acceptGesture(Object key) { GestureArenaEntry firstEntry;
onAcceptGesture(key); void addFirst() {
firstEntry = arena.add(primaryKey, first);
} }
void rejectGesture(Object key) { GestureArenaEntry secondEntry;
onRejectGesture(key); void addSecond() {
secondEntry = arena.add(primaryKey, second);
}
void expectNothing() {
expect(first.acceptRan, isFalse);
expect(first.rejectRan, isFalse);
expect(second.acceptRan, isFalse);
expect(second.rejectRan, isFalse);
}
void expectFirstWin() {
expect(first.acceptRan, isTrue);
expect(first.rejectRan, isFalse);
expect(second.acceptRan, isFalse);
expect(second.rejectRan, isTrue);
}
void expectSecondWin() {
expect(first.acceptRan, isFalse);
expect(first.rejectRan, isTrue);
expect(second.acceptRan, isTrue);
expect(second.rejectRan, isFalse);
} }
} }
void main() { void main() {
test('Should win by accepting', () { test('Should win by accepting', () {
GestureArena arena = new GestureArena(); GestureTester tester = new GestureTester();
tester.addFirst();
int primaryKey = 4; tester.addSecond();
bool firstAcceptRan = false; tester.arena.close(primaryKey);
bool firstRejectRan = false; tester.expectNothing();
bool secondAcceptRan = false; tester.firstEntry.resolve(GestureDisposition.accepted);
bool secondRejectRan = false; tester.expectFirstWin();
TestGestureArenaMember first = new TestGestureArenaMember(
onAcceptGesture: (int key) {
expect(key, equals(primaryKey));
firstAcceptRan = true;
},
onRejectGesture: (int key) {
expect(key, equals(primaryKey));
firstRejectRan = true;
}
);
TestGestureArenaMember second = new TestGestureArenaMember(
onAcceptGesture: (int key) {
expect(key, equals(primaryKey));
secondAcceptRan = true;
},
onRejectGesture: (int key) {
expect(key, equals(primaryKey));
secondRejectRan = true;
}
);
GestureArenaEntry firstEntry = arena.add(primaryKey, first);
arena.add(primaryKey, second);
arena.close(primaryKey);
expect(firstAcceptRan, isFalse);
expect(firstRejectRan, isFalse);
expect(secondAcceptRan, isFalse);
expect(secondRejectRan, isFalse);
firstEntry.resolve(GestureDisposition.accepted);
expect(firstAcceptRan, isTrue);
expect(firstRejectRan, isFalse);
expect(secondAcceptRan, isFalse);
expect(secondRejectRan, isTrue);
}); });
test('Should win by sweep', () { test('Should win by sweep', () {
GestureArena arena = new GestureArena(); GestureTester tester = new GestureTester();
tester.addFirst();
int primaryKey = 4; tester.addSecond();
bool firstAcceptRan = false; tester.arena.close(primaryKey);
bool firstRejectRan = false; tester.expectNothing();
bool secondAcceptRan = false; tester.arena.sweep(primaryKey);
bool secondRejectRan = false; tester.expectFirstWin();
TestGestureArenaMember first = new TestGestureArenaMember(
onAcceptGesture: (int key) {
expect(key, equals(primaryKey));
firstAcceptRan = true;
},
onRejectGesture: (int key) {
expect(key, equals(primaryKey));
firstRejectRan = true;
}
);
TestGestureArenaMember second = new TestGestureArenaMember(
onAcceptGesture: (int key) {
expect(key, equals(primaryKey));
secondAcceptRan = true;
},
onRejectGesture: (int key) {
expect(key, equals(primaryKey));
secondRejectRan = true;
}
);
arena.add(primaryKey, first);
arena.add(primaryKey, second);
arena.close(primaryKey);
expect(firstAcceptRan, isFalse);
expect(firstRejectRan, isFalse);
expect(secondAcceptRan, isFalse);
expect(secondRejectRan, isFalse);
arena.sweep(primaryKey);
expect(firstAcceptRan, isTrue);
expect(firstRejectRan, isFalse);
expect(secondAcceptRan, isFalse);
expect(secondRejectRan, isTrue);
}); });
test('Should win on release after hold sweep release', () { test('Should win on release after hold sweep release', () {
GestureArena arena = new GestureArena(); GestureTester tester = new GestureTester();
tester.addFirst();
int primaryKey = 4; tester.addSecond();
bool firstAcceptRan = false; tester.arena.close(primaryKey);
bool firstRejectRan = false; tester.expectNothing();
bool secondAcceptRan = false; tester.arena.hold(primaryKey);
bool secondRejectRan = false; tester.expectNothing();
tester.arena.sweep(primaryKey);
TestGestureArenaMember first = new TestGestureArenaMember( tester.expectNothing();
onAcceptGesture: (int key) { tester.arena.release(primaryKey);
expect(key, equals(primaryKey)); tester.expectFirstWin();
firstAcceptRan = true;
},
onRejectGesture: (int key) {
expect(key, equals(primaryKey));
firstRejectRan = true;
}
);
TestGestureArenaMember second = new TestGestureArenaMember(
onAcceptGesture: (int key) {
expect(key, equals(primaryKey));
secondAcceptRan = true;
},
onRejectGesture: (int key) {
expect(key, equals(primaryKey));
secondRejectRan = true;
}
);
arena.add(primaryKey, first);
arena.add(primaryKey, second);
arena.close(primaryKey);
expect(firstAcceptRan, isFalse);
expect(firstRejectRan, isFalse);
expect(secondAcceptRan, isFalse);
expect(secondRejectRan, isFalse);
arena.hold(primaryKey);
expect(firstAcceptRan, isFalse);
expect(firstRejectRan, isFalse);
expect(secondAcceptRan, isFalse);
expect(secondRejectRan, isFalse);
arena.sweep(primaryKey);
expect(firstAcceptRan, isFalse);
expect(firstRejectRan, isFalse);
expect(secondAcceptRan, isFalse);
expect(secondRejectRan, isFalse);
arena.release(primaryKey);
expect(firstAcceptRan, isTrue);
expect(firstRejectRan, isFalse);
expect(secondAcceptRan, isFalse);
expect(secondRejectRan, isTrue);
}); });
test('Should win on sweep after hold release sweep', () { test('Should win on sweep after hold release sweep', () {
GestureArena arena = new GestureArena(); GestureTester tester = new GestureTester();
tester.addFirst();
int primaryKey = 4; tester.addSecond();
bool firstAcceptRan = false; tester.arena.close(primaryKey);
bool firstRejectRan = false; tester.expectNothing();
bool secondAcceptRan = false; tester.arena.hold(primaryKey);
bool secondRejectRan = false; tester.expectNothing();
tester.arena.release(primaryKey);
TestGestureArenaMember first = new TestGestureArenaMember( tester.expectNothing();
onAcceptGesture: (int key) { tester.arena.sweep(primaryKey);
expect(key, equals(primaryKey)); tester.expectFirstWin();
firstAcceptRan = true; });
},
onRejectGesture: (int key) { test('Only first winner should win', () {
expect(key, equals(primaryKey)); GestureTester tester = new GestureTester();
firstRejectRan = true; tester.addFirst();
} tester.addSecond();
); tester.arena.close(primaryKey);
tester.expectNothing();
TestGestureArenaMember second = new TestGestureArenaMember( tester.firstEntry.resolve(GestureDisposition.accepted);
onAcceptGesture: (int key) { tester.secondEntry.resolve(GestureDisposition.accepted);
expect(key, equals(primaryKey)); tester.expectFirstWin();
secondAcceptRan = true; });
},
onRejectGesture: (int key) { test('Only first winner should win, regardless of order', () {
expect(key, equals(primaryKey)); GestureTester tester = new GestureTester();
secondRejectRan = true; tester.addFirst();
} tester.addSecond();
); tester.arena.close(primaryKey);
tester.expectNothing();
arena.add(primaryKey, first); tester.secondEntry.resolve(GestureDisposition.accepted);
arena.add(primaryKey, second); tester.firstEntry.resolve(GestureDisposition.accepted);
arena.close(primaryKey); tester.expectSecondWin();
});
expect(firstAcceptRan, isFalse);
expect(firstRejectRan, isFalse); test('Win before close is delayed to close', () {
expect(secondAcceptRan, isFalse); GestureTester tester = new GestureTester();
expect(secondRejectRan, isFalse); tester.addFirst();
tester.addSecond();
arena.hold(primaryKey); tester.expectNothing();
tester.firstEntry.resolve(GestureDisposition.accepted);
expect(firstAcceptRan, isFalse); tester.expectNothing();
expect(firstRejectRan, isFalse); tester.arena.close(primaryKey);
expect(secondAcceptRan, isFalse); tester.expectFirstWin();
expect(secondRejectRan, isFalse); });
arena.release(primaryKey); test('Win before close is delayed to close, and only first winner should win', () {
GestureTester tester = new GestureTester();
expect(firstAcceptRan, isFalse); tester.addFirst();
expect(firstRejectRan, isFalse); tester.addSecond();
expect(secondAcceptRan, isFalse); tester.expectNothing();
expect(secondRejectRan, isFalse); tester.firstEntry.resolve(GestureDisposition.accepted);
tester.secondEntry.resolve(GestureDisposition.accepted);
arena.sweep(primaryKey); tester.expectNothing();
tester.arena.close(primaryKey);
expect(firstAcceptRan, isTrue); tester.expectFirstWin();
expect(firstRejectRan, isFalse); });
expect(secondAcceptRan, isFalse);
expect(secondRejectRan, isTrue); test('Win before close is delayed to close, and only first winner should win, regardless of order', () {
GestureTester tester = new GestureTester();
tester.addFirst();
tester.addSecond();
tester.expectNothing();
tester.secondEntry.resolve(GestureDisposition.accepted);
tester.firstEntry.resolve(GestureDisposition.accepted);
tester.expectNothing();
tester.arena.close(primaryKey);
tester.expectSecondWin();
}); });
} }
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment

HIAST - GitLab