Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
a90880a8
Unverified
Commit
a90880a8
authored
Nov 10, 2020
by
Jonah Williams
Committed by
GitHub
Nov 10, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[flutter_tools] always use dart to run test script. (#70146)
parent
900da21f
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
3 additions
and
10 deletions
+3
-10
drive_service.dart
packages/flutter_tools/lib/src/drive/drive_service.dart
+1
-8
drive_service_test.dart
...er_tools/test/general.shard/drive/drive_service_test.dart
+2
-2
No files found.
packages/flutter_tools/lib/src/drive/drive_service.dart
View file @
a90880a8
...
...
@@ -235,16 +235,9 @@ class FlutterDriverService extends DriverService {
int
driverPort
,
List
<
String
>
browserDimension
,
})
async
{
// Check if package:test is available. If not, fall back to invoking
// the test script directly. `pub run test` is strictly better because
// in the even that a socket or something similar is left open, the
// test runner will correctly shutdown the VM instead of hanging forever.
return
_processUtils
.
stream
(<
String
>[
_dartSdkPath
,
if
(
packageConfig
[
'test'
]
!=
null
)
...<
String
>[
'pub'
,
'run'
,
'test'
,
...
arguments
,
testFile
,
'-rexpanded'
]
else
...<
String
>[...
arguments
,
testFile
,
'-rexpanded'
],
...<
String
>[...
arguments
,
testFile
,
'-rexpanded'
],
],
environment:
<
String
,
String
>{
'VM_SERVICE_URL'
:
_vmServiceUri
,
...
environment
,
...
...
packages/flutter_tools/test/general.shard/drive/drive_service_test.dart
View file @
a90880a8
...
...
@@ -151,7 +151,7 @@ void main() {
]);
final
FakeProcessManager
processManager
=
FakeProcessManager
.
list
(<
FakeCommand
>[
const
FakeCommand
(
command:
<
String
>[
'dart'
,
'
pub'
,
'run'
,
'test'
,
'
--enable-experiment=non-nullable'
,
'foo.test'
,
'-rexpanded'
],
command:
<
String
>[
'dart'
,
'--enable-experiment=non-nullable'
,
'foo.test'
,
'-rexpanded'
],
exitCode:
23
,
environment:
<
String
,
String
>{
'FOO'
:
'BAR'
,
...
...
@@ -212,7 +212,7 @@ void main() {
]);
final
FakeProcessManager
processManager
=
FakeProcessManager
.
list
(<
FakeCommand
>[
const
FakeCommand
(
command:
<
String
>[
'dart'
,
'
pub'
,
'run'
,
'test'
,
'
foo.test'
,
'-rexpanded'
],
command:
<
String
>[
'dart'
,
'foo.test'
,
'-rexpanded'
],
exitCode:
11
,
environment:
<
String
,
String
>{
'VM_SERVICE_URL'
:
'http://127.0.0.1:1234/'
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment