Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
a8504405
Unverified
Commit
a8504405
authored
May 01, 2019
by
Dan Field
Committed by
GitHub
May 01, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Revert "Handle notification errors (#31868)" (#31886)
This reverts commit
c0d5fd23
.
parent
c82fc132
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
2 additions
and
29 deletions
+2
-29
driver.dart
packages/flutter_driver/lib/src/driver/driver.dart
+2
-11
vmservice.dart
packages/flutter_tools/lib/src/vmservice.dart
+0
-10
dart_vm.dart
...s/fuchsia_remote_debug_protocol/lib/src/dart/dart_vm.dart
+0
-8
No files found.
packages/flutter_driver/lib/src/driver/driver.dart
View file @
a8504405
...
...
@@ -934,18 +934,9 @@ void restoreVmServiceConnectFunction() {
}
void
_unhandledJsonRpcError
(
dynamic
error
,
dynamic
stack
)
{
if
(
error
is
rpc
.
RpcException
)
{
final
rpc
.
RpcException
rpcException
=
error
;
if
(
rpcException
.
data
!=
null
&&
rpcException
.
data
[
'id'
]
==
null
)
{
// This can happen, e.g., if a client tries to call us before methods have
// been registered, but the client doesn't care for a response.
_log
.
trace
(
'RPC client sent a notification that resulted in an error:
\n
$error
'
);
return
;
}
assert
(
false
,
'json_rpc_2 failed to send an exception back to the client.'
);
}
_log
.
trace
(
'Unhandled RPC error:
\n
$error
\n
$stack
'
);
assert
(
false
);
// TODO(dnfield): https://github.com/flutter/flutter/issues/31813
// assert(false);
}
/// Waits for a real Dart VM service to become available, then connects using
...
...
packages/flutter_tools/lib/src/vmservice.dart
View file @
a8504405
...
...
@@ -237,16 +237,6 @@ class VMService {
}
static
void
_unhandledError
(
dynamic
error
,
dynamic
stack
)
{
if
(
error
is
rpc
.
RpcException
)
{
final
rpc
.
RpcException
rpcException
=
error
;
if
(
rpcException
.
data
!=
null
&&
rpcException
.
data
[
'id'
]
==
null
)
{
// This can happen, e.g., if a client tries to call us before methods have
// been registered, but the client doesn't care for a response.
logger
.
printTrace
(
'RPC client sent a notification that resulted in an error:
\n
$error
'
);
return
;
}
assert
(
false
,
'json_rpc_2 failed to send an exception back to the client.'
);
}
logger
.
printTrace
(
'Error in internal implementation of JSON RPC.
\n
$error
\n
$stack
'
);
assert
(
false
);
}
...
...
packages/fuchsia_remote_debug_protocol/lib/src/dart/dart_vm.dart
View file @
a8504405
...
...
@@ -33,14 +33,6 @@ RpcPeerConnectionFunction fuchsiaVmServiceConnectionFunction = _waitAndConnect;
void
_unhandledJsonRpcError
(
dynamic
error
,
dynamic
stack
)
{
if
(
error
is
json_rpc
.
RpcException
)
{
final
json_rpc
.
RpcException
rpcException
=
error
;
if
(
rpcException
.
data
!=
null
&&
rpcException
.
data
[
'id'
]
==
null
)
{
// This can happen, e.g., if a client tries to call us before methods have
// been registered, but the client doesn't care for a response.
return
;
}
}
_log
.
fine
(
'Error in internalimplementation of JSON RPC.
\n
$error
\n
$stack
'
);
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment