Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
a717e151
Unverified
Commit
a717e151
authored
Apr 26, 2021
by
Michael Goderbauer
Committed by
GitHub
Apr 26, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Enable vm:notify-debugger-on-exception for more use cases enabled by upstream fix (#81221)
parent
52661bc7
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
4 additions
and
10 deletions
+4
-10
binding.dart
packages/flutter/lib/src/scheduler/binding.dart
+1
-4
framework.dart
packages/flutter/lib/src/widgets/framework.dart
+1
-4
break_on_framework_exceptions_test.dart
...integration.shard/break_on_framework_exceptions_test.dart
+2
-2
No files found.
packages/flutter/lib/src/scheduler/binding.dart
View file @
a717e151
...
...
@@ -451,10 +451,7 @@ mixin SchedulerBinding on BindingBase {
///
/// Also returns false if there are no tasks remaining.
@visibleForTesting
// TODO(goderbauer): Add pragma (and enable test in
// break_on_framework_exceptions_test.dart) once debugger breaks on correct
// line, https://github.com/dart-lang/sdk/issues/45684
// @pragma('vm:notify-debugger-on-exception')
@pragma
(
'vm:notify-debugger-on-exception'
)
bool
handleEventLoopCallback
()
{
if
(
_taskQueue
.
isEmpty
||
locked
)
return
false
;
...
...
packages/flutter/lib/src/widgets/framework.dart
View file @
a717e151
...
...
@@ -2834,10 +2834,7 @@ class BuildOwner {
///
/// After the current call stack unwinds, a microtask that notifies listeners
/// about changes to global keys will run.
// TODO(goderbauer): Add pragma (and enable test in
// break_on_framework_exceptions_test.dart) once debugger breaks on correct
// line, https://github.com/dart-lang/sdk/issues/45684
// @pragma('vm:notify-debugger-on-exception')
@pragma
(
'vm:notify-debugger-on-exception'
)
void
finalizeTree
()
{
Timeline
.
startSync
(
'Finalize tree'
,
arguments:
timelineArgumentsIndicatingLandmarkEvent
);
try
{
...
...
packages/flutter_tools/test/integration.shard/break_on_framework_exceptions_test.dart
View file @
a717e151
...
...
@@ -446,7 +446,7 @@ void main() {
final
int
breakLine
=
(
await
flutter
.
getSourceLocation
()).
line
;
expect
(
breakLine
,
project
.
lineContaining
(
project
.
test
,
"throw 'scheduled task';"
));
}
,
skip:
'TODO(goderbauer): add pragma to SchedulerBinding.handleEventLoopCallback when https://github.com/dart-lang/sdk/issues/45684 is fixed and enable this test'
);
});
testWithoutContext
(
'breaks when FrameCallback throws'
,
()
async
{
final
TestProject
project
=
TestProject
(
...
...
@@ -665,7 +665,7 @@ void main() {
final
int
breakLine
=
(
await
flutter
.
getSourceLocation
()).
line
;
expect
(
breakLine
,
project
.
lineContaining
(
project
.
test
,
"throw 'dispose';"
));
}
,
skip:
'TODO(goderbauer): add pragma to BuildOwner.finalizeTree when https://github.com/dart-lang/sdk/issues/45684 is fixed and enable this test'
);
});
testWithoutContext
(
'breaks when rebuilding dirty elements throws'
,
()
async
{
final
TestProject
project
=
TestProject
(
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment