Unverified Commit a717e151 authored by Michael Goderbauer's avatar Michael Goderbauer Committed by GitHub

Enable vm:notify-debugger-on-exception for more use cases enabled by upstream fix (#81221)

parent 52661bc7
......@@ -451,10 +451,7 @@ mixin SchedulerBinding on BindingBase {
///
/// Also returns false if there are no tasks remaining.
@visibleForTesting
// TODO(goderbauer): Add pragma (and enable test in
// break_on_framework_exceptions_test.dart) once debugger breaks on correct
// line, https://github.com/dart-lang/sdk/issues/45684
// @pragma('vm:notify-debugger-on-exception')
@pragma('vm:notify-debugger-on-exception')
bool handleEventLoopCallback() {
if (_taskQueue.isEmpty || locked)
return false;
......
......@@ -2834,10 +2834,7 @@ class BuildOwner {
///
/// After the current call stack unwinds, a microtask that notifies listeners
/// about changes to global keys will run.
// TODO(goderbauer): Add pragma (and enable test in
// break_on_framework_exceptions_test.dart) once debugger breaks on correct
// line, https://github.com/dart-lang/sdk/issues/45684
// @pragma('vm:notify-debugger-on-exception')
@pragma('vm:notify-debugger-on-exception')
void finalizeTree() {
Timeline.startSync('Finalize tree', arguments: timelineArgumentsIndicatingLandmarkEvent);
try {
......
......@@ -446,7 +446,7 @@ void main() {
final int breakLine = (await flutter.getSourceLocation()).line;
expect(breakLine, project.lineContaining(project.test, "throw 'scheduled task';"));
}, skip: 'TODO(goderbauer): add pragma to SchedulerBinding.handleEventLoopCallback when https://github.com/dart-lang/sdk/issues/45684 is fixed and enable this test');
});
testWithoutContext('breaks when FrameCallback throws', () async {
final TestProject project = TestProject(
......@@ -665,7 +665,7 @@ void main() {
final int breakLine = (await flutter.getSourceLocation()).line;
expect(breakLine, project.lineContaining(project.test, "throw 'dispose';"));
}, skip: 'TODO(goderbauer): add pragma to BuildOwner.finalizeTree when https://github.com/dart-lang/sdk/issues/45684 is fixed and enable this test');
});
testWithoutContext('breaks when rebuilding dirty elements throws', () async {
final TestProject project = TestProject(
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment