Unverified Commit a48185a6 authored by Alexander Aprelev's avatar Alexander Aprelev Committed by GitHub

When targeting iOS sim in preview-dart-2, always compile. (#14059)

Fixes https://github.com/flutter/flutter/issues/14058.
parent e2e3c5df
...@@ -69,7 +69,7 @@ Future<Null> build({ ...@@ -69,7 +69,7 @@ Future<Null> build({
} }
DevFSContent kernelContent; DevFSContent kernelContent;
if (previewDart2) { if (!precompiledSnapshot && previewDart2) {
final String kernelBinaryFilename = await compile( final String kernelBinaryFilename = await compile(
sdkRoot: artifacts.getArtifactPath(Artifact.flutterPatchedSdkPath), sdkRoot: artifacts.getArtifactPath(Artifact.flutterPatchedSdkPath),
incrementalCompilerByteStorePath: fs.path.absolute(getIncrementalCompilerByteStoreDirectory()), incrementalCompilerByteStorePath: fs.path.absolute(getIncrementalCompilerByteStoreDirectory()),
......
...@@ -413,7 +413,11 @@ class IOSSimulator extends Device { ...@@ -413,7 +413,11 @@ class IOSSimulator extends Device {
} }
Future<Null> _sideloadUpdatedAssetsForInstalledApplicationBundle(ApplicationPackage app, BuildInfo buildInfo) => Future<Null> _sideloadUpdatedAssetsForInstalledApplicationBundle(ApplicationPackage app, BuildInfo buildInfo) =>
flx.build(precompiledSnapshot: true, previewDart2: buildInfo.previewDart2, strongMode: buildInfo.strongMode); // When running in previewDart2 mode, we still need to run compiler to
// produce kernel file for the application.
flx.build(precompiledSnapshot: !buildInfo.previewDart2,
previewDart2: buildInfo.previewDart2,
strongMode: buildInfo.strongMode);
@override @override
Future<bool> stopApp(ApplicationPackage app) async { Future<bool> stopApp(ApplicationPackage app) async {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment