Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
a3e66b39
Unverified
Commit
a3e66b39
authored
Apr 08, 2021
by
Jonah Williams
Committed by
GitHub
Apr 08, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[flutter_tools] handle out of date xcode config in assemble (#79983)
parent
db51c6d5
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
31 additions
and
1 deletion
+31
-1
assemble.dart
packages/flutter_tools/lib/src/commands/assemble.dart
+9
-1
assemble_test.dart
...ter_tools/test/commands.shard/hermetic/assemble_test.dart
+22
-0
No files found.
packages/flutter_tools/lib/src/commands/assemble.dart
View file @
a3e66b39
...
...
@@ -291,7 +291,15 @@ class AssembleCommand extends FlutterCommand {
}
}
Target
target
;
final
List
<
String
>
decodedDefines
=
decodeDartDefines
(
environment
.
defines
,
kDartDefines
);
List
<
String
>
decodedDefines
;
try
{
decodedDefines
=
decodeDartDefines
(
environment
.
defines
,
kDartDefines
);
}
on
FormatException
{
throwToolExit
(
'Error parsing assemble command: your generated configuration may be out of date. '
"Try re-running 'flutter build ios' or the appropriate build command."
);
}
if
(
FlutterProject
.
current
().
manifest
.
deferredComponents
!=
null
&&
decodedDefines
.
contains
(
'validate-deferred-components=true'
)
&&
deferredTargets
.
isNotEmpty
...
...
packages/flutter_tools/test/commands.shard/hermetic/assemble_test.dart
View file @
a3e66b39
...
...
@@ -99,6 +99,28 @@ void main() {
ProcessManager:
()
=>
FakeProcessManager
.
any
(),
});
testUsingContext
(
'flutter assemble throws ToolExit if dart-defines are not base64 encoded'
,
()
async
{
final
CommandRunner
<
void
>
commandRunner
=
createTestCommandRunner
(
AssembleCommand
(
buildSystem:
TestBuildSystem
.
all
(
BuildResult
(
success:
true
)),
));
final
List
<
String
>
command
=
<
String
>[
'assemble'
,
'--output'
,
'Output'
,
'--DartDefines=flutter.inspector.structuredErrors%3Dtrue'
,
'debug_macos_bundle_flutter_assets'
,
];
expect
(
commandRunner
.
run
(
command
),
throwsToolExit
(
message:
'Error parsing assemble command: your generated configuration may be out of date'
)
);
},
overrides:
<
Type
,
Generator
>{
Cache:
()
=>
Cache
.
test
(
processManager:
FakeProcessManager
.
any
()),
FileSystem:
()
=>
MemoryFileSystem
.
test
(),
ProcessManager:
()
=>
FakeProcessManager
.
any
(),
});
testUsingContext
(
'flutter assemble throws ToolExit if called with non-existent rule'
,
()
async
{
final
CommandRunner
<
void
>
commandRunner
=
createTestCommandRunner
(
AssembleCommand
(
buildSystem:
TestBuildSystem
.
all
(
BuildResult
(
success:
true
)),
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment