Unverified Commit a36f809e authored by Alexandre Ardhuin's avatar Alexandre Ardhuin Committed by GitHub

add missing trailing commas (in dev/) (#40704)

parent 0573709f
...@@ -13,7 +13,7 @@ void main() { ...@@ -13,7 +13,7 @@ void main() {
width: 54, width: 54,
height: 54, height: 54,
fit: BoxFit.none, fit: BoxFit.none,
package: 'flutter_automated_tests' package: 'flutter_automated_tests',
), ),
); );
}); });
......
...@@ -12,7 +12,7 @@ void main() { ...@@ -12,7 +12,7 @@ void main() {
CustomScrollView( CustomScrollView(
slivers: <Widget>[ slivers: <Widget>[
SliverToBoxAdapter(child: Container()), SliverToBoxAdapter(child: Container()),
] ],
) )
); );
}); });
......
...@@ -12,7 +12,7 @@ void main() { ...@@ -12,7 +12,7 @@ void main() {
CustomScrollView( CustomScrollView(
slivers: <Widget>[ slivers: <Widget>[
SliverToBoxAdapter(child: Container()), SliverToBoxAdapter(child: Container()),
] ],
) )
); );
}); });
......
...@@ -228,7 +228,7 @@ Future<void> _runToolCoverage() async { ...@@ -228,7 +228,7 @@ Future<void> _runToolCoverage() async {
environment: <String, String>{ environment: <String, String>{
'FLUTTER_ROOT': flutterRoot, 'FLUTTER_ROOT': flutterRoot,
'SUBSHARD': subshards[i], 'SUBSHARD': subshards[i],
} },
); );
} }
} }
...@@ -299,7 +299,7 @@ Future<void> _flutterBuildDart2js(String relativePathToApplication, String targe ...@@ -299,7 +299,7 @@ Future<void> _flutterBuildDart2js(String relativePathToApplication, String targe
expectNonZeroExit: expectNonZeroExit, expectNonZeroExit: expectNonZeroExit,
environment: <String, String>{ environment: <String, String>{
'FLUTTER_WEB': 'true', 'FLUTTER_WEB': 'true',
} },
); );
print('Done.'); print('Done.');
} }
...@@ -554,7 +554,7 @@ Future<void> _buildRunnerTest( ...@@ -554,7 +554,7 @@ Future<void> _buildRunnerTest(
args, args,
workingDirectory: workingDirectory, workingDirectory: workingDirectory,
environment: pubEnvironment, environment: pubEnvironment,
beforeExit: formatter.finish beforeExit: formatter.finish,
); );
await _processTestOutput(formatter, testOutput, tableData); await _processTestOutput(formatter, testOutput, tableData);
} else { } else {
...@@ -563,7 +563,7 @@ Future<void> _buildRunnerTest( ...@@ -563,7 +563,7 @@ Future<void> _buildRunnerTest(
args, args,
workingDirectory:workingDirectory, workingDirectory:workingDirectory,
environment:pubEnvironment, environment:pubEnvironment,
removeLine: (String line) => line.contains('[INFO]') removeLine: (String line) => line.contains('[INFO]'),
); );
} }
} }
......
...@@ -130,7 +130,7 @@ Future<void> main() async { ...@@ -130,7 +130,7 @@ Future<void> main() async {
// for arm and arm64. // for arm and arm64.
final List<String> targetPlatforms = <String>[ final List<String> targetPlatforms = <String>[
'android-arm', 'android-arm',
'android-arm64' 'android-arm64',
]; ];
for (final String targetPlatform in targetPlatforms) { for (final String targetPlatform in targetPlatforms) {
final String androidArmSnapshotPath = path.join( final String androidArmSnapshotPath = path.join(
......
...@@ -263,7 +263,7 @@ Future<void> main() async { ...@@ -263,7 +263,7 @@ Future<void> main() async {
], ],
environment: <String, String> { environment: <String, String> {
'FLUTTER_ANALYTICS_LOG_FILE': objectiveCAnalyticsOutputFile.path, 'FLUTTER_ANALYTICS_LOG_FILE': objectiveCAnalyticsOutputFile.path,
} },
); );
}); });
...@@ -306,7 +306,7 @@ Future<void> main() async { ...@@ -306,7 +306,7 @@ Future<void> main() async {
'CONFIGURATION_BUILD_DIR=${objectiveCBuildDirectory.path}', 'CONFIGURATION_BUILD_DIR=${objectiveCBuildDirectory.path}',
'COMPILER_INDEX_STORE_ENABLE=NO', 'COMPILER_INDEX_STORE_ENABLE=NO',
], ],
canFail: true canFail: true,
); );
}); });
...@@ -346,7 +346,7 @@ Future<void> main() async { ...@@ -346,7 +346,7 @@ Future<void> main() async {
], ],
environment: <String, String> { environment: <String, String> {
'FLUTTER_ANALYTICS_LOG_FILE': swiftAnalyticsOutputFile.path, 'FLUTTER_ANALYTICS_LOG_FILE': swiftAnalyticsOutputFile.path,
} },
); );
}); });
...@@ -383,7 +383,7 @@ Future<bool> _isAppAotBuild(Directory app) async { ...@@ -383,7 +383,7 @@ Future<bool> _isAppAotBuild(Directory app) async {
app.path, app.path,
'Frameworks', 'Frameworks',
'App.framework', 'App.framework',
'App' 'App',
); );
final String symbolTable = await eval( final String symbolTable = await eval(
...@@ -402,7 +402,7 @@ Future<bool> _hasDebugSymbols(Directory app) async { ...@@ -402,7 +402,7 @@ Future<bool> _hasDebugSymbols(Directory app) async {
app.path, app.path,
'Frameworks', 'Frameworks',
'App.framework', 'App.framework',
'App' 'App',
); );
final String symbolTable = await eval( final String symbolTable = await eval(
......
...@@ -44,7 +44,7 @@ Future<void> checkNoWarningHostLaunch(String deviceId) async { ...@@ -44,7 +44,7 @@ Future<void> checkNoWarningHostLaunch(String deviceId) async {
'--verbose-system-logs', '--verbose-system-logs',
'-d', '-d',
deviceId, deviceId,
'lib/empty.dart' 'lib/empty.dart',
]); ]);
expect(!output.contains(expectedWarning)); expect(!output.contains(expectedWarning));
...@@ -84,9 +84,9 @@ Future<void> checkWarningHomeScreenLaunch(String deviceId) async { ...@@ -84,9 +84,9 @@ Future<void> checkWarningHomeScreenLaunch(String deviceId) async {
'--verbose-system-logs', '--verbose-system-logs',
'-d', '-d',
deviceId, deviceId,
'lib/empty.dart' 'lib/empty.dart',
], environment: <String, String>{ ], environment: <String, String>{
'FLUTTER_TOOLS_DEBUG_WITHOUT_CHECKED_MODE': 'true' 'FLUTTER_TOOLS_DEBUG_WITHOUT_CHECKED_MODE': 'true',
}); });
expect(output.contains(expectedWarning)); expect(output.contains(expectedWarning));
} }
\ No newline at end of file
...@@ -689,7 +689,7 @@ class ReportedDurationTest { ...@@ -689,7 +689,7 @@ class ReportedDurationTest {
_device = null; _device = null;
final Map<String, dynamic> reportedDuration = <String, dynamic>{ final Map<String, dynamic> reportedDuration = <String, dynamic>{
'duration': duration 'duration': duration,
}; };
_device = null; _device = null;
......
...@@ -105,7 +105,7 @@ class _FlutterProject { ...@@ -105,7 +105,7 @@ class _FlutterProject {
'--org', '--org',
'io.flutter.devicelab', 'io.flutter.devicelab',
...options, ...options,
name name,
], ],
); );
}); });
......
...@@ -38,7 +38,7 @@ void createTestChannelBetweenAndroidAndFlutter() { ...@@ -38,7 +38,7 @@ void createTestChannelBetweenAndroidAndFlutter() {
// Channel used for Android to send Flutter changes to the splash display. // Channel used for Android to send Flutter changes to the splash display.
const BasicMessageChannel<String> testChannel = BasicMessageChannel<String>( const BasicMessageChannel<String> testChannel = BasicMessageChannel<String>(
'testChannel', 'testChannel',
StringCodec() StringCodec(),
); );
// Every splash display change message that we receive from Android is either // Every splash display change message that we receive from Android is either
......
...@@ -18,32 +18,32 @@ void main(List<String> args) { ...@@ -18,32 +18,32 @@ void main(List<String> args) {
'help', 'help',
abbr: 'h', abbr: 'h',
negatable: false, negatable: false,
help: 'Display the tool\'s usage instructions and quit.' help: 'Display the tool\'s usage instructions and quit.',
); );
parser.addOption( parser.addOption(
'output', 'output',
abbr: 'o', abbr: 'o',
help: 'Target path to write the generated Dart file to.' help: 'Target path to write the generated Dart file to.',
); );
parser.addOption( parser.addOption(
'asset-name', 'asset-name',
abbr: 'n', abbr: 'n',
help: 'Name to be used for the generated constant.' help: 'Name to be used for the generated constant.',
); );
parser.addOption( parser.addOption(
'part-of', 'part-of',
abbr: 'p', abbr: 'p',
help: 'Library name to add a dart \'part of\' clause for.' help: 'Library name to add a dart \'part of\' clause for.',
); );
parser.addOption( parser.addOption(
'header', 'header',
abbr: 'd', abbr: 'd',
help: 'File whose contents are to be prepended to the beginning of ' help: 'File whose contents are to be prepended to the beginning of '
'the generated Dart file; this can be used for a license comment.' 'the generated Dart file; this can be used for a license comment.',
); );
parser.addFlag( parser.addFlag(
...@@ -51,7 +51,7 @@ void main(List<String> args) { ...@@ -51,7 +51,7 @@ void main(List<String> args) {
abbr: 'c', abbr: 'c',
defaultsTo: true, defaultsTo: true,
help: 'Whether to include the following comment after the header:\n' help: 'Whether to include the following comment after the header:\n'
'$kCodegenComment' '$kCodegenComment',
); );
final ArgResults argResults = parser.parse(args); final ArgResults argResults = parser.parse(args);
......
...@@ -22,19 +22,19 @@ void main() { ...@@ -22,19 +22,19 @@ void main() {
test('parsePoints', () { test('parsePoints', () {
expect(parsePoints('1.0, 2.0'), expect(parsePoints('1.0, 2.0'),
const <Point<double>>[Point<double>(1.0, 2.0)] const <Point<double>>[Point<double>(1.0, 2.0)],
); );
expect(parsePoints('12.0, 34.0 5.0, 6.6'), expect(parsePoints('12.0, 34.0 5.0, 6.6'),
const <Point<double>>[ const <Point<double>>[
Point<double>(12.0, 34.0), Point<double>(12.0, 34.0),
Point<double>(5.0, 6.6), Point<double>(5.0, 6.6),
] ],
); );
expect(parsePoints('12.0 34.0 5.0 6.6'), expect(parsePoints('12.0 34.0 5.0 6.6'),
const <Point<double>>[ const <Point<double>>[
Point<double>(12.0, 34.0), Point<double>(12.0, 34.0),
Point<double>(5.0, 6.6), Point<double>(5.0, 6.6),
] ],
); );
}); });
...@@ -47,19 +47,19 @@ void main() { ...@@ -47,19 +47,19 @@ void main() {
test('illegal SVGs', () { test('illegal SVGs', () {
expect( expect(
() { interpretSvg(testAsset('illegal_svg_multiple_roots.svg')); }, () { interpretSvg(testAsset('illegal_svg_multiple_roots.svg')); },
throwsA(anything) throwsA(anything),
); );
}); });
test('SVG size', () { test('SVG size', () {
expect( expect(
interpretSvg(testAsset('empty_svg_1_48x48.svg')).size, interpretSvg(testAsset('empty_svg_1_48x48.svg')).size,
const Point<double>(48.0, 48.0) const Point<double>(48.0, 48.0),
); );
expect( expect(
interpretSvg(testAsset('empty_svg_2_100x50.svg')).size, interpretSvg(testAsset('empty_svg_2_100x50.svg')).size,
const Point<double>(100.0, 50.0) const Point<double>(100.0, 50.0),
); );
}); });
...@@ -83,7 +83,7 @@ void main() { ...@@ -83,7 +83,7 @@ void main() {
test('SVG illegal path', () { test('SVG illegal path', () {
expect( expect(
() { interpretSvg(testAsset('illegal_path.svg')); }, () { interpretSvg(testAsset('illegal_path.svg')); },
throwsA(anything) throwsA(anything),
); );
}); });
...@@ -148,14 +148,14 @@ void main() { ...@@ -148,14 +148,14 @@ void main() {
SvgPathCommand('Z', <Point<double>>[]), SvgPathCommand('Z', <Point<double>>[]),
]), ]),
margin: precisionErrorTolerance, margin: precisionErrorTolerance,
) ),
]); ]);
}); });
test('SVG illegal transform', () { test('SVG illegal transform', () {
expect( expect(
() { interpretSvg(testAsset('illegal_transform.svg')); }, () { interpretSvg(testAsset('illegal_transform.svg')); },
throwsA(anything) throwsA(anything),
); );
}); });
...@@ -235,8 +235,8 @@ void main() { ...@@ -235,8 +235,8 @@ void main() {
<Point<double>>[Point<double>(10.0, 10.0)], <Point<double>>[Point<double>(10.0, 10.0)],
]), ]),
], ],
opacities: <double>[1.0] opacities: <double>[1.0],
)) )),
); );
}); });
...@@ -265,10 +265,10 @@ void main() { ...@@ -265,10 +265,10 @@ void main() {
<PathCommandAnimation>[ <PathCommandAnimation>[
PathCommandAnimation('M', <List<Point<double>>>[ PathCommandAnimation('M', <List<Point<double>>>[
<Point<double>>[Point<double>(0.0, 0.0)], <Point<double>>[Point<double>(0.0, 0.0)],
]) ]),
], ],
opacities: <double>[1.0] opacities: <double>[1.0],
)) )),
); );
expect(PathAnimation.fromFrameData(frameData, 1), expect(PathAnimation.fromFrameData(frameData, 1),
...@@ -278,8 +278,8 @@ void main() { ...@@ -278,8 +278,8 @@ void main() {
<Point<double>>[Point<double>(5.0, 6.0)], <Point<double>>[Point<double>(5.0, 6.0)],
]) ])
], ],
opacities: <double>[1.0] opacities: <double>[1.0],
)) )),
); );
}); });
...@@ -291,7 +291,7 @@ void main() { ...@@ -291,7 +291,7 @@ void main() {
SvgPath( SvgPath(
'path_1', 'path_1',
<SvgPathCommand>[ <SvgPathCommand>[
SvgPathCommand('M', <Point<double>>[Point<double>(0.0, 0.0)]) SvgPathCommand('M', <Point<double>>[Point<double>(0.0, 0.0)]),
], ],
opacity: 0.5, opacity: 0.5,
), ),
...@@ -303,7 +303,7 @@ void main() { ...@@ -303,7 +303,7 @@ void main() {
SvgPath( SvgPath(
'path_1', 'path_1',
<SvgPathCommand>[ <SvgPathCommand>[
SvgPathCommand('M', <Point<double>>[Point<double>(10.0, 10.0)]) SvgPathCommand('M', <Point<double>>[Point<double>(10.0, 10.0)]),
], ],
), ),
], ],
...@@ -319,8 +319,8 @@ void main() { ...@@ -319,8 +319,8 @@ void main() {
], ],
]), ]),
], ],
opacities: <double>[0.5, 1.0] opacities: <double>[0.5, 1.0],
)) )),
); );
}); });
}); });
...@@ -352,10 +352,10 @@ void main() { ...@@ -352,10 +352,10 @@ void main() {
<PathCommandAnimation>[ <PathCommandAnimation>[
PathCommandAnimation('M', <List<Point<double>>>[ PathCommandAnimation('M', <List<Point<double>>>[
<Point<double>>[Point<double>(0.0, 0.0)], <Point<double>>[Point<double>(0.0, 0.0)],
]) ]),
], ],
opacities: <double>[1.0] opacities: <double>[1.0],
)) )),
); );
expect(animation.paths[1], expect(animation.paths[1],
...@@ -363,10 +363,10 @@ void main() { ...@@ -363,10 +363,10 @@ void main() {
<PathCommandAnimation>[ <PathCommandAnimation>[
PathCommandAnimation('M', <List<Point<double>>>[ PathCommandAnimation('M', <List<Point<double>>>[
<Point<double>>[Point<double>(5.0, 6.0)], <Point<double>>[Point<double>(5.0, 6.0)],
]) ]),
], ],
opacities: <double>[1.0] opacities: <double>[1.0],
)) )),
); );
expect(animation.size, const Point<double>(10.0, 10.0)); expect(animation.size, const Point<double>(10.0, 10.0));
...@@ -391,7 +391,7 @@ void main() { ...@@ -391,7 +391,7 @@ void main() {
' const Offset(1.0, 2.0),\n' ' const Offset(1.0, 2.0),\n'
' const Offset(3.0, 4.0),\n' ' const Offset(3.0, 4.0),\n'
' ],\n' ' ],\n'
' ),\n' ' ),\n',
); );
}); });
...@@ -413,7 +413,7 @@ void main() { ...@@ -413,7 +413,7 @@ void main() {
' const Offset(1.0, 2.0),\n' ' const Offset(1.0, 2.0),\n'
' const Offset(3.0, 4.0),\n' ' const Offset(3.0, 4.0),\n'
' ],\n' ' ],\n'
' ),\n' ' ),\n',
); );
}); });
...@@ -451,7 +451,7 @@ void main() { ...@@ -451,7 +451,7 @@ void main() {
' const Offset(40.0, 40.0),\n' ' const Offset(40.0, 40.0),\n'
' const Offset(40.0, 40.0),\n' ' const Offset(40.0, 40.0),\n'
' ],\n' ' ],\n'
' ),\n' ' ),\n',
); );
}); });
...@@ -464,7 +464,7 @@ void main() { ...@@ -464,7 +464,7 @@ void main() {
expect(command.toDart(), expect(command.toDart(),
' const _PathClose(\n' ' const _PathClose(\n'
' ),\n' ' ),\n',
); );
}); });
...@@ -477,7 +477,7 @@ void main() { ...@@ -477,7 +477,7 @@ void main() {
expect( expect(
() { command.toDart(); }, () { command.toDart(); },
throwsA(anything) throwsA(anything),
); );
}); });
...@@ -497,7 +497,7 @@ void main() { ...@@ -497,7 +497,7 @@ void main() {
], ],
]), ]),
], ],
opacities: <double>[0.5, 1.0] opacities: <double>[0.5, 1.0],
); );
expect(pathAnimation.toDart(), expect(pathAnimation.toDart(),
...@@ -520,7 +520,7 @@ void main() { ...@@ -520,7 +520,7 @@ void main() {
' ],\n' ' ],\n'
' ),\n' ' ),\n'
' ],\n' ' ],\n'
' ),\n' ' ),\n',
); );
}); });
...@@ -543,7 +543,7 @@ void main() { ...@@ -543,7 +543,7 @@ void main() {
], ],
]), ]),
], ],
opacities: <double>[0.5, 1.0] opacities: <double>[0.5, 1.0],
), ),
PathAnimation( PathAnimation(
...@@ -555,7 +555,7 @@ void main() { ...@@ -555,7 +555,7 @@ void main() {
], ],
]), ]),
], ],
opacities: <double>[0.5, 1.0] opacities: <double>[0.5, 1.0],
), ),
]); ]);
...@@ -598,7 +598,7 @@ void main() { ...@@ -598,7 +598,7 @@ void main() {
' ],\n' ' ],\n'
' ),\n' ' ),\n'
' ],\n' ' ],\n'
');' ');',
); );
}); });
}); });
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment