Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
a36f809e
Unverified
Commit
a36f809e
authored
Sep 19, 2019
by
Alexandre Ardhuin
Committed by
GitHub
Sep 19, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
add missing trailing commas (in dev/) (#40704)
parent
0573709f
Changes
12
Hide whitespace changes
Inline
Side-by-side
Showing
12 changed files
with
61 additions
and
61 deletions
+61
-61
package_assets_test.dart
dev/automated_tests/flutter_test/package_assets_test.dart
+1
-1
print_user_created_ancestor_no_flag_test.dart
...lutter_test/print_user_created_ancestor_no_flag_test.dart
+1
-1
print_user_created_ancestor_test.dart
..._tests/flutter_test/print_user_created_ancestor_test.dart
+1
-1
test.dart
dev/bots/test.dart
+4
-4
gradle_plugin_fat_apk_test.dart
dev/devicelab/bin/tasks/gradle_plugin_fat_apk_test.dart
+1
-1
module_test_ios.dart
dev/devicelab/bin/tasks/module_test_ios.dart
+5
-5
system_debug_ios.dart
dev/devicelab/bin/tasks/system_debug_ios.dart
+3
-3
perf_tests.dart
dev/devicelab/lib/tasks/perf_tests.dart
+1
-1
plugin_tests.dart
dev/devicelab/lib/tasks/plugin_tests.dart
+1
-1
main.dart
..._screens/splash_screen_kitchen_sink/test_driver/main.dart
+1
-1
main.dart
dev/tools/vitool/bin/main.dart
+6
-6
vitool_test.dart
dev/tools/vitool/test/vitool_test.dart
+36
-36
No files found.
dev/automated_tests/flutter_test/package_assets_test.dart
View file @
a36f809e
...
...
@@ -13,7 +13,7 @@ void main() {
width:
54
,
height:
54
,
fit:
BoxFit
.
none
,
package:
'flutter_automated_tests'
package:
'flutter_automated_tests'
,
),
);
});
...
...
dev/automated_tests/flutter_test/print_user_created_ancestor_no_flag_test.dart
View file @
a36f809e
...
...
@@ -12,7 +12,7 @@ void main() {
CustomScrollView
(
slivers:
<
Widget
>[
SliverToBoxAdapter
(
child:
Container
()),
]
]
,
)
);
});
...
...
dev/automated_tests/flutter_test/print_user_created_ancestor_test.dart
View file @
a36f809e
...
...
@@ -12,7 +12,7 @@ void main() {
CustomScrollView
(
slivers:
<
Widget
>[
SliverToBoxAdapter
(
child:
Container
()),
]
]
,
)
);
});
...
...
dev/bots/test.dart
View file @
a36f809e
...
...
@@ -228,7 +228,7 @@ Future<void> _runToolCoverage() async {
environment:
<
String
,
String
>{
'FLUTTER_ROOT'
:
flutterRoot
,
'SUBSHARD'
:
subshards
[
i
],
}
}
,
);
}
}
...
...
@@ -299,7 +299,7 @@ Future<void> _flutterBuildDart2js(String relativePathToApplication, String targe
expectNonZeroExit:
expectNonZeroExit
,
environment:
<
String
,
String
>{
'FLUTTER_WEB'
:
'true'
,
}
}
,
);
print
(
'Done.'
);
}
...
...
@@ -554,7 +554,7 @@ Future<void> _buildRunnerTest(
args
,
workingDirectory:
workingDirectory
,
environment:
pubEnvironment
,
beforeExit:
formatter
.
finish
beforeExit:
formatter
.
finish
,
);
await
_processTestOutput
(
formatter
,
testOutput
,
tableData
);
}
else
{
...
...
@@ -563,7 +563,7 @@ Future<void> _buildRunnerTest(
args
,
workingDirectory:
workingDirectory
,
environment:
pubEnvironment
,
removeLine:
(
String
line
)
=>
line
.
contains
(
'[INFO]'
)
removeLine:
(
String
line
)
=>
line
.
contains
(
'[INFO]'
)
,
);
}
}
...
...
dev/devicelab/bin/tasks/gradle_plugin_fat_apk_test.dart
View file @
a36f809e
...
...
@@ -130,7 +130,7 @@ Future<void> main() async {
// for arm and arm64.
final
List
<
String
>
targetPlatforms
=
<
String
>[
'android-arm'
,
'android-arm64'
'android-arm64'
,
];
for
(
final
String
targetPlatform
in
targetPlatforms
)
{
final
String
androidArmSnapshotPath
=
path
.
join
(
...
...
dev/devicelab/bin/tasks/module_test_ios.dart
View file @
a36f809e
...
...
@@ -263,7 +263,7 @@ Future<void> main() async {
],
environment:
<
String
,
String
>
{
'FLUTTER_ANALYTICS_LOG_FILE'
:
objectiveCAnalyticsOutputFile
.
path
,
}
}
,
);
});
...
...
@@ -306,7 +306,7 @@ Future<void> main() async {
'CONFIGURATION_BUILD_DIR=
${objectiveCBuildDirectory.path}
'
,
'COMPILER_INDEX_STORE_ENABLE=NO'
,
],
canFail:
true
canFail:
true
,
);
});
...
...
@@ -346,7 +346,7 @@ Future<void> main() async {
],
environment:
<
String
,
String
>
{
'FLUTTER_ANALYTICS_LOG_FILE'
:
swiftAnalyticsOutputFile
.
path
,
}
}
,
);
});
...
...
@@ -383,7 +383,7 @@ Future<bool> _isAppAotBuild(Directory app) async {
app
.
path
,
'Frameworks'
,
'App.framework'
,
'App'
'App'
,
);
final
String
symbolTable
=
await
eval
(
...
...
@@ -402,7 +402,7 @@ Future<bool> _hasDebugSymbols(Directory app) async {
app
.
path
,
'Frameworks'
,
'App.framework'
,
'App'
'App'
,
);
final
String
symbolTable
=
await
eval
(
...
...
dev/devicelab/bin/tasks/system_debug_ios.dart
View file @
a36f809e
...
...
@@ -44,7 +44,7 @@ Future<void> checkNoWarningHostLaunch(String deviceId) async {
'--verbose-system-logs'
,
'-d'
,
deviceId
,
'lib/empty.dart'
'lib/empty.dart'
,
]);
expect
(!
output
.
contains
(
expectedWarning
));
...
...
@@ -84,9 +84,9 @@ Future<void> checkWarningHomeScreenLaunch(String deviceId) async {
'--verbose-system-logs'
,
'-d'
,
deviceId
,
'lib/empty.dart'
'lib/empty.dart'
,
],
environment:
<
String
,
String
>{
'FLUTTER_TOOLS_DEBUG_WITHOUT_CHECKED_MODE'
:
'true'
'FLUTTER_TOOLS_DEBUG_WITHOUT_CHECKED_MODE'
:
'true'
,
});
expect
(
output
.
contains
(
expectedWarning
));
}
\ No newline at end of file
dev/devicelab/lib/tasks/perf_tests.dart
View file @
a36f809e
...
...
@@ -689,7 +689,7 @@ class ReportedDurationTest {
_device
=
null
;
final
Map
<
String
,
dynamic
>
reportedDuration
=
<
String
,
dynamic
>{
'duration'
:
duration
'duration'
:
duration
,
};
_device
=
null
;
...
...
dev/devicelab/lib/tasks/plugin_tests.dart
View file @
a36f809e
...
...
@@ -105,7 +105,7 @@ class _FlutterProject {
'--org'
,
'io.flutter.devicelab'
,
...
options
,
name
name
,
],
);
});
...
...
dev/integration_tests/android_splash_screens/splash_screen_kitchen_sink/test_driver/main.dart
View file @
a36f809e
...
...
@@ -38,7 +38,7 @@ void createTestChannelBetweenAndroidAndFlutter() {
// Channel used for Android to send Flutter changes to the splash display.
const
BasicMessageChannel
<
String
>
testChannel
=
BasicMessageChannel
<
String
>(
'testChannel'
,
StringCodec
()
StringCodec
()
,
);
// Every splash display change message that we receive from Android is either
...
...
dev/tools/vitool/bin/main.dart
View file @
a36f809e
...
...
@@ -18,32 +18,32 @@ void main(List<String> args) {
'help'
,
abbr:
'h'
,
negatable:
false
,
help:
'Display the tool
\'
s usage instructions and quit.'
help:
'Display the tool
\'
s usage instructions and quit.'
,
);
parser
.
addOption
(
'output'
,
abbr:
'o'
,
help:
'Target path to write the generated Dart file to.'
help:
'Target path to write the generated Dart file to.'
,
);
parser
.
addOption
(
'asset-name'
,
abbr:
'n'
,
help:
'Name to be used for the generated constant.'
help:
'Name to be used for the generated constant.'
,
);
parser
.
addOption
(
'part-of'
,
abbr:
'p'
,
help:
'Library name to add a dart
\'
part of
\'
clause for.'
help:
'Library name to add a dart
\'
part of
\'
clause for.'
,
);
parser
.
addOption
(
'header'
,
abbr:
'd'
,
help:
'File whose contents are to be prepended to the beginning of '
'the generated Dart file; this can be used for a license comment.'
'the generated Dart file; this can be used for a license comment.'
,
);
parser
.
addFlag
(
...
...
@@ -51,7 +51,7 @@ void main(List<String> args) {
abbr:
'c'
,
defaultsTo:
true
,
help:
'Whether to include the following comment after the header:
\n
'
'
$kCodegenComment
'
'
$kCodegenComment
'
,
);
final
ArgResults
argResults
=
parser
.
parse
(
args
);
...
...
dev/tools/vitool/test/vitool_test.dart
View file @
a36f809e
...
...
@@ -22,19 +22,19 @@ void main() {
test
(
'parsePoints'
,
()
{
expect
(
parsePoints
(
'1.0, 2.0'
),
const
<
Point
<
double
>>[
Point
<
double
>(
1.0
,
2.0
)]
const
<
Point
<
double
>>[
Point
<
double
>(
1.0
,
2.0
)]
,
);
expect
(
parsePoints
(
'12.0, 34.0 5.0, 6.6'
),
const
<
Point
<
double
>>[
Point
<
double
>(
12.0
,
34.0
),
Point
<
double
>(
5.0
,
6.6
),
]
]
,
);
expect
(
parsePoints
(
'12.0 34.0 5.0 6.6'
),
const
<
Point
<
double
>>[
Point
<
double
>(
12.0
,
34.0
),
Point
<
double
>(
5.0
,
6.6
),
]
]
,
);
});
...
...
@@ -47,19 +47,19 @@ void main() {
test
(
'illegal SVGs'
,
()
{
expect
(
()
{
interpretSvg
(
testAsset
(
'illegal_svg_multiple_roots.svg'
));
},
throwsA
(
anything
)
throwsA
(
anything
)
,
);
});
test
(
'SVG size'
,
()
{
expect
(
interpretSvg
(
testAsset
(
'empty_svg_1_48x48.svg'
)).
size
,
const
Point
<
double
>(
48.0
,
48.0
)
const
Point
<
double
>(
48.0
,
48.0
)
,
);
expect
(
interpretSvg
(
testAsset
(
'empty_svg_2_100x50.svg'
)).
size
,
const
Point
<
double
>(
100.0
,
50.0
)
const
Point
<
double
>(
100.0
,
50.0
)
,
);
});
...
...
@@ -83,7 +83,7 @@ void main() {
test
(
'SVG illegal path'
,
()
{
expect
(
()
{
interpretSvg
(
testAsset
(
'illegal_path.svg'
));
},
throwsA
(
anything
)
throwsA
(
anything
)
,
);
});
...
...
@@ -148,14 +148,14 @@ void main() {
SvgPathCommand
(
'Z'
,
<
Point
<
double
>>[]),
]),
margin:
precisionErrorTolerance
,
)
)
,
]);
});
test
(
'SVG illegal transform'
,
()
{
expect
(
()
{
interpretSvg
(
testAsset
(
'illegal_transform.svg'
));
},
throwsA
(
anything
)
throwsA
(
anything
)
,
);
});
...
...
@@ -235,8 +235,8 @@ void main() {
<
Point
<
double
>>[
Point
<
double
>(
10.0
,
10.0
)],
]),
],
opacities:
<
double
>[
1.0
]
))
opacities:
<
double
>[
1.0
]
,
))
,
);
});
...
...
@@ -265,10 +265,10 @@ void main() {
<
PathCommandAnimation
>[
PathCommandAnimation
(
'M'
,
<
List
<
Point
<
double
>>>[
<
Point
<
double
>>[
Point
<
double
>(
0.0
,
0.0
)],
])
])
,
],
opacities:
<
double
>[
1.0
]
))
opacities:
<
double
>[
1.0
]
,
))
,
);
expect
(
PathAnimation
.
fromFrameData
(
frameData
,
1
),
...
...
@@ -278,8 +278,8 @@ void main() {
<
Point
<
double
>>[
Point
<
double
>(
5.0
,
6.0
)],
])
],
opacities:
<
double
>[
1.0
]
))
opacities:
<
double
>[
1.0
]
,
))
,
);
});
...
...
@@ -291,7 +291,7 @@ void main() {
SvgPath
(
'path_1'
,
<
SvgPathCommand
>[
SvgPathCommand
(
'M'
,
<
Point
<
double
>>[
Point
<
double
>(
0.0
,
0.0
)])
SvgPathCommand
(
'M'
,
<
Point
<
double
>>[
Point
<
double
>(
0.0
,
0.0
)])
,
],
opacity:
0.5
,
),
...
...
@@ -303,7 +303,7 @@ void main() {
SvgPath
(
'path_1'
,
<
SvgPathCommand
>[
SvgPathCommand
(
'M'
,
<
Point
<
double
>>[
Point
<
double
>(
10.0
,
10.0
)])
SvgPathCommand
(
'M'
,
<
Point
<
double
>>[
Point
<
double
>(
10.0
,
10.0
)])
,
],
),
],
...
...
@@ -319,8 +319,8 @@ void main() {
],
]),
],
opacities:
<
double
>[
0.5
,
1.0
]
))
opacities:
<
double
>[
0.5
,
1.0
]
,
))
,
);
});
});
...
...
@@ -352,10 +352,10 @@ void main() {
<
PathCommandAnimation
>[
PathCommandAnimation
(
'M'
,
<
List
<
Point
<
double
>>>[
<
Point
<
double
>>[
Point
<
double
>(
0.0
,
0.0
)],
])
])
,
],
opacities:
<
double
>[
1.0
]
))
opacities:
<
double
>[
1.0
]
,
))
,
);
expect
(
animation
.
paths
[
1
],
...
...
@@ -363,10 +363,10 @@ void main() {
<
PathCommandAnimation
>[
PathCommandAnimation
(
'M'
,
<
List
<
Point
<
double
>>>[
<
Point
<
double
>>[
Point
<
double
>(
5.0
,
6.0
)],
])
])
,
],
opacities:
<
double
>[
1.0
]
))
opacities:
<
double
>[
1.0
]
,
))
,
);
expect
(
animation
.
size
,
const
Point
<
double
>(
10.0
,
10.0
));
...
...
@@ -391,7 +391,7 @@ void main() {
' const Offset(1.0, 2.0),
\n
'
' const Offset(3.0, 4.0),
\n
'
' ],
\n
'
' ),
\n
'
' ),
\n
'
,
);
});
...
...
@@ -413,7 +413,7 @@ void main() {
' const Offset(1.0, 2.0),
\n
'
' const Offset(3.0, 4.0),
\n
'
' ],
\n
'
' ),
\n
'
' ),
\n
'
,
);
});
...
...
@@ -451,7 +451,7 @@ void main() {
' const Offset(40.0, 40.0),
\n
'
' const Offset(40.0, 40.0),
\n
'
' ],
\n
'
' ),
\n
'
' ),
\n
'
,
);
});
...
...
@@ -464,7 +464,7 @@ void main() {
expect
(
command
.
toDart
(),
' const _PathClose(
\n
'
' ),
\n
'
' ),
\n
'
,
);
});
...
...
@@ -477,7 +477,7 @@ void main() {
expect
(
()
{
command
.
toDart
();
},
throwsA
(
anything
)
throwsA
(
anything
)
,
);
});
...
...
@@ -497,7 +497,7 @@ void main() {
],
]),
],
opacities:
<
double
>[
0.5
,
1.0
]
opacities:
<
double
>[
0.5
,
1.0
]
,
);
expect
(
pathAnimation
.
toDart
(),
...
...
@@ -520,7 +520,7 @@ void main() {
' ],
\n
'
' ),
\n
'
' ],
\n
'
' ),
\n
'
' ),
\n
'
,
);
});
...
...
@@ -543,7 +543,7 @@ void main() {
],
]),
],
opacities:
<
double
>[
0.5
,
1.0
]
opacities:
<
double
>[
0.5
,
1.0
]
,
),
PathAnimation
(
...
...
@@ -555,7 +555,7 @@ void main() {
],
]),
],
opacities:
<
double
>[
0.5
,
1.0
]
opacities:
<
double
>[
0.5
,
1.0
]
,
),
]);
...
...
@@ -598,7 +598,7 @@ void main() {
' ],
\n
'
' ),
\n
'
' ],
\n
'
');'
');'
,
);
});
});
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment