Unverified Commit a21c93dd authored by Alexander Aprelev's avatar Alexander Aprelev Committed by GitHub

Fix boolean flag parsing in gradle. Track 'trackWidgetCreation' as property of the build. (#16901)

parent c7ee37a0
...@@ -258,7 +258,7 @@ class FlutterPlugin implements Plugin<Project> { ...@@ -258,7 +258,7 @@ class FlutterPlugin implements Plugin<Project> {
Boolean previewDart2Value = false Boolean previewDart2Value = false
if (project.hasProperty('preview-dart-2')) { if (project.hasProperty('preview-dart-2')) {
previewDart2Value = project.property('preview-dart-2') previewDart2Value = project.property('preview-dart-2').toBoolean()
} }
String[] fileSystemRootsValue = null String[] fileSystemRootsValue = null
if (project.hasProperty('filesystem-roots')) { if (project.hasProperty('filesystem-roots')) {
...@@ -270,8 +270,9 @@ class FlutterPlugin implements Plugin<Project> { ...@@ -270,8 +270,9 @@ class FlutterPlugin implements Plugin<Project> {
} }
Boolean trackWidgetCreationValue = false Boolean trackWidgetCreationValue = false
if (project.hasProperty('track-widget-creation')) { if (project.hasProperty('track-widget-creation')) {
trackWidgetCreationValue = project.property('track-widget-creation') trackWidgetCreationValue = project.property('track-widget-creation').toBoolean()
} }
String extraFrontEndOptionsValue = null String extraFrontEndOptionsValue = null
if (project.hasProperty('extra-front-end-options')) { if (project.hasProperty('extra-front-end-options')) {
extraFrontEndOptionsValue = project.property('extra-front-end-options') extraFrontEndOptionsValue = project.property('extra-front-end-options')
...@@ -282,7 +283,7 @@ class FlutterPlugin implements Plugin<Project> { ...@@ -282,7 +283,7 @@ class FlutterPlugin implements Plugin<Project> {
} }
Boolean preferSharedLibraryValue = false Boolean preferSharedLibraryValue = false
if (project.hasProperty('prefer-shared-library')) { if (project.hasProperty('prefer-shared-library')) {
preferSharedLibraryValue = project.property('prefer-shared-library') preferSharedLibraryValue = project.property('prefer-shared-library').toBoolean()
} }
String targetPlatformValue = null String targetPlatformValue = null
if (project.hasProperty('target-platform')) { if (project.hasProperty('target-platform')) {
......
...@@ -85,6 +85,7 @@ Future<void> build({ ...@@ -85,6 +85,7 @@ Future<void> build({
..add(mainPath); ..add(mainPath);
final Map<String, String> properties = <String, String>{ final Map<String, String> properties = <String, String>{
'entryPoint': mainPath, 'entryPoint': mainPath,
'trackWidgetCreation': trackWidgetCreation.toString(),
}; };
return new Fingerprint.fromBuildInputs(properties, compilerInputPaths); return new Fingerprint.fromBuildInputs(properties, compilerInputPaths);
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment