Unverified Commit 9fb1ae83 authored by Camille Simon's avatar Camille Simon Committed by GitHub

[iOS] Add task for spell check integration test (#116222)

* Add fix and test

* Add test owner

* Print error for testing

* Make sure locale is the problem

* Test capitalization fix

* Take out Android specific test

* Verify eng fix

* Test fix

* Empty-Commit

* Test all tests

* Up string size for testing

* Remove test

* Undo ci.yaml testing changes

* Test android variant:

* Change to testwidgets

* Add widget tester

* Remove android only attempt

* Revert ci.yaml changes
parent ca7ca3b8
...@@ -3895,7 +3895,7 @@ targets: ...@@ -3895,7 +3895,7 @@ targets:
properties: properties:
tags: > tags: >
["devicelab", "ios", "mac"] ["devicelab", "ios", "mac"]
task_name: spell_check_test task_name: spell_check_test_ios
- name: Mac native_ui_tests_macos - name: Mac native_ui_tests_macos
recipe: devicelab/devicelab_drone recipe: devicelab/devicelab_drone
......
...@@ -259,6 +259,7 @@ ...@@ -259,6 +259,7 @@
/dev/devicelab/bin/tasks/web_benchmarks_html.dart @yjbanov @flutter/web /dev/devicelab/bin/tasks/web_benchmarks_html.dart @yjbanov @flutter/web
/dev/devicelab/bin/tasks/windows_home_scroll_perf__timeline_summary.dart @jonahwilliams @flutter/engine /dev/devicelab/bin/tasks/windows_home_scroll_perf__timeline_summary.dart @jonahwilliams @flutter/engine
/dev/devicelab/bin/tasks/windows_startup_test.dart @loic-sharma @flutter/desktop /dev/devicelab/bin/tasks/windows_startup_test.dart @loic-sharma @flutter/desktop
/dev/devicelab/bin/tasks/spell_check_test_ios.dart @camsim99 @flutter/android
## Host only framework tests ## Host only framework tests
# Linux analyze # Linux analyze
......
// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import 'package:flutter_devicelab/framework/devices.dart';
import 'package:flutter_devicelab/framework/framework.dart';
import 'package:flutter_devicelab/tasks/integration_tests.dart';
Future<void> main() async {
deviceOperatingSystem = DeviceOperatingSystem.ios;
await task(createSpellCheckIntegrationTest());
}
...@@ -176,26 +176,4 @@ void main() { ...@@ -176,26 +176,4 @@ void main() {
expect(expectedTextSpanTreeFound, isTrue); expect(expectedTextSpanTreeFound, isTrue);
}); });
test(
'fetchSpellCheckSuggestions returns null when there is a pending request',
() async {
final String text =
'neaf niofenaifn iofn iefnaoeifn ifneoa finoiafn inf ionfieaon ienf ifn ieonfaiofneionf oieafn oifnaioe nioenfio nefaion oifan' *
10;
defaultSpellCheckService.fetchSpellCheckSuggestions(locale, text);
final String modifiedText = text.substring(5);
final List<SuggestionSpan>? spellCheckSuggestionSpans =
await defaultSpellCheckService.fetchSpellCheckSuggestions(
locale, modifiedText);
expect(spellCheckSuggestionSpans, isNull);
// We expect it to be rare for the first request to complete before the
// second, so no text should be saved as of now.
expect(defaultSpellCheckService.lastSavedResults, null);
});
} }
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment