Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
9ec5d713
Unverified
Commit
9ec5d713
authored
Nov 03, 2020
by
Jonah Williams
Committed by
GitHub
Nov 03, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove usage of --enable-experiment to analysis server (#69614)
parent
c4bd14cc
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
3 additions
and
29 deletions
+3
-29
analysis_options.yaml
packages/flutter/test_private/analysis_options.yaml
+1
-0
test_private.dart
packages/flutter/test_private/bin/test_private.dart
+2
-2
analyze_once_test.dart
...ools/test/commands.shard/permeable/analyze_once_test.dart
+0
-27
No files found.
packages/flutter/test_private/analysis_options.yaml
0 → 100644
View file @
9ec5d713
include
:
../analysis_options.yaml
packages/flutter/test_private/bin/test_private.dart
View file @
9ec5d713
...
@@ -207,7 +207,7 @@ class TestCase {
...
@@ -207,7 +207,7 @@ class TestCase {
printOutputDefault:
true
,
printOutputDefault:
true
,
);
);
final
ProcessRunnerResult
result
=
await
runner
.
runProcess
(
final
ProcessRunnerResult
result
=
await
runner
.
runProcess
(
<
String
>[
flutter
,
'analyze'
,
'--current-package'
,
'--
enable-experiment=non-nullable'
,
'--
pub'
,
'--congratulate'
,
'.'
],
<
String
>[
flutter
,
'analyze'
,
'--current-package'
,
'--pub'
,
'--congratulate'
,
'.'
],
failOk:
true
,
failOk:
true
,
);
);
if
(
result
.
exitCode
!=
0
)
{
if
(
result
.
exitCode
!=
0
)
{
...
...
packages/flutter_tools/test/commands.shard/permeable/analyze_once_test.dart
View file @
9ec5d713
...
@@ -349,33 +349,6 @@ StringBuffer bar = StringBuffer('baz');
...
@@ -349,33 +349,6 @@ StringBuffer bar = StringBuffer('baz');
}
}
});
});
testUsingContext
(
'analyze once supports analyzing null-safe code'
,
()
async
{
const
String
contents
=
'''
int? bar;
'''
;
final
Directory
tempDir
=
fileSystem
.
systemTempDirectory
.
createTempSync
(
'flutter_analyze_once_test_null_safety.'
);
_createDotPackages
(
tempDir
.
path
,
true
);
tempDir
.
childFile
(
'main.dart'
).
writeAsStringSync
(
contents
);
try
{
await
runCommand
(
command:
AnalyzeCommand
(
workingDirectory:
fileSystem
.
directory
(
tempDir
),
platform:
_kNoColorTerminalPlatform
,
fileSystem:
fileSystem
,
logger:
logger
,
processManager:
processManager
,
terminal:
terminal
,
artifacts:
artifacts
,
),
arguments:
<
String
>[
'analyze'
,
'--no-pub'
,
'--enable-experiment=non-nullable'
],
statusTextContains:
<
String
>[
'No issues found!'
],
);
}
finally
{
tryToDelete
(
tempDir
);
}
});
testUsingContext
(
'analyze once returns no issues for todo comments'
,
()
async
{
testUsingContext
(
'analyze once returns no issues for todo comments'
,
()
async
{
const
String
contents
=
'''
const
String
contents
=
'''
// TODO(foobar):
// TODO(foobar):
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment