Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
9ea78d44
Unverified
Commit
9ea78d44
authored
Aug 01, 2019
by
Chinmay Garde
Committed by
GitHub
Aug 01, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Revert "Remove multi-arch check in iOS builds (#37407)" (#37413)
This reverts commit
58092195
.
parent
58092195
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
10 additions
and
1 deletion
+10
-1
engine.version
bin/internal/engine.version
+1
-1
build.dart
packages/flutter_tools/lib/src/base/build.dart
+9
-0
No files found.
bin/internal/engine.version
View file @
9ea78d44
9fca3c74491a6f92322ca55cab53b9361c583135
b41c172bcd861a09ccbe7a4b1addeb125d6f9541
packages/flutter_tools/lib/src/base/build.dart
View file @
9ea78d44
...
@@ -56,6 +56,15 @@ class GenSnapshot {
...
@@ -56,6 +56,15 @@ class GenSnapshot {
final
String
snapshotterPath
=
getSnapshotterPath
(
snapshotType
);
final
String
snapshotterPath
=
getSnapshotterPath
(
snapshotType
);
// iOS gen_snapshot is a multi-arch binary. Running as an i386 binary will
// generate armv7 code. Running as an x86_64 binary will generate arm64
// code. /usr/bin/arch can be used to run binaries with the specified
// architecture.
if
(
snapshotType
.
platform
==
TargetPlatform
.
ios
)
{
final
String
hostArch
=
iosArch
==
IOSArch
.
armv7
?
'-i386'
:
'-x86_64'
;
return
runCommandAndStreamOutput
(<
String
>[
'/usr/bin/arch'
,
hostArch
,
snapshotterPath
,
...
args
]);
}
StringConverter
outputFilter
;
StringConverter
outputFilter
;
if
(
additionalArgs
.
contains
(
'--strip'
))
{
if
(
additionalArgs
.
contains
(
'--strip'
))
{
// Filter out gen_snapshot's warning message about stripping debug symbols
// Filter out gen_snapshot's warning message about stripping debug symbols
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment