Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
9a3b9f62
Unverified
Commit
9a3b9f62
authored
Jun 30, 2022
by
Taha Tesser
Committed by
GitHub
Jun 30, 2022
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix `DropdownButton` Inkwell border radius (#106657)
parent
427aecc5
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
10 additions
and
1 deletion
+10
-1
dropdown.dart
packages/flutter/lib/src/material/dropdown.dart
+1
-0
dropdown_test.dart
packages/flutter/test/material/dropdown_test.dart
+9
-1
No files found.
packages/flutter/lib/src/material/dropdown.dart
View file @
9a3b9f62
...
...
@@ -1509,6 +1509,7 @@ class _DropdownButtonState<T> extends State<DropdownButton<T>> with WidgetsBindi
mouseCursor:
effectiveMouseCursor
,
onTap:
_enabled
?
_handleTap
:
null
,
canRequestFocus:
_enabled
,
borderRadius:
widget
.
borderRadius
,
focusNode:
focusNode
,
autofocus:
widget
.
autofocus
,
focusColor:
widget
.
focusColor
??
Theme
.
of
(
context
).
focusColor
,
...
...
packages/flutter/test/material/dropdown_test.dart
View file @
9a3b9f62
...
...
@@ -3810,7 +3810,7 @@ void main() {
expect
(
tester
.
getBottomRight
(
find
.
text
(
hintText
)).
dy
,
350.0
);
});
testWidgets
(
'BorderRadius property clips dropdown menu'
,
(
WidgetTester
tester
)
async
{
testWidgets
(
'BorderRadius property clips dropdown
button and dropdown
menu'
,
(
WidgetTester
tester
)
async
{
const
double
radius
=
20.0
;
await
tester
.
pumpWidget
(
...
...
@@ -3834,6 +3834,14 @@ void main() {
),
);
final
TestGesture
gesture
=
await
tester
.
createGesture
(
kind:
PointerDeviceKind
.
mouse
);
await
gesture
.
addPointer
();
await
gesture
.
moveTo
(
tester
.
getCenter
(
find
.
byType
(
DropdownButtonFormField
<
String
>)));
await
tester
.
pumpAndSettle
();
final
RenderObject
inkFeatures
=
tester
.
allRenderObjects
.
firstWhere
((
RenderObject
object
)
=>
object
.
runtimeType
.
toString
()
==
'_RenderInkFeatures'
);
expect
(
inkFeatures
,
paints
..
rrect
(
rrect:
RRect
.
fromLTRBR
(
0.0
,
276.0
,
800.0
,
324.0
,
const
Radius
.
circular
(
radius
))));
await
tester
.
tap
(
find
.
text
(
'One'
));
await
tester
.
pumpAndSettle
();
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment