Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
9995e370
Unverified
Commit
9995e370
authored
Oct 18, 2022
by
Greg Spencer
Committed by
GitHub
Oct 18, 2022
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix StarBorder operator== (#113588)
parent
021f8a54
Changes
4
Expand all
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
103 additions
and
61 deletions
+103
-61
star_border.dart
dev/manual_tests/lib/star_border.dart
+0
-2
star_border.0.dart
examples/api/lib/painting/star_border/star_border.0.dart
+0
-1
star_border.dart
packages/flutter/lib/src/painting/star_border.dart
+8
-1
star_border_test.dart
packages/flutter/test/painting/star_border_test.dart
+95
-57
No files found.
dev/manual_tests/lib/star_border.dart
View file @
9995e370
...
...
@@ -72,7 +72,6 @@ class _MyHomePageState extends State<MyHomePage> {
mainAxisAlignment:
MainAxisAlignment
.
spaceEvenly
,
children:
<
Widget
>[
Container
(
key:
UniqueKey
(),
alignment:
Alignment
.
center
,
width:
300
,
height:
200
,
...
...
@@ -94,7 +93,6 @@ class _MyHomePageState extends State<MyHomePage> {
child:
const
Text
(
'Polygon'
),
),
Container
(
key:
UniqueKey
(),
alignment:
Alignment
.
center
,
width:
300
,
height:
200
,
...
...
examples/api/lib/painting/star_border/star_border.0.dart
View file @
9995e370
...
...
@@ -144,7 +144,6 @@ class ExampleBorder extends StatelessWidget {
@override
Widget
build
(
BuildContext
context
)
{
return
Container
(
key:
UniqueKey
(),
alignment:
Alignment
.
center
,
padding:
const
EdgeInsets
.
all
(
20
),
width:
150
,
...
...
packages/flutter/lib/src/painting/star_border.dart
View file @
9995e370
...
...
@@ -422,7 +422,14 @@ class StarBorder extends OutlinedBorder {
if
(
other
.
runtimeType
!=
runtimeType
)
{
return
false
;
}
return
other
is
StarBorder
&&
other
.
side
==
side
;
return
other
is
StarBorder
&&
other
.
side
==
side
&&
other
.
points
==
points
&&
other
.
_innerRadiusRatio
==
_innerRadiusRatio
&&
other
.
pointRounding
==
pointRounding
&&
other
.
valleyRounding
==
valleyRounding
&&
other
.
_rotationRadians
==
_rotationRadians
&&
other
.
squash
==
squash
;
}
@override
...
...
packages/flutter/test/painting/star_border_test.dart
View file @
9995e370
This diff is collapsed.
Click to expand it.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment