Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
9664a109
Unverified
Commit
9664a109
authored
Aug 03, 2021
by
Darren Austin
Committed by
GitHub
Aug 03, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Revert "Updated the skipped tests for cupertino package. (#87289)" (#87537)
This reverts commit
faf774eb
.
parent
faf774eb
Changes
5
Show whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
26 additions
and
27 deletions
+26
-27
dialog_test.dart
packages/flutter/test/cupertino/dialog_test.dart
+1
-1
text_field_test.dart
packages/flutter/test/cupertino/text_field_test.dart
+12
-13
text_form_field_row_test.dart
...ages/flutter/test/cupertino/text_form_field_row_test.dart
+1
-1
text_selection_test.dart
packages/flutter/test/cupertino/text_selection_test.dart
+9
-9
text_selection_toolbar_test.dart
...s/flutter/test/cupertino/text_selection_toolbar_test.dart
+3
-3
No files found.
packages/flutter/test/cupertino/dialog_test.dart
View file @
9664a109
...
@@ -917,7 +917,7 @@ void main() {
...
@@ -917,7 +917,7 @@ void main() {
// We must explicitly cause an "up" gesture to avoid a crash.
// We must explicitly cause an "up" gesture to avoid a crash.
// todo(mattcarroll) remove this call, https://github.com/flutter/flutter/issues/19540
// todo(mattcarroll) remove this call, https://github.com/flutter/flutter/issues/19540
await
gesture
.
up
();
await
gesture
.
up
();
}
);
}
,
skip:
isBrowser
);
// https://github.com/flutter/flutter/issues/52960
testWidgets
(
'ScaleTransition animation for showCupertinoDialog()'
,
(
WidgetTester
tester
)
async
{
testWidgets
(
'ScaleTransition animation for showCupertinoDialog()'
,
(
WidgetTester
tester
)
async
{
await
tester
.
pumpWidget
(
await
tester
.
pumpWidget
(
...
...
packages/flutter/test/cupertino/text_field_test.dart
View file @
9664a109
...
@@ -289,10 +289,7 @@ void main() {
...
@@ -289,10 +289,7 @@ void main() {
expect
(
controller
.
text
,
' blah2blah1'
);
expect
(
controller
.
text
,
' blah2blah1'
);
expect
(
controller
.
selection
,
const
TextSelection
(
baseOffset:
0
,
extentOffset:
0
));
expect
(
controller
.
selection
,
const
TextSelection
(
baseOffset:
0
,
extentOffset:
0
));
expect
(
find
.
byType
(
CupertinoButton
),
findsNothing
);
expect
(
find
.
byType
(
CupertinoButton
),
findsNothing
);
},
},
variant:
const
TargetPlatformVariant
(<
TargetPlatform
>{
TargetPlatform
.
macOS
}),
skip:
kIsWeb
);
variant:
const
TargetPlatformVariant
(<
TargetPlatform
>{
TargetPlatform
.
macOS
}),
skip:
kIsWeb
,
// [intended] the web handles this on its own.
);
testWidgets
(
'Activates the text field when receives semantics focus on Mac'
,
(
WidgetTester
tester
)
async
{
testWidgets
(
'Activates the text field when receives semantics focus on Mac'
,
(
WidgetTester
tester
)
async
{
final
SemanticsTester
semantics
=
SemanticsTester
(
tester
);
final
SemanticsTester
semantics
=
SemanticsTester
(
tester
);
...
@@ -457,7 +454,8 @@ void main() {
...
@@ -457,7 +454,8 @@ void main() {
);
);
},
},
// TODO(mdebbar): Strut styles support.
// TODO(mdebbar): Strut styles support.
skip:
isBrowser
,
// https://github.com/flutter/flutter/issues/32243
// https://github.com/flutter/flutter/issues/32243
skip:
isBrowser
,
);
);
testWidgets
(
testWidgets
(
...
@@ -487,7 +485,8 @@ void main() {
...
@@ -487,7 +485,8 @@ void main() {
);
);
},
},
// TODO(mdebbar): Strut styles support.
// TODO(mdebbar): Strut styles support.
skip:
isBrowser
,
// https://github.com/flutter/flutter/issues/32243
// https://github.com/flutter/flutter/issues/32243
skip:
isBrowser
,
);
);
testWidgets
(
testWidgets
(
...
@@ -1490,7 +1489,7 @@ void main() {
...
@@ -1490,7 +1489,7 @@ void main() {
expect
(
text
.
style
!.
fontSize
,
14
);
expect
(
text
.
style
!.
fontSize
,
14
);
expect
(
text
.
style
!.
letterSpacing
,
-
0.15
);
expect
(
text
.
style
!.
letterSpacing
,
-
0.15
);
expect
(
text
.
style
!.
fontWeight
,
FontWeight
.
w400
);
expect
(
text
.
style
!.
fontWeight
,
FontWeight
.
w400
);
},
skip:
isContextMenuProvidedByPlatform
);
// [intended] only applies to platforms where we supply the context menu.
},
skip:
isContextMenuProvidedByPlatform
);
testWidgets
(
'text field toolbar options correctly changes options'
,
(
WidgetTester
tester
)
async
{
testWidgets
(
'text field toolbar options correctly changes options'
,
(
WidgetTester
tester
)
async
{
final
TextEditingController
controller
=
TextEditingController
(
final
TextEditingController
controller
=
TextEditingController
(
...
@@ -1533,7 +1532,7 @@ void main() {
...
@@ -1533,7 +1532,7 @@ void main() {
expect
(
find
.
text
(
'Copy'
),
findsOneWidget
);
expect
(
find
.
text
(
'Copy'
),
findsOneWidget
);
expect
(
find
.
text
(
'Cut'
),
findsNothing
);
expect
(
find
.
text
(
'Cut'
),
findsNothing
);
expect
(
find
.
text
(
'Select All'
),
findsNothing
);
expect
(
find
.
text
(
'Select All'
),
findsNothing
);
},
skip:
isContextMenuProvidedByPlatform
);
// [intended] only applies to platforms where we supply the context menu.
},
skip:
isContextMenuProvidedByPlatform
);
testWidgets
(
'Read only text field'
,
(
WidgetTester
tester
)
async
{
testWidgets
(
'Read only text field'
,
(
WidgetTester
tester
)
async
{
final
TextEditingController
controller
=
TextEditingController
(
text:
'readonly'
);
final
TextEditingController
controller
=
TextEditingController
(
text:
'readonly'
);
...
@@ -1570,7 +1569,7 @@ void main() {
...
@@ -1570,7 +1569,7 @@ void main() {
expect
(
find
.
text
(
'Copy'
),
findsOneWidget
);
expect
(
find
.
text
(
'Copy'
),
findsOneWidget
);
expect
(
find
.
text
(
'Paste'
),
findsNothing
);
expect
(
find
.
text
(
'Paste'
),
findsNothing
);
expect
(
find
.
text
(
'Cut'
),
findsNothing
);
expect
(
find
.
text
(
'Cut'
),
findsNothing
);
},
skip:
isContextMenuProvidedByPlatform
);
// [intended] only applies to platforms where we supply the context menu.
},
skip:
isContextMenuProvidedByPlatform
);
testWidgets
(
'copy paste'
,
(
WidgetTester
tester
)
async
{
testWidgets
(
'copy paste'
,
(
WidgetTester
tester
)
async
{
await
tester
.
pumpWidget
(
await
tester
.
pumpWidget
(
...
@@ -1621,7 +1620,7 @@ void main() {
...
@@ -1621,7 +1620,7 @@ void main() {
expect
(
find
.
text
(
'field 1'
),
findsOneWidget
);
expect
(
find
.
text
(
'field 1'
),
findsOneWidget
);
expect
(
find
.
text
(
"j'aime la poutine"
),
findsOneWidget
);
expect
(
find
.
text
(
"j'aime la poutine"
),
findsOneWidget
);
expect
(
find
.
text
(
'field 2'
),
findsNothing
);
expect
(
find
.
text
(
'field 2'
),
findsNothing
);
},
exclude
:
isContextMenuProvidedByPlatform
);
},
skip
:
isContextMenuProvidedByPlatform
);
testWidgets
(
testWidgets
(
'tap moves cursor to the edge of the word it tapped on'
,
'tap moves cursor to the edge of the word it tapped on'
,
...
@@ -2205,7 +2204,7 @@ void main() {
...
@@ -2205,7 +2204,7 @@ void main() {
expect
(
find
.
text
(
'Select All'
),
findsOneWidget
);
expect
(
find
.
text
(
'Select All'
),
findsOneWidget
);
expect
(
find
.
text
(
'Copy'
),
findsNothing
);
expect
(
find
.
text
(
'Copy'
),
findsNothing
);
expect
(
find
.
text
(
'Cut'
),
findsNothing
);
expect
(
find
.
text
(
'Cut'
),
findsNothing
);
},
skip:
isContextMenuProvidedByPlatform
);
// [intended] only applies to platforms where we supply the context menu.
},
skip:
isContextMenuProvidedByPlatform
);
testWidgets
(
testWidgets
(
'long press moves cursor to the exact long press position and shows toolbar'
,
'long press moves cursor to the exact long press position and shows toolbar'
,
...
@@ -3230,7 +3229,7 @@ void main() {
...
@@ -3230,7 +3229,7 @@ void main() {
textFieldTopLeft
=
tester
.
getTopLeft
(
find
.
byType
(
CupertinoTextField
));
textFieldTopLeft
=
tester
.
getTopLeft
(
find
.
byType
(
CupertinoTextField
));
expect
(
toolbarTopLeft
.
dy
,
lessThan
(
textFieldTopLeft
.
dy
));
expect
(
toolbarTopLeft
.
dy
,
lessThan
(
textFieldTopLeft
.
dy
));
},
},
skip:
isContextMenuProvidedByPlatform
,
// [intended] only applies to platforms where we supply the context menu.
skip:
isContextMenuProvidedByPlatform
,
);
);
testWidgets
(
'text field respects keyboardAppearance from theme'
,
(
WidgetTester
tester
)
async
{
testWidgets
(
'text field respects keyboardAppearance from theme'
,
(
WidgetTester
tester
)
async
{
...
@@ -3827,7 +3826,7 @@ void main() {
...
@@ -3827,7 +3826,7 @@ void main() {
expect
(
find
.
byType
(
CupertinoTextSelectionToolbar
),
findsOneWidget
);
expect
(
find
.
byType
(
CupertinoTextSelectionToolbar
),
findsOneWidget
);
expect
(
tester
.
takeException
(),
null
);
expect
(
tester
.
takeException
(),
null
);
});
});
},
skip:
isContextMenuProvidedByPlatform
);
// [intended] only applies to platforms where we supply the context menu.
},
skip:
isContextMenuProvidedByPlatform
);
group
(
'textAlignVertical position'
,
()
{
group
(
'textAlignVertical position'
,
()
{
group
(
'simple case'
,
()
{
group
(
'simple case'
,
()
{
...
...
packages/flutter/test/cupertino/text_form_field_row_test.dart
View file @
9664a109
...
@@ -262,7 +262,7 @@ void main() {
...
@@ -262,7 +262,7 @@ void main() {
await
tester
.
pump
(
const
Duration
(
milliseconds:
200
));
await
tester
.
pump
(
const
Duration
(
milliseconds:
200
));
expect
(
renderEditable
,
paintsExactlyCountTimes
(
#drawRect
,
0
));
expect
(
renderEditable
,
paintsExactlyCountTimes
(
#drawRect
,
0
));
},
skip:
isBrowser
);
//
[intended] We do not use Flutter-rendered context menu on the Web.
},
skip:
isBrowser
);
//
We do not use Flutter-rendered context menu on the Web
testWidgets
(
'onTap is called upon tap'
,
(
WidgetTester
tester
)
async
{
testWidgets
(
'onTap is called upon tap'
,
(
WidgetTester
tester
)
async
{
int
tapCount
=
0
;
int
tapCount
=
0
;
...
...
packages/flutter/test/cupertino/text_selection_test.dart
View file @
9664a109
...
@@ -251,7 +251,7 @@ void main() {
...
@@ -251,7 +251,7 @@ void main() {
expect
(
find
.
text
(
'Copy'
),
findsOneWidget
);
expect
(
find
.
text
(
'Copy'
),
findsOneWidget
);
expect
(
find
.
text
(
'Cut'
),
findsOneWidget
);
expect
(
find
.
text
(
'Cut'
),
findsOneWidget
);
},
},
exclude
:
isBrowser
,
// We do not use Flutter-rendered context menu on the Web
skip
:
isBrowser
,
// We do not use Flutter-rendered context menu on the Web
variant:
const
TargetPlatformVariant
(<
TargetPlatform
>{
TargetPlatform
.
iOS
}),
variant:
const
TargetPlatformVariant
(<
TargetPlatform
>{
TargetPlatform
.
iOS
}),
);
);
...
@@ -305,7 +305,7 @@ void main() {
...
@@ -305,7 +305,7 @@ void main() {
expect
(
find
.
text
(
'◀'
),
findsNothing
);
expect
(
find
.
text
(
'◀'
),
findsNothing
);
expect
(
find
.
text
(
'▶'
),
findsNothing
);
expect
(
find
.
text
(
'▶'
),
findsNothing
);
},
},
skip:
isBrowser
,
//
[intended] We do not use Flutter-rendered context menu on the Web.
skip:
isBrowser
,
//
We do not use Flutter-rendered context menu on the Web
variant:
const
TargetPlatformVariant
(<
TargetPlatform
>{
TargetPlatform
.
iOS
}),
variant:
const
TargetPlatformVariant
(<
TargetPlatform
>{
TargetPlatform
.
iOS
}),
);
);
...
@@ -376,7 +376,7 @@ void main() {
...
@@ -376,7 +376,7 @@ void main() {
expect
(
find
.
text
(
'▶'
),
findsOneWidget
);
expect
(
find
.
text
(
'▶'
),
findsOneWidget
);
expect
(
appearsEnabled
(
tester
,
'▶'
),
true
);
expect
(
appearsEnabled
(
tester
,
'▶'
),
true
);
},
},
skip:
isBrowser
,
//
[intended] We do not use Flutter-rendered context menu on the Web.
skip:
isBrowser
,
//
We do not use Flutter-rendered context menu on the Web
variant:
const
TargetPlatformVariant
(<
TargetPlatform
>{
TargetPlatform
.
iOS
}),
variant:
const
TargetPlatformVariant
(<
TargetPlatform
>{
TargetPlatform
.
iOS
}),
);
);
...
@@ -478,7 +478,7 @@ void main() {
...
@@ -478,7 +478,7 @@ void main() {
expect
(
find
.
text
(
'▶'
),
findsOneWidget
);
expect
(
find
.
text
(
'▶'
),
findsOneWidget
);
expect
(
appearsEnabled
(
tester
,
'▶'
),
true
);
expect
(
appearsEnabled
(
tester
,
'▶'
),
true
);
},
},
skip:
isBrowser
,
//
[intended] We do not use Flutter-rendered context menu on the Web.
skip:
isBrowser
,
//
We do not use Flutter-rendered context menu on the Web
variant:
const
TargetPlatformVariant
(<
TargetPlatform
>{
TargetPlatform
.
iOS
}),
variant:
const
TargetPlatformVariant
(<
TargetPlatform
>{
TargetPlatform
.
iOS
}),
);
);
...
@@ -596,7 +596,7 @@ void main() {
...
@@ -596,7 +596,7 @@ void main() {
expect
(
find
.
text
(
'▶'
),
findsOneWidget
);
expect
(
find
.
text
(
'▶'
),
findsOneWidget
);
expect
(
appearsEnabled
(
tester
,
'▶'
),
true
);
expect
(
appearsEnabled
(
tester
,
'▶'
),
true
);
},
},
skip:
isBrowser
,
//
[intended] We do not use Flutter-rendered context menu on the Web.
skip:
isBrowser
,
//
We do not use Flutter-rendered context menu on the Web
variant:
const
TargetPlatformVariant
(<
TargetPlatform
>{
TargetPlatform
.
iOS
}),
variant:
const
TargetPlatformVariant
(<
TargetPlatform
>{
TargetPlatform
.
iOS
}),
);
);
});
});
...
@@ -677,7 +677,7 @@ void main() {
...
@@ -677,7 +677,7 @@ void main() {
expect
(
handles
.
first
.
size
.
height
,
60.5
);
expect
(
handles
.
first
.
size
.
height
,
60.5
);
expect
(
handles
.
last
.
size
.
height
,
35.5
);
expect
(
handles
.
last
.
size
.
height
,
35.5
);
},
},
skip:
isBrowser
,
//
[intended] We do not use Flutter-rendered context menu on the Web.
skip:
isBrowser
,
//
We do not use Flutter-rendered context menu on the Web
variant:
const
TargetPlatformVariant
(<
TargetPlatform
>{
TargetPlatform
.
iOS
}),
variant:
const
TargetPlatformVariant
(<
TargetPlatform
>{
TargetPlatform
.
iOS
}),
);
);
...
@@ -761,7 +761,7 @@ void main() {
...
@@ -761,7 +761,7 @@ void main() {
expect
(
handles
.
first
.
size
.
height
,
110.5
);
expect
(
handles
.
first
.
size
.
height
,
110.5
);
expect
(
handles
.
last
.
size
.
height
,
110.5
);
expect
(
handles
.
last
.
size
.
height
,
110.5
);
},
},
skip:
isBrowser
,
//
[intended] We do not use Flutter-rendered context menu on the Web.
skip:
isBrowser
,
//
We do not use Flutter-rendered context menu on the Web
variant:
const
TargetPlatformVariant
(<
TargetPlatform
>{
TargetPlatform
.
iOS
}),
variant:
const
TargetPlatformVariant
(<
TargetPlatform
>{
TargetPlatform
.
iOS
}),
);
);
...
@@ -842,7 +842,7 @@ void main() {
...
@@ -842,7 +842,7 @@ void main() {
expect
(
handles
.
first
.
size
.
height
,
60.5
);
expect
(
handles
.
first
.
size
.
height
,
60.5
);
expect
(
handles
.
last
.
size
.
height
,
45.5
);
expect
(
handles
.
last
.
size
.
height
,
45.5
);
},
},
skip:
isBrowser
,
//
[intended] We do not use Flutter-rendered context menu on the Web.
skip:
isBrowser
,
//
We do not use Flutter-rendered context menu on the Web
variant:
const
TargetPlatformVariant
(<
TargetPlatform
>{
TargetPlatform
.
iOS
}),
variant:
const
TargetPlatformVariant
(<
TargetPlatform
>{
TargetPlatform
.
iOS
}),
);
);
...
@@ -928,7 +928,7 @@ void main() {
...
@@ -928,7 +928,7 @@ void main() {
expect
(
handles
.
first
.
size
.
height
,
50.5
);
expect
(
handles
.
first
.
size
.
height
,
50.5
);
expect
(
handles
.
last
.
size
.
height
,
50.5
);
// This is 60.5 with the previous frame.
expect
(
handles
.
last
.
size
.
height
,
50.5
);
// This is 60.5 with the previous frame.
},
},
skip:
isBrowser
,
//
[intended] We do not use Flutter-rendered context menu on the Web.
skip:
isBrowser
,
//
We do not use Flutter-rendered context menu on the Web
variant:
const
TargetPlatformVariant
(<
TargetPlatform
>{
TargetPlatform
.
iOS
}),
variant:
const
TargetPlatformVariant
(<
TargetPlatform
>{
TargetPlatform
.
iOS
}),
);
);
}
}
packages/flutter/test/cupertino/text_selection_toolbar_test.dart
View file @
9664a109
...
@@ -180,7 +180,7 @@ void main() {
...
@@ -180,7 +180,7 @@ void main() {
expect
(
find
.
byType
(
TestBox
),
findsNWidgets
(
7
));
expect
(
find
.
byType
(
TestBox
),
findsNWidgets
(
7
));
expect
(
_findOverflowNextButton
(),
findsOneWidget
);
expect
(
_findOverflowNextButton
(),
findsOneWidget
);
expect
(
_findOverflowBackButton
(),
findsNothing
);
expect
(
_findOverflowBackButton
(),
findsNothing
);
},
skip:
kIsWeb
);
// [intended] We do not use Flutter-rendered context menu on the Web.
},
skip:
kIsWeb
);
testWidgets
(
'positions itself at anchorAbove if it fits'
,
(
WidgetTester
tester
)
async
{
testWidgets
(
'positions itself at anchorAbove if it fits'
,
(
WidgetTester
tester
)
async
{
late
StateSetter
setState
;
late
StateSetter
setState
;
...
@@ -229,7 +229,7 @@ void main() {
...
@@ -229,7 +229,7 @@ void main() {
await
tester
.
pump
();
await
tester
.
pump
();
toolbarY
=
tester
.
getTopLeft
(
_findToolbar
()).
dy
;
toolbarY
=
tester
.
getTopLeft
(
_findToolbar
()).
dy
;
expect
(
toolbarY
,
equals
(
anchorAboveY
-
height
-
_kToolbarContentDistance
));
expect
(
toolbarY
,
equals
(
anchorAboveY
-
height
-
_kToolbarContentDistance
));
},
skip:
kIsWeb
);
// [intended] We do not use Flutter-rendered context menu on the Web.
},
skip:
kIsWeb
);
testWidgets
(
'can create and use a custom toolbar'
,
(
WidgetTester
tester
)
async
{
testWidgets
(
'can create and use a custom toolbar'
,
(
WidgetTester
tester
)
async
{
final
TextEditingController
controller
=
TextEditingController
(
final
TextEditingController
controller
=
TextEditingController
(
...
@@ -262,5 +262,5 @@ void main() {
...
@@ -262,5 +262,5 @@ void main() {
expect
(
find
.
text
(
'Copy'
),
findsNothing
);
expect
(
find
.
text
(
'Copy'
),
findsNothing
);
expect
(
find
.
text
(
'Paste'
),
findsNothing
);
expect
(
find
.
text
(
'Paste'
),
findsNothing
);
expect
(
find
.
text
(
'Select all'
),
findsNothing
);
expect
(
find
.
text
(
'Select all'
),
findsNothing
);
},
skip:
kIsWeb
);
// [intended] We do not use Flutter-rendered context menu on the Web.
},
skip:
kIsWeb
);
}
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment