Unverified Commit 95116386 authored by Gustav Bylund's avatar Gustav Bylund Committed by GitHub

Replace ListView with ListView.builder for LicensesPage (#102692)

parent 6504f289
...@@ -607,31 +607,29 @@ class _PackagesViewState extends State<_PackagesView> { ...@@ -607,31 +607,29 @@ class _PackagesViewState extends State<_PackagesView> {
final _LicenseData data, final _LicenseData data,
final bool drawSelection, final bool drawSelection,
) { ) {
return ListView( return ListView.builder(
children: <Widget>[ itemCount: data.packages.length + 1,
widget.about, itemBuilder: (BuildContext context, int index) {
...data.packages if (index == 0) {
.asMap() return widget.about;
.entries }
.map<Widget>((MapEntry<int, String> entry) { final int packageIndex = index - 1;
final String packageName = entry.value; final String packageName = data.packages[packageIndex];
final int index = entry.key; final List<int> bindings = data.packageLicenseBindings[packageName]!;
final List<int> bindings = data.packageLicenseBindings[packageName]!; return _PackageListTile(
return _PackageListTile( packageName: packageName,
packageName: packageName, index: packageIndex,
index: index, isSelected: drawSelection && packageIndex == (selectedId ?? 0),
isSelected: drawSelection && entry.key == (selectedId ?? 0), numberLicenses: bindings.length,
numberLicenses: bindings.length, onTap: () {
onTap: () { widget.selectedId.value = packageIndex;
widget.selectedId.value = index; _MasterDetailFlow.of(context)!.openDetailPage(_DetailArguments(
_MasterDetailFlow.of(context)!.openDetailPage(_DetailArguments( packageName,
packageName, bindings.map((int i) => data.licenses[i]).toList(growable: false),
bindings.map((int i) => data.licenses[i]).toList(growable: false), ));
)); },
}, );
); },
}),
],
); );
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment