Commit 9455fb64 authored by Jason Simmons's avatar Jason Simmons Committed by GitHub

Allow upgrades and version checks against the alpha branch (#9387)

Fixes https://github.com/flutter/flutter/issues/9258
parent 9493df2d
......@@ -36,12 +36,6 @@ class UpgradeCommand extends FlutterCommand {
}
final FlutterVersion flutterVersion = FlutterVersion.instance;
if (flutterVersion.channel == 'alpha') {
// The alpha branch is deprecated. Rather than trying to pull the alpha
// branch, we should switch upstream to master.
printStatus('Switching to from alpha to master...');
runSync(<String>['git', 'branch', '--set-upstream-to=origin/master']);
}
printStatus('Upgrading Flutter from ${Cache.flutterRoot}...');
......
......@@ -107,7 +107,7 @@ class FlutterVersion {
///
/// Throws [ToolExit] if a git command fails, for example, when the remote git
/// repository is not reachable due to a network issue.
static Future<String> fetchRemoteFrameworkCommitDate() async {
static Future<String> fetchRemoteFrameworkCommitDate(String branch) async {
await _removeVersionCheckRemoteIfExists();
try {
await _run(<String>[
......@@ -117,8 +117,8 @@ class FlutterVersion {
_kVersionCheckRemote,
'https://github.com/flutter/flutter.git',
]);
await _run(<String>['git', 'fetch', _kVersionCheckRemote, 'master']);
return _latestGitCommitDate('$_kVersionCheckRemote/master');
await _run(<String>['git', 'fetch', _kVersionCheckRemote, branch]);
return _latestGitCommitDate('$_kVersionCheckRemote/$branch');
} finally {
await _removeVersionCheckRemoteIfExists();
}
......@@ -243,7 +243,8 @@ class FlutterVersion {
// Cache is empty or it's been a while since the last server ping. Ping the server.
try {
final DateTime remoteFrameworkCommitDate = DateTime.parse(await FlutterVersion.fetchRemoteFrameworkCommitDate());
final String branch = _channel == 'alpha' ? 'alpha' : 'master';
final DateTime remoteFrameworkCommitDate = DateTime.parse(await FlutterVersion.fetchRemoteFrameworkCommitDate(branch));
versionCheckStamp.store(
newTimeVersionWasChecked: _clock.now(),
newKnownRemoteVersion: remoteFrameworkCommitDate,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment