(cleanup) standardize on shouldRunPub and usesPubOptions() in commands (#13427)

packages/flutter_tools/lib/src/commands/create.dart

@@ -28,10 +28,7 @@ import '../version.dart';
 
 class CreateCommand extends FlutterCommand {
   CreateCommand() {
-    argParser.addFlag('pub',
-      defaultsTo: true,
-      help: 'Whether to run "flutter packages get" after the project has been created.'
-    );
+    usesPubOption();
     argParser.addFlag(
       'with-driver-test',
       negatable: true,
@@ -161,7 +158,7 @@ class CreateCommand extends FlutterCommand {
       templateContext['description'] = description;
       generatedCount += _renderTemplate('package', dirPath, templateContext);
 
-      if (argResults['pub'])
+      if (shouldRunPub)
         await pubGet(context: PubContext.createPackage, directory: dirPath);
 
       final String relativePath = fs.path.relative(dirPath);
@@ -179,7 +176,7 @@ class CreateCommand extends FlutterCommand {
       templateContext['description'] = description;
       generatedCount += _renderTemplate('plugin', dirPath, templateContext);
 
-      if (argResults['pub'])
+      if (shouldRunPub)
         await pubGet(context: PubContext.createPlugin, directory: dirPath);
 
       if (android_sdk.androidSdk != null)
@@ -217,7 +214,7 @@ class CreateCommand extends FlutterCommand {
       previewDart2: false,
     );
 
-    if (argResults['pub']) {
+    if (shouldRunPub) {
       await pubGet(context: PubContext.create, directory: appPath);
       injectPlugins(directory: appPath);
     }

packages/flutter_tools/lib/src/runner/flutter_command.dart

@@ -362,7 +362,7 @@ abstract class FlutterCommand extends Command<Null> {
       }
 
       // Validate the current package map only if we will not be running "pub get" later.
-      if (parent?.name != 'packages' && !(_usesPubOption && argResults['pub'])) {
+      if (parent?.name != 'packages' && !shouldRunPub) {
         final String error = new PackageMap(PackageMap.globalPackagesPath).checkValid();
         if (error != null)
           throw new ToolExit(error);