Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
924ab725
Commit
924ab725
authored
Nov 09, 2019
by
Alex Fourman
Committed by
Shi-Hao Hong
Nov 09, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix AboutListTile having an empty icon placeholder when no icon set. (#43422)
parent
8ad7456c
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
21 additions
and
1 deletion
+21
-1
about.dart
packages/flutter/lib/src/material/about.dart
+1
-1
about_test.dart
packages/flutter/test/material/about_test.dart
+20
-0
No files found.
packages/flutter/lib/src/material/about.dart
View file @
924ab725
...
...
@@ -112,7 +112,7 @@ class AboutListTile extends StatelessWidget {
/// values default to the empty string.
const
AboutListTile
({
Key
key
,
this
.
icon
=
const
Icon
(
null
)
,
this
.
icon
,
this
.
child
,
this
.
applicationName
,
this
.
applicationVersion
,
...
...
packages/flutter/test/material/about_test.dart
View file @
924ab725
...
...
@@ -449,6 +449,26 @@ void main() {
expect
(
rootObserver
.
dialogCount
,
0
);
expect
(
nestedObserver
.
dialogCount
,
1
);
});
testWidgets
(
"AboutListTile's child should not be offset when the icon is not specified."
,
(
WidgetTester
tester
)
async
{
await
tester
.
pumpWidget
(
const
MaterialApp
(
home:
Scaffold
(
body:
AboutListTile
(
child:
Text
(
'About'
),
),
),
),
);
expect
(
find
.
descendant
(
of:
find
.
byType
(
AboutListTile
),
matching:
find
.
byType
(
Icon
),
),
findsNothing
,
);
});
}
class
FakeLicenseEntry
extends
LicenseEntry
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment