Unverified Commit 91e3b2d6 authored by Jonah Williams's avatar Jonah Williams Committed by GitHub

add iOS build benchmarks (#35749)

parent 0e7cfc1e
...@@ -8,5 +8,5 @@ import 'package:flutter_devicelab/framework/framework.dart'; ...@@ -8,5 +8,5 @@ import 'package:flutter_devicelab/framework/framework.dart';
import 'package:flutter_devicelab/tasks/build_benchmarks.dart'; import 'package:flutter_devicelab/tasks/build_benchmarks.dart';
Future<void> main() async { Future<void> main() async {
await task(createBuildbenchmarkTask()); await task(createAndroidBuildBenchmarkTask());
} }
// Copyright 2019 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import 'dart:async';
import 'package:flutter_devicelab/framework/framework.dart';
import 'package:flutter_devicelab/tasks/build_benchmarks.dart';
Future<void> main() async {
await task(createIosBuildBenchmarkTask());
}
...@@ -10,20 +10,32 @@ import 'package:path/path.dart' as path; ...@@ -10,20 +10,32 @@ import 'package:path/path.dart' as path;
final Directory helloWorldDir = dir(path.join(flutterDirectory.path, 'examples', 'hello_world')); final Directory helloWorldDir = dir(path.join(flutterDirectory.path, 'examples', 'hello_world'));
/// Creates a device lab build benchmark. /// Creates a devicelab build benchmark for Android.
TaskFunction createBuildbenchmarkTask() { TaskFunction createAndroidBuildBenchmarkTask() {
return () async { return () async {
return createBuildCommand('apk');
};
}
/// Creates a devicelab build benchmark for iOS.
TaskFunction createIosBuildBenchmarkTask() {
return () async {
return createBuildCommand('ios');
};
}
Future<TaskResult> createBuildCommand(String buildKind) {
return inDirectory<TaskResult>(helloWorldDir, () async { return inDirectory<TaskResult>(helloWorldDir, () async {
final Stopwatch stopwatch = Stopwatch() final Stopwatch stopwatch = Stopwatch()
..start(); ..start();
final Process initialBuild = await startProcess( final Process initialBuild = await startProcess(
path.join(flutterDirectory.path, 'bin', 'flutter'), path.join(flutterDirectory.path, 'bin', 'flutter'),
<String>['build', 'apk', '--debug'], <String>['build', buildKind, '--debug'],
environment: null, environment: null,
); );
int exitCode = await initialBuild.exitCode; int exitCode = await initialBuild.exitCode;
if (exitCode != 0) { if (exitCode != 0) {
return TaskResult.failure('Failed to build debug APK'); return TaskResult.failure('Failed to build debug app');
} }
final int initialBuildMilliseconds = stopwatch.elapsedMilliseconds; final int initialBuildMilliseconds = stopwatch.elapsedMilliseconds;
stopwatch stopwatch
...@@ -31,34 +43,34 @@ TaskFunction createBuildbenchmarkTask() { ...@@ -31,34 +43,34 @@ TaskFunction createBuildbenchmarkTask() {
..start(); ..start();
final Process secondBuild = await startProcess( final Process secondBuild = await startProcess(
path.join(flutterDirectory.path, 'bin', 'flutter'), path.join(flutterDirectory.path, 'bin', 'flutter'),
<String>['build', 'apk', '--debug'], <String>['build', buildKind, '--debug'],
environment: null, environment: null,
); );
exitCode = await secondBuild.exitCode; exitCode = await secondBuild.exitCode;
if (exitCode != 0) { if (exitCode != 0) {
return TaskResult.failure('Failed to build debug APK'); return TaskResult.failure('Failed to build debug app');
} }
final int secondBuildMilliseconds = stopwatch.elapsedMilliseconds; final int secondBuildMilliseconds = stopwatch.elapsedMilliseconds;
final Process newBuildConfig = await startProcess( final Process newBuildConfig = await startProcess(
path.join(flutterDirectory.path, 'bin', 'flutter'), path.join(flutterDirectory.path, 'bin', 'flutter'),
<String>['build', 'apk', '--profile'], <String>['build', buildKind, '--profile'],
environment: null, environment: null,
); );
exitCode = await newBuildConfig.exitCode; exitCode = await newBuildConfig.exitCode;
if (exitCode != 0) { if (exitCode != 0) {
return TaskResult.failure('Failed to build profile APK'); return TaskResult.failure('Failed to build profile app');
} }
stopwatch stopwatch
..reset() ..reset()
..start(); ..start();
final Process thirdBuild = await startProcess( final Process thirdBuild = await startProcess(
path.join(flutterDirectory.path, 'bin', 'flutter'), path.join(flutterDirectory.path, 'bin', 'flutter'),
<String>['build', 'apk', '--debug'], <String>['build', buildKind, '--debug'],
environment: null, environment: null,
); );
exitCode = await thirdBuild.exitCode; exitCode = await thirdBuild.exitCode;
if (exitCode != 0) { if (exitCode != 0) {
return TaskResult.failure('Failed to build debug APK'); return TaskResult.failure('Failed to build debug app');
} }
final int thirdBuildMilliseconds = stopwatch.elapsedMilliseconds; final int thirdBuildMilliseconds = stopwatch.elapsedMilliseconds;
stopwatch.stop(); stopwatch.stop();
...@@ -68,5 +80,4 @@ TaskFunction createBuildbenchmarkTask() { ...@@ -68,5 +80,4 @@ TaskFunction createBuildbenchmarkTask() {
allResults['after_config_change_build_debug_millis'] = thirdBuildMilliseconds.toDouble(); allResults['after_config_change_build_debug_millis'] = thirdBuildMilliseconds.toDouble();
return TaskResult.success(allResults, benchmarkScoreKeys: allResults.keys.toList()); return TaskResult.success(allResults, benchmarkScoreKeys: allResults.keys.toList());
}); });
};
} }
...@@ -489,6 +489,13 @@ tasks: ...@@ -489,6 +489,13 @@ tasks:
required_agent_capabilities: ["mac/ios"] required_agent_capabilities: ["mac/ios"]
flaky: true flaky: true
build_benchmark_ios:
description: >
Measures iOS build performance across config changes.
stage: devicelab_ios
required_agent_capabilities: ["mac/ios"]
flaky: true
# Tests running on Windows host # Tests running on Windows host
flavors_test_win: flavors_test_win:
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment