Commit 91a783bf authored by Adam Barth's avatar Adam Barth

Rename Widget.root to Widget.renderObject

The name `root` is confusing because this value isn't the root of anything.
It's just the associated `RenderObject` instance.
parent 46fc8e6a
...@@ -24,14 +24,14 @@ class SpriteWidget extends OneChildRenderObjectWrapper { ...@@ -24,14 +24,14 @@ class SpriteWidget extends OneChildRenderObjectWrapper {
/// var mySpriteWidget = new SpriteWidget(mySpriteTree, SpriteBoxTransformMode.fixedHeight); /// var mySpriteWidget = new SpriteWidget(mySpriteTree, SpriteBoxTransformMode.fixedHeight);
SpriteWidget(this.rootNode, [this.transformMode = SpriteBoxTransformMode.letterbox]); SpriteWidget(this.rootNode, [this.transformMode = SpriteBoxTransformMode.letterbox]);
SpriteBox get root => super.root; SpriteBox get renderObject => super.renderObject;
SpriteBox createNode() => new SpriteBox(rootNode, transformMode); SpriteBox createNode() => new SpriteBox(rootNode, transformMode);
void syncRenderObject(SpriteWidget old) { void syncRenderObject(SpriteWidget old) {
super.syncRenderObject(old); super.syncRenderObject(old);
root.rootNode = rootNode; renderObject.rootNode = rootNode;
root.transformMode = transformMode; renderObject.transformMode = transformMode;
} }
} }
...@@ -115,7 +115,7 @@ class OverlayGeometryApp extends App { ...@@ -115,7 +115,7 @@ class OverlayGeometryApp extends App {
setState(() { setState(() {
markers[MarkerType.touch] = new Point(event.x, event.y); markers[MarkerType.touch] = new Point(event.x, event.y);
markers[MarkerType.topLeft] = target.localToGlobal(new Point(0.0, 0.0)); markers[MarkerType.topLeft] = target.localToGlobal(new Point(0.0, 0.0));
Size size = (target.root as RenderBox).size; Size size = (target.renderObject as RenderBox).size;
markers[MarkerType.bottomRight] = target.localToGlobal(new Point(size.width, size.height)); markers[MarkerType.bottomRight] = target.localToGlobal(new Point(size.width, size.height));
Scrollable scrollable = findScrollableAncestor(target: target); Scrollable scrollable = findScrollableAncestor(target: target);
......
...@@ -37,11 +37,11 @@ class Opacity extends OneChildRenderObjectWrapper { ...@@ -37,11 +37,11 @@ class Opacity extends OneChildRenderObjectWrapper {
final double opacity; final double opacity;
RenderOpacity createNode() => new RenderOpacity(opacity: opacity); RenderOpacity createNode() => new RenderOpacity(opacity: opacity);
RenderOpacity get root => super.root; RenderOpacity get renderObject => super.renderObject;
void syncRenderObject(Opacity old) { void syncRenderObject(Opacity old) {
super.syncRenderObject(old); super.syncRenderObject(old);
root.opacity = opacity; renderObject.opacity = opacity;
} }
} }
...@@ -53,12 +53,12 @@ class ColorFilter extends OneChildRenderObjectWrapper { ...@@ -53,12 +53,12 @@ class ColorFilter extends OneChildRenderObjectWrapper {
final sky.TransferMode transferMode; final sky.TransferMode transferMode;
RenderColorFilter createNode() => new RenderColorFilter(color: color, transferMode: transferMode); RenderColorFilter createNode() => new RenderColorFilter(color: color, transferMode: transferMode);
RenderColorFilter get root => super.root; RenderColorFilter get renderObject => super.renderObject;
void syncRenderObject(ColorFilter old) { void syncRenderObject(ColorFilter old) {
super.syncRenderObject(old); super.syncRenderObject(old);
root.color = color; renderObject.color = color;
root.transferMode = transferMode; renderObject.transferMode = transferMode;
} }
} }
...@@ -69,11 +69,11 @@ class DecoratedBox extends OneChildRenderObjectWrapper { ...@@ -69,11 +69,11 @@ class DecoratedBox extends OneChildRenderObjectWrapper {
final BoxDecoration decoration; final BoxDecoration decoration;
RenderDecoratedBox createNode() => new RenderDecoratedBox(decoration: decoration); RenderDecoratedBox createNode() => new RenderDecoratedBox(decoration: decoration);
RenderDecoratedBox get root => super.root; RenderDecoratedBox get renderObject => super.renderObject;
void syncRenderObject(DecoratedBox old) { void syncRenderObject(DecoratedBox old) {
super.syncRenderObject(old); super.syncRenderObject(old);
root.decoration = decoration; renderObject.decoration = decoration;
} }
} }
...@@ -85,17 +85,17 @@ class CustomPaint extends OneChildRenderObjectWrapper { ...@@ -85,17 +85,17 @@ class CustomPaint extends OneChildRenderObjectWrapper {
final dynamic token; // set this to be repainted automatically when the token changes final dynamic token; // set this to be repainted automatically when the token changes
RenderCustomPaint createNode() => new RenderCustomPaint(callback: callback); RenderCustomPaint createNode() => new RenderCustomPaint(callback: callback);
RenderCustomPaint get root => super.root; RenderCustomPaint get renderObject => super.renderObject;
void syncRenderObject(CustomPaint old) { void syncRenderObject(CustomPaint old) {
super.syncRenderObject(old); super.syncRenderObject(old);
if (old != null && old.token != token) if (old != null && old.token != token)
root.markNeedsPaint(); renderObject.markNeedsPaint();
root.callback = callback; renderObject.callback = callback;
} }
void remove() { void remove() {
root.callback = null; renderObject.callback = null;
super.remove(); super.remove();
} }
} }
...@@ -105,7 +105,7 @@ class ClipRect extends OneChildRenderObjectWrapper { ...@@ -105,7 +105,7 @@ class ClipRect extends OneChildRenderObjectWrapper {
: super(key: key, child: child); : super(key: key, child: child);
RenderClipRect createNode() => new RenderClipRect(); RenderClipRect createNode() => new RenderClipRect();
RenderClipRect get root => super.root; RenderClipRect get renderObject => super.renderObject;
// Nothing to sync, so we don't implement syncRenderObject() // Nothing to sync, so we don't implement syncRenderObject()
} }
...@@ -118,12 +118,12 @@ class ClipRRect extends OneChildRenderObjectWrapper { ...@@ -118,12 +118,12 @@ class ClipRRect extends OneChildRenderObjectWrapper {
final double yRadius; final double yRadius;
RenderClipRRect createNode() => new RenderClipRRect(xRadius: xRadius, yRadius: yRadius); RenderClipRRect createNode() => new RenderClipRRect(xRadius: xRadius, yRadius: yRadius);
RenderClipRRect get root => super.root; RenderClipRRect get renderObject => super.renderObject;
void syncRenderObject(ClipRRect old) { void syncRenderObject(ClipRRect old) {
super.syncRenderObject(old); super.syncRenderObject(old);
root.xRadius = xRadius; renderObject.xRadius = xRadius;
root.yRadius = yRadius; renderObject.yRadius = yRadius;
} }
} }
...@@ -132,7 +132,7 @@ class ClipOval extends OneChildRenderObjectWrapper { ...@@ -132,7 +132,7 @@ class ClipOval extends OneChildRenderObjectWrapper {
: super(key: key, child: child); : super(key: key, child: child);
RenderClipOval createNode() => new RenderClipOval(); RenderClipOval createNode() => new RenderClipOval();
RenderClipOval get root => super.root; RenderClipOval get renderObject => super.renderObject;
// Nothing to sync, so we don't implement syncRenderObject() // Nothing to sync, so we don't implement syncRenderObject()
} }
...@@ -147,11 +147,11 @@ class Transform extends OneChildRenderObjectWrapper { ...@@ -147,11 +147,11 @@ class Transform extends OneChildRenderObjectWrapper {
final Matrix4 transform; final Matrix4 transform;
RenderTransform createNode() => new RenderTransform(transform: transform); RenderTransform createNode() => new RenderTransform(transform: transform);
RenderTransform get root => super.root; RenderTransform get renderObject => super.renderObject;
void syncRenderObject(Transform old) { void syncRenderObject(Transform old) {
super.syncRenderObject(old); super.syncRenderObject(old);
root.transform = transform; renderObject.transform = transform;
} }
} }
...@@ -162,11 +162,11 @@ class Padding extends OneChildRenderObjectWrapper { ...@@ -162,11 +162,11 @@ class Padding extends OneChildRenderObjectWrapper {
final EdgeDims padding; final EdgeDims padding;
RenderPadding createNode() => new RenderPadding(padding: padding); RenderPadding createNode() => new RenderPadding(padding: padding);
RenderPadding get root => super.root; RenderPadding get renderObject => super.renderObject;
void syncRenderObject(Padding old) { void syncRenderObject(Padding old) {
super.syncRenderObject(old); super.syncRenderObject(old);
root.padding = padding; renderObject.padding = padding;
} }
} }
...@@ -175,7 +175,7 @@ class Center extends OneChildRenderObjectWrapper { ...@@ -175,7 +175,7 @@ class Center extends OneChildRenderObjectWrapper {
: super(key: key, child: child); : super(key: key, child: child);
RenderPositionedBox createNode() => new RenderPositionedBox(); RenderPositionedBox createNode() => new RenderPositionedBox();
RenderPositionedBox get root => super.root; RenderPositionedBox get renderObject => super.renderObject;
// Nothing to sync, so we don't implement syncRenderObject() // Nothing to sync, so we don't implement syncRenderObject()
} }
...@@ -188,7 +188,7 @@ class SizedBox extends OneChildRenderObjectWrapper { ...@@ -188,7 +188,7 @@ class SizedBox extends OneChildRenderObjectWrapper {
final double height; final double height;
RenderConstrainedBox createNode() => new RenderConstrainedBox(additionalConstraints: _additionalConstraints()); RenderConstrainedBox createNode() => new RenderConstrainedBox(additionalConstraints: _additionalConstraints());
RenderConstrainedBox get root => super.root; RenderConstrainedBox get renderObject => super.renderObject;
BoxConstraints _additionalConstraints() { BoxConstraints _additionalConstraints() {
BoxConstraints result = const BoxConstraints(); BoxConstraints result = const BoxConstraints();
...@@ -201,7 +201,7 @@ class SizedBox extends OneChildRenderObjectWrapper { ...@@ -201,7 +201,7 @@ class SizedBox extends OneChildRenderObjectWrapper {
void syncRenderObject(SizedBox old) { void syncRenderObject(SizedBox old) {
super.syncRenderObject(old); super.syncRenderObject(old);
root.additionalConstraints = _additionalConstraints(); renderObject.additionalConstraints = _additionalConstraints();
} }
} }
...@@ -212,11 +212,11 @@ class ConstrainedBox extends OneChildRenderObjectWrapper { ...@@ -212,11 +212,11 @@ class ConstrainedBox extends OneChildRenderObjectWrapper {
final BoxConstraints constraints; final BoxConstraints constraints;
RenderConstrainedBox createNode() => new RenderConstrainedBox(additionalConstraints: constraints); RenderConstrainedBox createNode() => new RenderConstrainedBox(additionalConstraints: constraints);
RenderConstrainedBox get root => super.root; RenderConstrainedBox get renderObject => super.renderObject;
void syncRenderObject(ConstrainedBox old) { void syncRenderObject(ConstrainedBox old) {
super.syncRenderObject(old); super.syncRenderObject(old);
root.additionalConstraints = constraints; renderObject.additionalConstraints = constraints;
} }
} }
...@@ -227,11 +227,11 @@ class AspectRatio extends OneChildRenderObjectWrapper { ...@@ -227,11 +227,11 @@ class AspectRatio extends OneChildRenderObjectWrapper {
final double aspectRatio; final double aspectRatio;
RenderAspectRatio createNode() => new RenderAspectRatio(aspectRatio: aspectRatio); RenderAspectRatio createNode() => new RenderAspectRatio(aspectRatio: aspectRatio);
RenderAspectRatio get root => super.root; RenderAspectRatio get renderObject => super.renderObject;
void syncRenderObject(AspectRatio old) { void syncRenderObject(AspectRatio old) {
super.syncRenderObject(old); super.syncRenderObject(old);
root.aspectRatio = aspectRatio; renderObject.aspectRatio = aspectRatio;
} }
} }
...@@ -243,12 +243,12 @@ class ShrinkWrapWidth extends OneChildRenderObjectWrapper { ...@@ -243,12 +243,12 @@ class ShrinkWrapWidth extends OneChildRenderObjectWrapper {
final double stepHeight; final double stepHeight;
RenderShrinkWrapWidth createNode() => new RenderShrinkWrapWidth(); RenderShrinkWrapWidth createNode() => new RenderShrinkWrapWidth();
RenderShrinkWrapWidth get root => super.root; RenderShrinkWrapWidth get renderObject => super.renderObject;
void syncRenderObject(ShrinkWrapWidth old) { void syncRenderObject(ShrinkWrapWidth old) {
super.syncRenderObject(old); super.syncRenderObject(old);
root.stepWidth = stepWidth; renderObject.stepWidth = stepWidth;
root.stepHeight = stepHeight; renderObject.stepHeight = stepHeight;
} }
} }
...@@ -260,12 +260,12 @@ class Baseline extends OneChildRenderObjectWrapper { ...@@ -260,12 +260,12 @@ class Baseline extends OneChildRenderObjectWrapper {
final TextBaseline baselineType; final TextBaseline baselineType;
RenderBaseline createNode() => new RenderBaseline(baseline: baseline, baselineType: baselineType); RenderBaseline createNode() => new RenderBaseline(baseline: baseline, baselineType: baselineType);
RenderBaseline get root => super.root; RenderBaseline get renderObject => super.renderObject;
void syncRenderObject(Baseline old) { void syncRenderObject(Baseline old) {
super.syncRenderObject(old); super.syncRenderObject(old);
root.baseline = baseline; renderObject.baseline = baseline;
root.baselineType = baselineType; renderObject.baselineType = baselineType;
} }
} }
...@@ -281,12 +281,12 @@ class Viewport extends OneChildRenderObjectWrapper { ...@@ -281,12 +281,12 @@ class Viewport extends OneChildRenderObjectWrapper {
final ScrollDirection scrollDirection; final ScrollDirection scrollDirection;
RenderViewport createNode() => new RenderViewport(scrollOffset: scrollOffset, scrollDirection: scrollDirection); RenderViewport createNode() => new RenderViewport(scrollOffset: scrollOffset, scrollDirection: scrollDirection);
RenderViewport get root => super.root; RenderViewport get renderObject => super.renderObject;
void syncRenderObject(Viewport old) { void syncRenderObject(Viewport old) {
super.syncRenderObject(old); super.syncRenderObject(old);
root.scrollOffset = scrollOffset; renderObject.scrollOffset = scrollOffset;
root.scrollDirection = scrollDirection; renderObject.scrollDirection = scrollDirection;
} }
} }
...@@ -297,15 +297,15 @@ class SizeObserver extends OneChildRenderObjectWrapper { ...@@ -297,15 +297,15 @@ class SizeObserver extends OneChildRenderObjectWrapper {
final SizeChangedCallback callback; final SizeChangedCallback callback;
RenderSizeObserver createNode() => new RenderSizeObserver(callback: callback); RenderSizeObserver createNode() => new RenderSizeObserver(callback: callback);
RenderSizeObserver get root => super.root; RenderSizeObserver get renderObject => super.renderObject;
void syncRenderObject(SizeObserver old) { void syncRenderObject(SizeObserver old) {
super.syncRenderObject(old); super.syncRenderObject(old);
root.callback = callback; renderObject.callback = callback;
} }
void remove() { void remove() {
root.callback = null; renderObject.callback = null;
super.remove(); super.remove();
} }
} }
...@@ -381,11 +381,11 @@ class Block extends MultiChildRenderObjectWrapper { ...@@ -381,11 +381,11 @@ class Block extends MultiChildRenderObjectWrapper {
final BlockDirection direction; final BlockDirection direction;
RenderBlock createNode() => new RenderBlock(direction: direction); RenderBlock createNode() => new RenderBlock(direction: direction);
RenderBlock get root => super.root; RenderBlock get renderObject => super.renderObject;
void syncRenderObject(Widget old) { void syncRenderObject(Widget old) {
super.syncRenderObject(old); super.syncRenderObject(old);
root.direction = direction; renderObject.direction = direction;
} }
} }
...@@ -394,7 +394,7 @@ class Stack extends MultiChildRenderObjectWrapper { ...@@ -394,7 +394,7 @@ class Stack extends MultiChildRenderObjectWrapper {
: super(key: key, children: children); : super(key: key, children: children);
RenderStack createNode() => new RenderStack(); RenderStack createNode() => new RenderStack();
RenderStack get root => super.root; RenderStack get renderObject => super.renderObject;
} }
class Positioned extends ParentDataNode { class Positioned extends ParentDataNode {
...@@ -429,14 +429,14 @@ class Flex extends MultiChildRenderObjectWrapper { ...@@ -429,14 +429,14 @@ class Flex extends MultiChildRenderObjectWrapper {
final TextBaseline textBaseline; final TextBaseline textBaseline;
RenderFlex createNode() => new RenderFlex(direction: direction); RenderFlex createNode() => new RenderFlex(direction: direction);
RenderFlex get root => super.root; RenderFlex get renderObject => super.renderObject;
void syncRenderObject(Widget old) { void syncRenderObject(Widget old) {
super.syncRenderObject(old); super.syncRenderObject(old);
root.direction = direction; renderObject.direction = direction;
root.justifyContent = justifyContent; renderObject.justifyContent = justifyContent;
root.alignItems = alignItems; renderObject.alignItems = alignItems;
root.textBaseline = textBaseline; renderObject.textBaseline = textBaseline;
} }
} }
...@@ -452,11 +452,11 @@ class Paragraph extends LeafRenderObjectWrapper { ...@@ -452,11 +452,11 @@ class Paragraph extends LeafRenderObjectWrapper {
final TextSpan text; final TextSpan text;
RenderParagraph createNode() => new RenderParagraph(text); RenderParagraph createNode() => new RenderParagraph(text);
RenderParagraph get root => super.root; RenderParagraph get renderObject => super.renderObject;
void syncRenderObject(Widget old) { void syncRenderObject(Widget old) {
super.syncRenderObject(old); super.syncRenderObject(old);
root.text = text; renderObject.text = text;
} }
} }
...@@ -520,14 +520,14 @@ class Image extends LeafRenderObjectWrapper { ...@@ -520,14 +520,14 @@ class Image extends LeafRenderObjectWrapper {
final sky.ColorFilter colorFilter; final sky.ColorFilter colorFilter;
RenderImage createNode() => new RenderImage(image: image, width: width, height: height, colorFilter: colorFilter); RenderImage createNode() => new RenderImage(image: image, width: width, height: height, colorFilter: colorFilter);
RenderImage get root => super.root; RenderImage get renderObject => super.renderObject;
void syncRenderObject(Widget old) { void syncRenderObject(Widget old) {
super.syncRenderObject(old); super.syncRenderObject(old);
root.image = image; renderObject.image = image;
root.width = width; renderObject.width = width;
root.height = height; renderObject.height = height;
root.colorFilter = colorFilter; renderObject.colorFilter = colorFilter;
} }
} }
...@@ -626,20 +626,20 @@ class WidgetToRenderBoxAdapter extends LeafRenderObjectWrapper { ...@@ -626,20 +626,20 @@ class WidgetToRenderBoxAdapter extends LeafRenderObjectWrapper {
final RenderBox renderBox; final RenderBox renderBox;
RenderBox createNode() => this.renderBox; RenderBox createNode() => this.renderBox;
RenderBox get root => super.root; RenderBox get renderObject => super.renderObject;
void syncRenderObject(Widget old) { void syncRenderObject(Widget old) {
super.syncRenderObject(old); super.syncRenderObject(old);
if (old != null) { if (old != null) {
assert(old is WidgetToRenderBoxAdapter); assert(old is WidgetToRenderBoxAdapter);
assert(root == old.root); assert(renderObject == old.renderObject);
} }
} }
void remove() { void remove() {
RenderObjectWrapper ancestor = findAncestorRenderObjectWrapper(); RenderObjectWrapper ancestor = findAncestorRenderObjectWrapper();
assert(ancestor is RenderObjectWrapper); assert(ancestor is RenderObjectWrapper);
assert(ancestor.root == root.parent); assert(ancestor.renderObject == renderObject.parent);
ancestor.detachChildRoot(this); ancestor.detachChildRoot(this);
super.remove(); super.remove();
} }
...@@ -652,5 +652,5 @@ class IgnorePointer extends OneChildRenderObjectWrapper { ...@@ -652,5 +652,5 @@ class IgnorePointer extends OneChildRenderObjectWrapper {
IgnorePointer({ Key key, Widget child }) IgnorePointer({ Key key, Widget child })
: super(key: key, child: child); : super(key: key, child: child);
RenderIgnorePointer createNode() => new RenderIgnorePointer(); RenderIgnorePointer createNode() => new RenderIgnorePointer();
RenderIgnorePointer get root => super.root; RenderIgnorePointer get renderObject => super.renderObject;
} }
...@@ -88,7 +88,7 @@ class BlockViewport extends RenderObjectWrapper { ...@@ -88,7 +88,7 @@ class BlockViewport extends RenderObjectWrapper {
Object token; Object token;
BlockViewportLayoutState layoutState; BlockViewportLayoutState layoutState;
RenderBlockViewport get root => super.root; RenderBlockViewport get renderObject => super.renderObject;
RenderBlockViewport createNode() => new RenderBlockViewport(); RenderBlockViewport createNode() => new RenderBlockViewport();
void walkChildren(WidgetTreeWalker walker) { void walkChildren(WidgetTreeWalker walker) {
...@@ -101,20 +101,20 @@ class BlockViewport extends RenderObjectWrapper { ...@@ -101,20 +101,20 @@ class BlockViewport extends RenderObjectWrapper {
void insertChildRoot(RenderObjectWrapper child, dynamic slot) { void insertChildRoot(RenderObjectWrapper child, dynamic slot) {
if (slot == _omit) if (slot == _omit)
return; return;
final root = this.root; // TODO(ianh): Remove this once the analyzer is cleverer final renderObject = this.renderObject; // TODO(ianh): Remove this once the analyzer is cleverer
assert(slot == null || slot is RenderObject); assert(slot == null || slot is RenderObject);
assert(root is ContainerRenderObjectMixin); assert(renderObject is ContainerRenderObjectMixin);
root.add(child.root, before: slot); renderObject.add(child.renderObject, before: slot);
assert(root == this.root); // TODO(ianh): Remove this once the analyzer is cleverer assert(renderObject == this.renderObject); // TODO(ianh): Remove this once the analyzer is cleverer
} }
void detachChildRoot(RenderObjectWrapper child) { void detachChildRoot(RenderObjectWrapper child) {
final root = this.root; // TODO(ianh): Remove this once the analyzer is cleverer final renderObject = this.renderObject; // TODO(ianh): Remove this once the analyzer is cleverer
assert(root is ContainerRenderObjectMixin); assert(renderObject is ContainerRenderObjectMixin);
if (child.root.parent != root) if (child.renderObject.parent != renderObject)
return; // probably had slot == _omit when inserted return; // probably had slot == _omit when inserted
root.remove(child.root); renderObject.remove(child.renderObject);
assert(root == this.root); // TODO(ianh): Remove this once the analyzer is cleverer assert(renderObject == this.renderObject); // TODO(ianh): Remove this once the analyzer is cleverer
} }
void remove() { void remove() {
...@@ -126,12 +126,12 @@ class BlockViewport extends RenderObjectWrapper { ...@@ -126,12 +126,12 @@ class BlockViewport extends RenderObjectWrapper {
} }
void didMount() { void didMount() {
root.callback = layout; renderObject.callback = layout;
super.didMount(); super.didMount();
} }
void didUnmount() { void didUnmount() {
root.callback = null; renderObject.callback = null;
super.didUnmount(); super.didUnmount();
} }
...@@ -173,12 +173,12 @@ class BlockViewport extends RenderObjectWrapper { ...@@ -173,12 +173,12 @@ class BlockViewport extends RenderObjectWrapper {
void syncRenderObject(BlockViewport old) { void syncRenderObject(BlockViewport old) {
super.syncRenderObject(old); super.syncRenderObject(old);
if (layoutState._dirty || !layoutState.isValid) { if (layoutState._dirty || !layoutState.isValid) {
root.markNeedsLayout(); renderObject.markNeedsLayout();
} else { } else {
if (layoutState._visibleChildCount > 0) { if (layoutState._visibleChildCount > 0) {
assert(layoutState.firstVisibleChildIndex >= 0); assert(layoutState.firstVisibleChildIndex >= 0);
assert(builder != null); assert(builder != null);
assert(root != null); assert(renderObject != null);
final int startIndex = layoutState._firstVisibleChildIndex; final int startIndex = layoutState._firstVisibleChildIndex;
int lastIndex = startIndex + layoutState._visibleChildCount - 1; int lastIndex = startIndex + layoutState._visibleChildCount - 1;
for (int index = startIndex; index <= lastIndex; index += 1) { for (int index = startIndex; index <= lastIndex; index += 1) {
...@@ -188,8 +188,8 @@ class BlockViewport extends RenderObjectWrapper { ...@@ -188,8 +188,8 @@ class BlockViewport extends RenderObjectWrapper {
_Key key = new _Key.fromWidget(widget); _Key key = new _Key.fromWidget(widget);
Widget oldWidget = layoutState._childrenByKey[key]; Widget oldWidget = layoutState._childrenByKey[key];
assert(oldWidget != null); assert(oldWidget != null);
assert(oldWidget.root.parent == root); assert(oldWidget.renderObject.parent == renderObject);
widget = syncChild(widget, oldWidget, root.childAfter(oldWidget.root)); widget = syncChild(widget, oldWidget, renderObject.childAfter(oldWidget.renderObject));
assert(widget != null); assert(widget != null);
layoutState._childrenByKey[key] = widget; layoutState._childrenByKey[key] = widget;
} }
...@@ -214,7 +214,7 @@ class BlockViewport extends RenderObjectWrapper { ...@@ -214,7 +214,7 @@ class BlockViewport extends RenderObjectWrapper {
newWidget = syncChild(newWidget, oldWidget, _omit); newWidget = syncChild(newWidget, oldWidget, _omit);
assert(newWidget != null); assert(newWidget != null);
// Update the offsets based on the newWidget's height. // Update the offsets based on the newWidget's height.
RenderBox widgetRoot = newWidget.root; RenderBox widgetRoot = newWidget.renderObject;
assert(widgetRoot is RenderBox); assert(widgetRoot is RenderBox);
double newHeight = widgetRoot.getMaxIntrinsicHeight(innerConstraints); double newHeight = widgetRoot.getMaxIntrinsicHeight(innerConstraints);
double oldHeight = offsets[index + 1] - offsets[index]; double oldHeight = offsets[index + 1] - offsets[index];
...@@ -237,7 +237,7 @@ class BlockViewport extends RenderObjectWrapper { ...@@ -237,7 +237,7 @@ class BlockViewport extends RenderObjectWrapper {
if (index >= offsets.length - 1) { if (index >= offsets.length - 1) {
assert(index == offsets.length - 1); assert(index == offsets.length - 1);
final double widgetStartOffset = offsets[index]; final double widgetStartOffset = offsets[index];
RenderBox widgetRoot = widget.root; RenderBox widgetRoot = widget.renderObject;
assert(widgetRoot is RenderBox); assert(widgetRoot is RenderBox);
final double widgetEndOffset = widgetStartOffset + widgetRoot.getMaxIntrinsicHeight(innerConstraints); final double widgetEndOffset = widgetStartOffset + widgetRoot.getMaxIntrinsicHeight(innerConstraints);
offsets.add(widgetEndOffset); offsets.add(widgetEndOffset);
...@@ -266,7 +266,7 @@ class BlockViewport extends RenderObjectWrapper { ...@@ -266,7 +266,7 @@ class BlockViewport extends RenderObjectWrapper {
final List<double> offsets = layoutState._childOffsets; final List<double> offsets = layoutState._childOffsets;
final Map<_Key, Widget> childrenByKey = layoutState._childrenByKey; final Map<_Key, Widget> childrenByKey = layoutState._childrenByKey;
final double height = root.size.height; final double height = renderObject.size.height;
final double endOffset = startOffset + height; final double endOffset = startOffset + height;
BoxConstraints innerConstraints = new BoxConstraints.tightFor(width: constraints.constrainWidth()); BoxConstraints innerConstraints = new BoxConstraints.tightFor(width: constraints.constrainWidth());
...@@ -362,7 +362,7 @@ class BlockViewport extends RenderObjectWrapper { ...@@ -362,7 +362,7 @@ class BlockViewport extends RenderObjectWrapper {
int index = startIndex; int index = startIndex;
if (haveChildren) { if (haveChildren) {
// Build all the widgets we need. // Build all the widgets we need.
root.startOffset = offsets[index] - startOffset; renderObject.startOffset = offsets[index] - startOffset;
while (offsets[index] < endOffset) { while (offsets[index] < endOffset) {
if (!builtChildren.containsKey(index)) { if (!builtChildren.containsKey(index)) {
Widget widget = _getWidget(index, innerConstraints); Widget widget = _getWidget(index, innerConstraints);
...@@ -392,14 +392,14 @@ class BlockViewport extends RenderObjectWrapper { ...@@ -392,14 +392,14 @@ class BlockViewport extends RenderObjectWrapper {
while (index > startIndex) { while (index > startIndex) {
index -= 1; index -= 1;
Widget widget = builtChildren[index]; Widget widget = builtChildren[index];
if (widget.root.parent == root) { if (widget.renderObject.parent == renderObject) {
root.move(widget.root, before: nextSibling); renderObject.move(widget.renderObject, before: nextSibling);
} else { } else {
assert(widget.root.parent == null); assert(widget.renderObject.parent == null);
root.add(widget.root, before: nextSibling); renderObject.add(widget.renderObject, before: nextSibling);
} }
widget.updateSlot(nextSibling); widget.updateSlot(nextSibling);
nextSibling = widget.root; nextSibling = widget.renderObject;
} }
} }
......
...@@ -64,16 +64,16 @@ class _CheckboxWrapper extends LeafRenderObjectWrapper { ...@@ -64,16 +64,16 @@ class _CheckboxWrapper extends LeafRenderObjectWrapper {
final Color uncheckedColor; final Color uncheckedColor;
final Color accentColor; final Color accentColor;
_RenderCheckbox get root => super.root; _RenderCheckbox get renderObject => super.renderObject;
_RenderCheckbox createNode() => new _RenderCheckbox( _RenderCheckbox createNode() => new _RenderCheckbox(
value: value, uncheckedColor: uncheckedColor, onChanged: onChanged); value: value, uncheckedColor: uncheckedColor, onChanged: onChanged);
void syncRenderObject(_CheckboxWrapper old) { void syncRenderObject(_CheckboxWrapper old) {
super.syncRenderObject(old); super.syncRenderObject(old);
root.value = value; renderObject.value = value;
root.onChanged = onChanged; renderObject.onChanged = onChanged;
root.uncheckedColor = uncheckedColor; renderObject.uncheckedColor = uncheckedColor;
root.accentColor = accentColor; renderObject.accentColor = accentColor;
} }
} }
......
...@@ -248,10 +248,10 @@ abstract class Widget { ...@@ -248,10 +248,10 @@ abstract class Widget {
(key as GlobalKey)._unregister(this); // TODO(ianh): remove cast when analyzer is cleverer (key as GlobalKey)._unregister(this); // TODO(ianh): remove cast when analyzer is cleverer
} }
RenderObject _root; RenderObject _renderObject;
/// The underlying [RenderObject] associated with this [Widget]. /// The underlying [RenderObject] associated with this [Widget].
RenderObject get root => _root; RenderObject get renderObject => _renderObject;
// Subclasses which implements Nodes that become stateful may return true // Subclasses which implements Nodes that become stateful may return true
// if the node has become stateful and should be retained. // if the node has become stateful and should be retained.
...@@ -273,7 +273,7 @@ abstract class Widget { ...@@ -273,7 +273,7 @@ abstract class Widget {
} }
void remove() { void remove() {
_root = null; _renderObject = null;
setParent(null); setParent(null);
} }
...@@ -318,7 +318,7 @@ abstract class Widget { ...@@ -318,7 +318,7 @@ abstract class Widget {
assert(!newNode.mounted); assert(!newNode.mounted);
oldNode.setParent(this); oldNode.setParent(this);
oldNode._sync(newNode, slot); oldNode._sync(newNode, slot);
assert(oldNode.root is RenderObject); assert(oldNode.renderObject is RenderObject);
return oldNode; return oldNode;
} else { } else {
oldNode.setParent(null); oldNode.setParent(null);
...@@ -335,7 +335,7 @@ abstract class Widget { ...@@ -335,7 +335,7 @@ abstract class Widget {
assert(!newNode.mounted); assert(!newNode.mounted);
newNode.setParent(this); newNode.setParent(this);
newNode._sync(oldNode, slot); newNode._sync(oldNode, slot);
assert(newNode.root is RenderObject); assert(newNode.renderObject is RenderObject);
return newNode; return newNode;
} }
...@@ -374,15 +374,15 @@ abstract class Widget { ...@@ -374,15 +374,15 @@ abstract class Widget {
// globalToLocal(). // globalToLocal().
Point globalToLocal(Point point) { Point globalToLocal(Point point) {
assert(mounted); assert(mounted);
assert(root is RenderBox); assert(renderObject is RenderBox);
return (root as RenderBox).globalToLocal(point); return (renderObject as RenderBox).globalToLocal(point);
} }
// See globalToLocal(). // See globalToLocal().
Point localToGlobal(Point point) { Point localToGlobal(Point point) {
assert(mounted); assert(mounted);
assert(root is RenderBox); assert(renderObject is RenderBox);
return (root as RenderBox).localToGlobal(point); return (renderObject as RenderBox).localToGlobal(point);
} }
} }
...@@ -410,9 +410,9 @@ abstract class TagNode extends Widget { ...@@ -410,9 +410,9 @@ abstract class TagNode extends Widget {
Widget oldChild = old == null ? null : (old as TagNode).child; Widget oldChild = old == null ? null : (old as TagNode).child;
child = syncChild(child, oldChild, slot); child = syncChild(child, oldChild, slot);
assert(child.parent == this); assert(child.parent == this);
assert(child.root != null); assert(child.renderObject != null);
_root = child.root; _renderObject = child.renderObject;
assert(_root == root); // in case a subclass reintroduces it assert(_renderObject == renderObject); // in case a subclass reintroduces it
} }
void updateSlot(dynamic newSlot) { void updateSlot(dynamic newSlot) {
...@@ -596,7 +596,7 @@ abstract class Component extends Widget { ...@@ -596,7 +596,7 @@ abstract class Component extends Widget {
void remove() { void remove() {
assert(_built != null); assert(_built != null);
assert(root != null); assert(renderObject != null);
removeChild(_built); removeChild(_built);
_built = null; _built = null;
super.remove(); super.remove();
...@@ -604,7 +604,7 @@ abstract class Component extends Widget { ...@@ -604,7 +604,7 @@ abstract class Component extends Widget {
void detachRoot() { void detachRoot() {
assert(_built != null); assert(_built != null);
assert(root != null); assert(renderObject != null);
_built.detachRoot(); _built.detachRoot();
} }
...@@ -664,15 +664,15 @@ abstract class Component extends Widget { ...@@ -664,15 +664,15 @@ abstract class Component extends Widget {
_isBuilding = false; _isBuilding = false;
_dirty = false; _dirty = false;
_root = _built.root; _renderObject = _built.renderObject;
assert(_root == root); // in case a subclass reintroduces it assert(_renderObject == renderObject); // in case a subclass reintroduces it
assert(root != null); assert(renderObject != null);
} }
void _buildIfDirty() { void _buildIfDirty() {
if (!_dirty || !_mounted) if (!_dirty || !_mounted)
return; return;
assert(root != null); assert(renderObject != null);
_sync(null, _slot); _sync(null, _slot);
} }
...@@ -870,8 +870,8 @@ abstract class RenderObjectWrapper extends Widget { ...@@ -870,8 +870,8 @@ abstract class RenderObjectWrapper extends Widget {
Widget target = RenderObjectWrapper._getMounted(renderObject); Widget target = RenderObjectWrapper._getMounted(renderObject);
if (target == null) if (target == null)
return; return;
RenderObject targetRoot = target.root; RenderObject targetRoot = target.renderObject;
while (target != null && target.root == targetRoot) { while (target != null && target.renderObject == targetRoot) {
yield target; yield target;
target = target.parent; target = target.parent;
} }
...@@ -882,7 +882,7 @@ abstract class RenderObjectWrapper extends Widget { ...@@ -882,7 +882,7 @@ abstract class RenderObjectWrapper extends Widget {
void detachChildRoot(RenderObjectWrapper child); void detachChildRoot(RenderObjectWrapper child);
void retainStatefulRenderObjectWrapper(RenderObjectWrapper newNode) { void retainStatefulRenderObjectWrapper(RenderObjectWrapper newNode) {
newNode._root = _root; newNode._renderObject = _renderObject;
newNode._ancestor = _ancestor; newNode._ancestor = _ancestor;
} }
...@@ -892,21 +892,21 @@ abstract class RenderObjectWrapper extends Widget { ...@@ -892,21 +892,21 @@ abstract class RenderObjectWrapper extends Widget {
// doesn't need. // doesn't need.
assert(parent != null || this is RenderViewWrapper); assert(parent != null || this is RenderViewWrapper);
if (old == null) { if (old == null) {
_root = createNode(); _renderObject = createNode();
assert(_root != null); assert(_renderObject != null);
_ancestor = findAncestorRenderObjectWrapper(); _ancestor = findAncestorRenderObjectWrapper();
if (_ancestor is RenderObjectWrapper) if (_ancestor is RenderObjectWrapper)
_ancestor.insertChildRoot(this, slot); _ancestor.insertChildRoot(this, slot);
} else { } else {
assert(old is RenderObjectWrapper); assert(old is RenderObjectWrapper);
_root = old.root; _renderObject = old.renderObject;
_ancestor = old._ancestor; _ancestor = old._ancestor;
assert(_root != null); assert(_renderObject != null);
} }
assert(_root == root); // in case a subclass reintroduces it assert(_renderObject == renderObject); // in case a subclass reintroduces it
assert(root != null); assert(renderObject != null);
assert(mounted); assert(mounted);
_nodeMap[root] = this; _nodeMap[renderObject] = this;
syncRenderObject(old); syncRenderObject(old);
} }
...@@ -930,22 +930,22 @@ abstract class RenderObjectWrapper extends Widget { ...@@ -930,22 +930,22 @@ abstract class RenderObjectWrapper extends Widget {
ancestor = ancestor.parent; ancestor = ancestor.parent;
} }
if (parentData != null) { if (parentData != null) {
assert(root.parentData != null); assert(renderObject.parentData != null);
root.parentData.merge(parentData); // this will throw if the types aren't appropriate renderObject.parentData.merge(parentData); // this will throw if the types aren't appropriate
if (ancestor != null && ancestor.root != null) if (ancestor != null && ancestor.renderObject != null)
ancestor.root.markNeedsLayout(); ancestor.renderObject.markNeedsLayout();
} }
} }
void remove() { void remove() {
assert(root != null); assert(renderObject != null);
_nodeMap.remove(root); _nodeMap.remove(renderObject);
super.remove(); super.remove();
} }
void detachRoot() { void detachRoot() {
assert(_ancestor != null); assert(_ancestor != null);
assert(root != null); assert(renderObject != null);
_ancestor.detachChildRoot(this); _ancestor.detachChildRoot(this);
} }
...@@ -988,19 +988,19 @@ abstract class OneChildRenderObjectWrapper extends RenderObjectWrapper { ...@@ -988,19 +988,19 @@ abstract class OneChildRenderObjectWrapper extends RenderObjectWrapper {
} }
void insertChildRoot(RenderObjectWrapper child, dynamic slot) { void insertChildRoot(RenderObjectWrapper child, dynamic slot) {
final root = this.root; // TODO(ianh): Remove this once the analyzer is cleverer final renderObject = this.renderObject; // TODO(ianh): Remove this once the analyzer is cleverer
assert(root is RenderObjectWithChildMixin); assert(renderObject is RenderObjectWithChildMixin);
assert(slot == null); assert(slot == null);
root.child = child.root; renderObject.child = child.renderObject;
assert(root == this.root); // TODO(ianh): Remove this once the analyzer is cleverer assert(renderObject == this.renderObject); // TODO(ianh): Remove this once the analyzer is cleverer
} }
void detachChildRoot(RenderObjectWrapper child) { void detachChildRoot(RenderObjectWrapper child) {
final root = this.root; // TODO(ianh): Remove this once the analyzer is cleverer final renderObject = this.renderObject; // TODO(ianh): Remove this once the analyzer is cleverer
assert(root is RenderObjectWithChildMixin); assert(renderObject is RenderObjectWithChildMixin);
assert(root.child == child.root); assert(renderObject.child == child.renderObject);
root.child = null; renderObject.child = null;
assert(root == this.root); // TODO(ianh): Remove this once the analyzer is cleverer assert(renderObject == this.renderObject); // TODO(ianh): Remove this once the analyzer is cleverer
} }
void remove() { void remove() {
...@@ -1029,19 +1029,19 @@ abstract class MultiChildRenderObjectWrapper extends RenderObjectWrapper { ...@@ -1029,19 +1029,19 @@ abstract class MultiChildRenderObjectWrapper extends RenderObjectWrapper {
} }
void insertChildRoot(RenderObjectWrapper child, dynamic slot) { void insertChildRoot(RenderObjectWrapper child, dynamic slot) {
final root = this.root; // TODO(ianh): Remove this once the analyzer is cleverer final renderObject = this.renderObject; // TODO(ianh): Remove this once the analyzer is cleverer
assert(slot == null || slot is RenderObject); assert(slot == null || slot is RenderObject);
assert(root is ContainerRenderObjectMixin); assert(renderObject is ContainerRenderObjectMixin);
root.add(child.root, before: slot); renderObject.add(child.renderObject, before: slot);
assert(root == this.root); // TODO(ianh): Remove this once the analyzer is cleverer assert(renderObject == this.renderObject); // TODO(ianh): Remove this once the analyzer is cleverer
} }
void detachChildRoot(RenderObjectWrapper child) { void detachChildRoot(RenderObjectWrapper child) {
final root = this.root; // TODO(ianh): Remove this once the analyzer is cleverer final renderObject = this.renderObject; // TODO(ianh): Remove this once the analyzer is cleverer
assert(root is ContainerRenderObjectMixin); assert(renderObject is ContainerRenderObjectMixin);
assert(child.root.parent == root); assert(child.renderObject.parent == renderObject);
root.remove(child.root); renderObject.remove(child.renderObject);
assert(root == this.root); // TODO(ianh): Remove this once the analyzer is cleverer assert(renderObject == this.renderObject); // TODO(ianh): Remove this once the analyzer is cleverer
} }
void remove() { void remove() {
...@@ -1070,8 +1070,8 @@ abstract class MultiChildRenderObjectWrapper extends RenderObjectWrapper { ...@@ -1070,8 +1070,8 @@ abstract class MultiChildRenderObjectWrapper extends RenderObjectWrapper {
void syncRenderObject(MultiChildRenderObjectWrapper old) { void syncRenderObject(MultiChildRenderObjectWrapper old) {
super.syncRenderObject(old); super.syncRenderObject(old);
final root = this.root; // TODO(ianh): Remove this once the analyzer is cleverer final renderObject = this.renderObject; // TODO(ianh): Remove this once the analyzer is cleverer
if (root is! ContainerRenderObjectMixin) if (renderObject is! ContainerRenderObjectMixin)
return; return;
var startIndex = 0; var startIndex = 0;
...@@ -1090,7 +1090,7 @@ abstract class MultiChildRenderObjectWrapper extends RenderObjectWrapper { ...@@ -1090,7 +1090,7 @@ abstract class MultiChildRenderObjectWrapper extends RenderObjectWrapper {
assert(children[atIndex] != null); assert(children[atIndex] != null);
assert(children[atIndex].parent == this); assert(children[atIndex].parent == this);
if (atIndex > 0) if (atIndex > 0)
children[atIndex-1].updateSlot(children[atIndex].root); children[atIndex-1].updateSlot(children[atIndex].renderObject);
} }
// Scan backwards from end of list while nodes can be directly synced // Scan backwards from end of list while nodes can be directly synced
...@@ -1106,7 +1106,7 @@ abstract class MultiChildRenderObjectWrapper extends RenderObjectWrapper { ...@@ -1106,7 +1106,7 @@ abstract class MultiChildRenderObjectWrapper extends RenderObjectWrapper {
endIndex--; endIndex--;
oldEndIndex--; oldEndIndex--;
sync(endIndex); sync(endIndex);
nextSibling = children[endIndex].root; nextSibling = children[endIndex].renderObject;
} }
HashMap<Key, Widget> oldNodeIdMap = null; HashMap<Key, Widget> oldNodeIdMap = null;
...@@ -1147,28 +1147,28 @@ abstract class MultiChildRenderObjectWrapper extends RenderObjectWrapper { ...@@ -1147,28 +1147,28 @@ abstract class MultiChildRenderObjectWrapper extends RenderObjectWrapper {
return false; return false;
oldNodeIdMap[currentNode.key] = null; // mark it reordered oldNodeIdMap[currentNode.key] = null; // mark it reordered
assert(root is ContainerRenderObjectMixin); assert(renderObject is ContainerRenderObjectMixin);
assert(old.root is ContainerRenderObjectMixin); assert(old.renderObject is ContainerRenderObjectMixin);
assert(oldNode.root != null); assert(oldNode.renderObject != null);
if (old.root == root) { if (old.renderObject == renderObject) {
root.move(oldNode.root, before: nextSibling); renderObject.move(oldNode.renderObject, before: nextSibling);
} else { } else {
(old.root as ContainerRenderObjectMixin).remove(oldNode.root); // TODO(ianh): Remove cast once the analyzer is cleverer (old.renderObject as ContainerRenderObjectMixin).remove(oldNode.renderObject); // TODO(ianh): Remove cast once the analyzer is cleverer
root.add(oldNode.root, before: nextSibling); renderObject.add(oldNode.renderObject, before: nextSibling);
} }
return true; return true;
} }
// Scan forwards, this time we may re-order; // Scan forwards, this time we may re-order;
nextSibling = root.firstChild; nextSibling = renderObject.firstChild;
while (startIndex < endIndex && oldStartIndex < oldEndIndex) { while (startIndex < endIndex && oldStartIndex < oldEndIndex) {
currentNode = children[startIndex]; currentNode = children[startIndex];
oldNode = oldChildren[oldStartIndex]; oldNode = oldChildren[oldStartIndex];
if (currentNode.runtimeType == oldNode.runtimeType && currentNode.key == oldNode.key) { if (currentNode.runtimeType == oldNode.runtimeType && currentNode.key == oldNode.key) {
nextSibling = root.childAfter(nextSibling); nextSibling = renderObject.childAfter(nextSibling);
sync(startIndex); sync(startIndex);
startIndex++; startIndex++;
advanceOldStartIndex(); advanceOldStartIndex();
...@@ -1198,7 +1198,7 @@ abstract class MultiChildRenderObjectWrapper extends RenderObjectWrapper { ...@@ -1198,7 +1198,7 @@ abstract class MultiChildRenderObjectWrapper extends RenderObjectWrapper {
advanceOldStartIndex(); advanceOldStartIndex();
} }
assert(root == this.root); // TODO(ianh): Remove this once the analyzer is cleverer assert(renderObject == this.renderObject); // TODO(ianh): Remove this once the analyzer is cleverer
} }
} }
...@@ -1293,7 +1293,7 @@ abstract class AbstractWidgetRoot extends StatefulComponent { ...@@ -1293,7 +1293,7 @@ abstract class AbstractWidgetRoot extends StatefulComponent {
class RenderViewWrapper extends OneChildRenderObjectWrapper { class RenderViewWrapper extends OneChildRenderObjectWrapper {
RenderViewWrapper({ Key key, Widget child }) : super(key: key, child: child); RenderViewWrapper({ Key key, Widget child }) : super(key: key, child: child);
RenderView get root => super.root; RenderView get renderObject => super.renderObject;
RenderView createNode() => SkyBinding.instance.renderView; RenderView createNode() => SkyBinding.instance.renderView;
} }
...@@ -1337,14 +1337,14 @@ class RenderBoxToWidgetAdapter extends AbstractWidgetRoot { ...@@ -1337,14 +1337,14 @@ class RenderBoxToWidgetAdapter extends AbstractWidgetRoot {
void set container(RenderObjectWithChildMixin<RenderBox> value) { void set container(RenderObjectWithChildMixin<RenderBox> value) {
if (_container != value) { if (_container != value) {
assert(value.child == null); assert(value.child == null);
if (root != null) { if (renderObject != null) {
assert(_container.child == root); assert(_container.child == renderObject);
_container.child = null; _container.child = null;
} }
_container = value; _container = value;
if (root != null) { if (renderObject != null) {
_container.child = root; _container.child = renderObject;
assert(_container.child == root); assert(_container.child == renderObject);
} }
} }
} }
...@@ -1353,12 +1353,12 @@ class RenderBoxToWidgetAdapter extends AbstractWidgetRoot { ...@@ -1353,12 +1353,12 @@ class RenderBoxToWidgetAdapter extends AbstractWidgetRoot {
void _buildIfDirty() { void _buildIfDirty() {
super._buildIfDirty(); super._buildIfDirty();
if (root.parent == null) { if (renderObject.parent == null) {
// we haven't attached it yet // we haven't attached it yet
assert(_container.child == null); assert(_container.child == null);
_container.child = root; _container.child = renderObject;
} }
assert(root.parent == _container); assert(renderObject.parent == _container);
} }
Widget build() => builder(); Widget build() => builder();
......
...@@ -131,6 +131,6 @@ class InkWell extends OneChildRenderObjectWrapper { ...@@ -131,6 +131,6 @@ class InkWell extends OneChildRenderObjectWrapper {
InkWell({ Key key, Widget child }) InkWell({ Key key, Widget child })
: super(key: key, child: child); : super(key: key, child: child);
RenderInkWell get root => super.root; RenderInkWell get renderObject => super.renderObject;
RenderInkWell createNode() => new RenderInkWell(); RenderInkWell createNode() => new RenderInkWell();
} }
...@@ -196,7 +196,7 @@ class Scaffold extends RenderObjectWrapper { ...@@ -196,7 +196,7 @@ class Scaffold extends RenderObjectWrapper {
Map<ScaffoldSlots, Widget> _slots = new Map<ScaffoldSlots, Widget>(); Map<ScaffoldSlots, Widget> _slots = new Map<ScaffoldSlots, Widget>();
RenderScaffold get root => super.root; RenderScaffold get renderObject => super.renderObject;
RenderScaffold createNode() => new RenderScaffold(); RenderScaffold createNode() => new RenderScaffold();
void walkChildren(WidgetTreeWalker walker) { void walkChildren(WidgetTreeWalker walker) {
...@@ -208,15 +208,15 @@ class Scaffold extends RenderObjectWrapper { ...@@ -208,15 +208,15 @@ class Scaffold extends RenderObjectWrapper {
} }
void insertChildRoot(RenderObjectWrapper child, ScaffoldSlots slot) { void insertChildRoot(RenderObjectWrapper child, ScaffoldSlots slot) {
root[slot] = child != null ? child.root : null; renderObject[slot] = child != null ? child.renderObject : null;
} }
void detachChildRoot(RenderObjectWrapper child) { void detachChildRoot(RenderObjectWrapper child) {
final root = this.root; // TODO(ianh): Remove this once the analyzer is cleverer final renderObject = this.renderObject; // TODO(ianh): Remove this once the analyzer is cleverer
assert(root is RenderScaffold); assert(renderObject is RenderScaffold);
assert(root == child.root.parent); assert(renderObject == child.renderObject.parent);
root.remove(child.root); renderObject.remove(child.renderObject);
assert(root == this.root); // TODO(ianh): Remove this once the analyzer is cleverer assert(renderObject == this.renderObject); // TODO(ianh): Remove this once the analyzer is cleverer
} }
void remove() { void remove() {
......
...@@ -233,20 +233,20 @@ Scrollable findScrollableAncestor({ Widget target }) { ...@@ -233,20 +233,20 @@ Scrollable findScrollableAncestor({ Widget target }) {
bool ensureWidgetIsVisible(Widget target, { ValueAnimation<double> animation }) { bool ensureWidgetIsVisible(Widget target, { ValueAnimation<double> animation }) {
assert(target.mounted); assert(target.mounted);
assert(target.root is RenderBox); assert(target.renderObject is RenderBox);
Scrollable scrollable = findScrollableAncestor(target: target); Scrollable scrollable = findScrollableAncestor(target: target);
if (scrollable == null) if (scrollable == null)
return false; return false;
Size targetSize = (target.root as RenderBox).size; Size targetSize = (target.renderObject as RenderBox).size;
Point targetCenter = target.localToGlobal( Point targetCenter = target.localToGlobal(
scrollable.scrollDirection == ScrollDirection.vertical scrollable.scrollDirection == ScrollDirection.vertical
? new Point(0.0, targetSize.height / 2.0) ? new Point(0.0, targetSize.height / 2.0)
: new Point(targetSize.width / 2.0, 0.0) : new Point(targetSize.width / 2.0, 0.0)
); );
Size scrollableSize = (scrollable.root as RenderBox).size; Size scrollableSize = (scrollable.renderObject as RenderBox).size;
Point scrollableCenter = scrollable.localToGlobal( Point scrollableCenter = scrollable.localToGlobal(
scrollable.scrollDirection == ScrollDirection.vertical scrollable.scrollDirection == ScrollDirection.vertical
? new Point(0.0, scrollableSize.height / 2.0) ? new Point(0.0, scrollableSize.height / 2.0)
......
...@@ -55,15 +55,15 @@ class _SwitchWrapper extends LeafRenderObjectWrapper { ...@@ -55,15 +55,15 @@ class _SwitchWrapper extends LeafRenderObjectWrapper {
final ValueChanged onChanged; final ValueChanged onChanged;
final Color thumbColor; final Color thumbColor;
_RenderSwitch get root => super.root; _RenderSwitch get renderObject => super.renderObject;
_RenderSwitch createNode() => new _RenderSwitch( _RenderSwitch createNode() => new _RenderSwitch(
value: value, thumbColor: thumbColor, onChanged: onChanged); value: value, thumbColor: thumbColor, onChanged: onChanged);
void syncRenderObject(_SwitchWrapper old) { void syncRenderObject(_SwitchWrapper old) {
super.syncRenderObject(old); super.syncRenderObject(old);
root.value = value; renderObject.value = value;
root.onChanged = onChanged; renderObject.onChanged = onChanged;
root.thumbColor = thumbColor; renderObject.thumbColor = thumbColor;
} }
} }
......
...@@ -287,18 +287,18 @@ class TabBarWrapper extends MultiChildRenderObjectWrapper { ...@@ -287,18 +287,18 @@ class TabBarWrapper extends MultiChildRenderObjectWrapper {
final bool isScrollable; final bool isScrollable;
final LayoutChanged onLayoutChanged; final LayoutChanged onLayoutChanged;
RenderTabBar get root => super.root; RenderTabBar get renderObject => super.renderObject;
RenderTabBar createNode() => new RenderTabBar(onLayoutChanged); RenderTabBar createNode() => new RenderTabBar(onLayoutChanged);
void syncRenderObject(Widget old) { void syncRenderObject(Widget old) {
super.syncRenderObject(old); super.syncRenderObject(old);
root.selectedIndex = selectedIndex; renderObject.selectedIndex = selectedIndex;
root.backgroundColor = backgroundColor; renderObject.backgroundColor = backgroundColor;
root.indicatorColor = indicatorColor; renderObject.indicatorColor = indicatorColor;
root.indicatorRect = indicatorRect; renderObject.indicatorRect = indicatorRect;
root.textAndIcons = textAndIcons; renderObject.textAndIcons = textAndIcons;
root.isScrollable = isScrollable; renderObject.isScrollable = isScrollable;
root.onLayoutChanged = onLayoutChanged; renderObject.onLayoutChanged = onLayoutChanged;
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment