Unverified Commit 902d86e0 authored by Mouad Debbar's avatar Mouad Debbar Committed by GitHub

[web] Unify line boundary expectations on web and non-web (#121006)

* [web] Temporarily disable a line boundary test

* [web] Unify line boundary expectations on web and non-web
parent ebbc94bc
...@@ -1059,15 +1059,8 @@ void main() { ...@@ -1059,15 +1059,8 @@ void main() {
), ),
); );
selection = paragraph.selections[0]; selection = paragraph.selections[0];
expect(selection.start, 4); // how [are you] // how [are you]
if (isBrowser && !isCanvasKit) { expect(selection, const TextRange(start: 4, end: 11));
// TODO(mdebbar): Remove this "if" once this engine PR lands:
// https://github.com/flutter/engine/pull/39693
// expect(selection.end, 12);
} else {
expect(selection.end, 11);
}
// Equivalent to sending shift + meta + arrow-left. // Equivalent to sending shift + meta + arrow-left.
registrar.selectables[0].dispatchSelectionEvent( registrar.selectables[0].dispatchSelectionEvent(
...@@ -1078,16 +1071,8 @@ void main() { ...@@ -1078,16 +1071,8 @@ void main() {
), ),
); );
selection = paragraph.selections[0]; selection = paragraph.selections[0];
if (isBrowser && !isCanvasKit) { // [how ]are you
// TODO(mdebbar): Remove this "if" once this engine PR lands: expect(selection, const TextRange(start: 0, end: 4));
// https://github.com/flutter/engine/pull/39693
// how [are you\n]
// expect(selection, const TextRange(start: 4, end: 12));
} else {
// [how ]are you
expect(selection, const TextRange(start: 0, end: 4));
}
}); });
test('can granularly extend selection - document', () async { test('can granularly extend selection - document', () async {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment