Unverified Commit 8ff0af0c authored by Ian Hickson's avatar Ian Hickson Committed by GitHub

Move the requestKeyboard up to the widgets layer (#141655)

Turns out all implementations of this method made this call, so it seems like it should belong in the superclass.
parent 46bbf402
......@@ -117,7 +117,6 @@ class _CupertinoTextFieldSelectionGestureDetectorBuilder extends TextSelectionGe
}
}
super.onSingleTapUp(details);
_state._requestKeyboard();
_state.widget.onTap?.call();
}
......
......@@ -65,12 +65,6 @@ class _TextFieldSelectionGestureDetectorBuilder extends TextSelectionGestureDete
// Not required.
}
@override
void onSingleTapUp(TapDragUpDetails details) {
super.onSingleTapUp(details);
_state._requestKeyboard();
}
@override
bool get onUserTapAlwaysCalled => _state.widget.onTapAlwaysCalled;
......
......@@ -2417,6 +2417,7 @@ class TextSelectionGestureDetectorBuilder {
}
}
}
editableText.requestKeyboard();
}
/// Handler for [TextSelectionGestureDetector.onSingleTapCancel].
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment