Unverified Commit 8f3a6245 authored by Jenn Magder's avatar Jenn Magder Committed by GitHub

Consolidate ascii spinner stop in devtools activation (#75679)

parent b8541163
...@@ -153,18 +153,17 @@ class DevtoolsServerLauncher extends DevtoolsLauncher { ...@@ -153,18 +153,17 @@ class DevtoolsServerLauncher extends DevtoolsLauncher {
'devtools' 'devtools'
]); ]);
if (_devToolsActivateProcess.exitCode != 0) { if (_devToolsActivateProcess.exitCode != 0) {
status.cancel();
_logger.printError('Error running `pub global activate ' _logger.printError('Error running `pub global activate '
'devtools`:\n${_devToolsActivateProcess.stderr}'); 'devtools`:\n${_devToolsActivateProcess.stderr}');
return false; return false;
} }
status.stop();
_persistentToolState.lastDevToolsActivationTime = DateTime.now(); _persistentToolState.lastDevToolsActivationTime = DateTime.now();
return true; return true;
} on Exception catch (e, _) { } on Exception catch (e, _) {
status.stop();
_logger.printError('Error running `pub global activate devtools`: $e'); _logger.printError('Error running `pub global activate devtools`: $e');
return false; return false;
} finally {
status.stop();
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment