Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
8acbf549
Unverified
Commit
8acbf549
authored
Mar 27, 2022
by
Zachary Anderson
Committed by
GitHub
Mar 27, 2022
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Adds an impeller variant of the new gallery transition perf benchmark (#100837)
parent
47f08a3f
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
43 additions
and
0 deletions
+43
-0
.ci.yaml
.ci.yaml
+10
-0
TESTOWNERS
TESTOWNERS
+1
-0
new_gallery_impeller_ios__transition_perf.dart
.../bin/tasks/new_gallery_impeller_ios__transition_perf.dart
+24
-0
new_gallery.dart
dev/devicelab/lib/tasks/new_gallery.dart
+2
-0
perf_tests.dart
dev/devicelab/lib/tasks/perf_tests.dart
+6
-0
No files found.
.ci.yaml
View file @
8acbf549
...
...
@@ -3526,6 +3526,16 @@ targets:
["devicelab","ios","mac"]
task_name
:
new_gallery_ios__transition_perf
-
name
:
Mac_ios new_gallery_impeller_ios__transition_perf
bringup
:
true
# Flaky https://github.com/flutter/flutter/issues/96401
recipe
:
devicelab/devicelab_drone
presubmit
:
false
timeout
:
60
properties
:
tags
:
>
["devicelab","ios","mac"]
task_name
:
new_gallery_impeller_ios__transition_perf
-
name
:
Mac_ios ios_picture_cache_complexity_scoring_perf__timeline_summary
recipe
:
devicelab/devicelab_drone
bringup
:
true
...
...
TESTOWNERS
View file @
8acbf549
...
...
@@ -163,6 +163,7 @@
/dev/devicelab/bin/tasks/macos_chrome_dev_mode.dart @zanderso @flutter/tool
/dev/devicelab/bin/tasks/microbenchmarks_ios.dart @zanderso @flutter/engine
/dev/devicelab/bin/tasks/new_gallery_ios__transition_perf.dart @zanderso @flutter/engine
/dev/devicelab/bin/tasks/new_gallery_impeller_ios__transition_perf.dart @zanderso @flutter/engine
/dev/devicelab/bin/tasks/platform_channel_sample_test_ios.dart @zanderso @flutter/engine
/dev/devicelab/bin/tasks/platform_channel_sample_test_swift.dart @zanderso @flutter/engine
/dev/devicelab/bin/tasks/platform_channels_benchmarks_ios.dart @gaaclarke @flutter/engine
...
...
dev/devicelab/bin/tasks/new_gallery_impeller_ios__transition_perf.dart
0 → 100644
View file @
8acbf549
// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import
'dart:io'
;
import
'package:flutter_devicelab/framework/devices.dart'
;
import
'package:flutter_devicelab/framework/framework.dart'
;
import
'package:flutter_devicelab/framework/utils.dart'
;
import
'package:flutter_devicelab/tasks/new_gallery.dart'
;
import
'package:path/path.dart'
as
path
;
Future
<
void
>
main
()
async
{
deviceOperatingSystem
=
DeviceOperatingSystem
.
ios
;
final
Directory
galleryParentDir
=
Directory
.
systemTemp
.
createTempSync
(
'flutter_new_gallery_test.'
);
final
Directory
galleryDir
=
Directory
(
path
.
join
(
galleryParentDir
.
path
,
'gallery'
));
try
{
await
task
(
NewGalleryPerfTest
(
galleryDir
,
enableImpeller:
true
).
run
);
}
finally
{
rmTree
(
galleryParentDir
);
}
}
dev/devicelab/lib/tasks/new_gallery.dart
View file @
8acbf549
...
...
@@ -14,11 +14,13 @@ class NewGalleryPerfTest extends PerfTest {
this
.
galleryDir
,
{
String
timelineFileName
=
'transitions'
,
String
dartDefine
=
''
,
bool
enableImpeller
=
false
,
})
:
super
(
galleryDir
.
path
,
'test_driver/transitions_perf.dart'
,
timelineFileName
,
dartDefine:
dartDefine
,
enableImpeller:
enableImpeller
,
);
@override
...
...
dev/devicelab/lib/tasks/perf_tests.dart
View file @
8acbf549
...
...
@@ -815,6 +815,7 @@ class PerfTest {
String
?
resultFilename
,
this
.
device
,
this
.
flutterDriveCallback
,
this
.
enableImpeller
=
false
,
}):
_resultFilename
=
resultFilename
;
const
PerfTest
.
e2e
(
...
...
@@ -829,6 +830,7 @@ class PerfTest {
String
resultFilename
=
'e2e_perf_summary'
,
this
.
device
,
this
.
flutterDriveCallback
,
this
.
enableImpeller
=
false
,
})
:
saveTraceFile
=
false
,
timelineFileName
=
null
,
_resultFilename
=
resultFilename
;
/// The directory where the app under test is defined.
...
...
@@ -860,6 +862,9 @@ class PerfTest {
/// If it is not `null`, `flutter drive` will not happen in the PerfTests.
final
FlutterDriveCallback
?
flutterDriveCallback
;
/// Whether the perf test should enable Impeller.
final
bool
enableImpeller
;
/// The keys of the values that need to be reported.
///
/// If it's `null`, then report:
...
...
@@ -929,6 +934,7 @@ class PerfTest {
if
(
cacheSkSL
)
'--cache-sksl'
,
if
(
dartDefine
.
isNotEmpty
)
...<
String
>[
'--dart-define'
,
dartDefine
],
if
(
enableImpeller
)
'--enable-impeller'
,
'-d'
,
deviceId
,
];
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment