Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
89a4a138
Commit
89a4a138
authored
Oct 26, 2017
by
Yegor
Committed by
GitHub
Oct 26, 2017
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
unpin linter version, skip the broken 0.1.37 version (#12737)
parent
154f2e54
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
12 additions
and
3 deletions
+12
-3
create.dart
packages/flutter_tools/lib/src/commands/create.dart
+2
-1
update_packages.dart
packages/flutter_tools/lib/src/commands/update_packages.dart
+9
-1
pubspec.yaml
packages/flutter_tools/pubspec.yaml
+1
-1
No files found.
packages/flutter_tools/lib/src/commands/create.dart
View file @
89a4a138
...
...
@@ -5,6 +5,7 @@
import
'dart:async'
;
import
'package:linter/src/rules/pub/package_names.dart'
as
package_names
;
// ignore: implementation_imports
import
'package:linter/src/utils.dart'
as
linter_utils
;
// ignore: implementation_imports
import
'../android/android.dart'
as
android
;
import
'../android/android_sdk.dart'
as
android_sdk
;
...
...
@@ -362,7 +363,7 @@ final Set<String> _packageDependencies = new Set<String>.from(<String>[
/// Return null if the project name is legal. Return a validation message if
/// we should disallow the project name.
String
_validateProjectName
(
String
projectName
)
{
if
(!
package_name
s
.
isValidPackageName
(
projectName
))
if
(!
linter_util
s
.
isValidPackageName
(
projectName
))
return
'"
$projectName
" is not a valid Dart package name.
\n\n
${package_names.details}
'
;
if
(
_packageDependencies
.
contains
(
projectName
))
{
...
...
packages/flutter_tools/lib/src/commands/update_packages.dart
View file @
89a4a138
...
...
@@ -16,8 +16,16 @@ import '../dart/pub.dart';
import
'../globals.dart'
;
import
'../runner/flutter_command.dart'
;
/// Map from package name to package version, used to artificially pin a pub
/// package version in cases when upgrading to the latest breaks Flutter.
///
/// Example:
///
/// ```
/// 'linter': '0.1.35', // TODO(yjbanov): https://github.com/dart-lang/linter/issues/824
/// ```
const
Map
<
String
,
String
>
_kManuallyPinnedDependencies
=
const
<
String
,
String
>{
'linter'
:
'0.1.35'
,
// TODO(yjbanov): https://github.com/dart-lang/linter/issues/824
// Add pinned packages here.
};
class
UpdatePackagesCommand
extends
FlutterCommand
{
...
...
packages/flutter_tools/pubspec.yaml
View file @
89a4a138
...
...
@@ -18,7 +18,7 @@ dependencies:
intl
:
0.15.2
json_rpc_2
:
2.0.4
json_schema
:
1.0.6
linter
:
0.1.3
5
linter
:
0.1.3
8
meta
:
1.1.1
mustache
:
0.2.5+1
package_config
:
1.0.3
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment