Commit 89a4a138 authored by Yegor's avatar Yegor Committed by GitHub

unpin linter version, skip the broken 0.1.37 version (#12737)

parent 154f2e54
...@@ -5,6 +5,7 @@ ...@@ -5,6 +5,7 @@
import 'dart:async'; import 'dart:async';
import 'package:linter/src/rules/pub/package_names.dart' as package_names; // ignore: implementation_imports import 'package:linter/src/rules/pub/package_names.dart' as package_names; // ignore: implementation_imports
import 'package:linter/src/utils.dart' as linter_utils; // ignore: implementation_imports
import '../android/android.dart' as android; import '../android/android.dart' as android;
import '../android/android_sdk.dart' as android_sdk; import '../android/android_sdk.dart' as android_sdk;
...@@ -362,7 +363,7 @@ final Set<String> _packageDependencies = new Set<String>.from(<String>[ ...@@ -362,7 +363,7 @@ final Set<String> _packageDependencies = new Set<String>.from(<String>[
/// Return null if the project name is legal. Return a validation message if /// Return null if the project name is legal. Return a validation message if
/// we should disallow the project name. /// we should disallow the project name.
String _validateProjectName(String projectName) { String _validateProjectName(String projectName) {
if (!package_names.isValidPackageName(projectName)) if (!linter_utils.isValidPackageName(projectName))
return '"$projectName" is not a valid Dart package name.\n\n${package_names.details}'; return '"$projectName" is not a valid Dart package name.\n\n${package_names.details}';
if (_packageDependencies.contains(projectName)) { if (_packageDependencies.contains(projectName)) {
......
...@@ -16,8 +16,16 @@ import '../dart/pub.dart'; ...@@ -16,8 +16,16 @@ import '../dart/pub.dart';
import '../globals.dart'; import '../globals.dart';
import '../runner/flutter_command.dart'; import '../runner/flutter_command.dart';
/// Map from package name to package version, used to artificially pin a pub
/// package version in cases when upgrading to the latest breaks Flutter.
///
/// Example:
///
/// ```
/// 'linter': '0.1.35', // TODO(yjbanov): https://github.com/dart-lang/linter/issues/824
/// ```
const Map<String, String> _kManuallyPinnedDependencies = const <String, String>{ const Map<String, String> _kManuallyPinnedDependencies = const <String, String>{
'linter': '0.1.35', // TODO(yjbanov): https://github.com/dart-lang/linter/issues/824 // Add pinned packages here.
}; };
class UpdatePackagesCommand extends FlutterCommand { class UpdatePackagesCommand extends FlutterCommand {
......
...@@ -18,7 +18,7 @@ dependencies: ...@@ -18,7 +18,7 @@ dependencies:
intl: 0.15.2 intl: 0.15.2
json_rpc_2: 2.0.4 json_rpc_2: 2.0.4
json_schema: 1.0.6 json_schema: 1.0.6
linter: 0.1.35 linter: 0.1.38
meta: 1.1.1 meta: 1.1.1
mustache: 0.2.5+1 mustache: 0.2.5+1
package_config: 1.0.3 package_config: 1.0.3
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment