Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
88eca6c1
Unverified
Commit
88eca6c1
authored
Apr 19, 2022
by
Jenn Magder
Committed by
GitHub
Apr 19, 2022
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fail integration test if expected bitcode markers not found (#102016)
parent
fecc8904
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
9 additions
and
2 deletions
+9
-2
module_test_ios.dart
dev/devicelab/bin/tasks/module_test_ios.dart
+2
-2
ios.dart
dev/devicelab/lib/framework/ios.dart
+7
-0
No files found.
dev/devicelab/bin/tasks/module_test_ios.dart
View file @
88eca6c1
...
...
@@ -462,7 +462,7 @@ end
if
((
await
fileType
(
builtFlutterBinary
)).
contains
(
'armv7'
))
{
throw
TaskResult
.
failure
(
'Unexpected armv7 architecture slice in
$builtFlutterBinary
'
);
}
await
containsBitcode
(
builtFlutterBinary
);
await
c
heckC
ontainsBitcode
(
builtFlutterBinary
);
final
String
builtAppBinary
=
path
.
join
(
archivedAppPath
,
...
...
@@ -474,7 +474,7 @@ end
if
((
await
fileType
(
builtAppBinary
)).
contains
(
'armv7'
))
{
throw
TaskResult
.
failure
(
'Unexpected armv7 architecture slice in
$builtAppBinary
'
);
}
await
containsBitcode
(
builtAppBinary
);
await
c
heckC
ontainsBitcode
(
builtAppBinary
);
// The host app example builds plugins statically, url_launcher_ios.framework
// should not exist.
...
...
dev/devicelab/lib/framework/ios.dart
View file @
88eca6c1
...
...
@@ -8,6 +8,7 @@ import 'dart:io';
import
'package:path/path.dart'
as
path
;
import
'host_agent.dart'
;
import
'task_result.dart'
;
import
'utils.dart'
;
typedef
SimulatorFunction
=
Future
<
void
>
Function
(
String
deviceId
);
...
...
@@ -84,6 +85,12 @@ Future<bool> containsBitcode(String pathToBinary) async {
return
!
emptyBitcodeMarkerFound
;
}
Future
<
void
>
checkContainsBitcode
(
String
pathToBinary
)
async
{
if
(!
await
containsBitcode
(
pathToBinary
))
{
throw
TaskResult
.
failure
(
'Expected bitcode in
$pathToBinary
'
);
}
}
/// Creates and boots a new simulator, passes the new simulator's identifier to
/// `testFunction`.
///
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment