Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
83b9497c
Unverified
Commit
83b9497c
authored
Jan 17, 2019
by
Jonah Williams
Committed by
GitHub
Jan 17, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
do not exit tool if fuchsia workflow fails (#26589)
parent
800a6e16
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
8 additions
and
5 deletions
+8
-5
fuchsia_device.dart
packages/flutter_tools/lib/src/fuchsia/fuchsia_device.dart
+3
-0
fuchsia_sdk.dart
packages/flutter_tools/lib/src/fuchsia/fuchsia_sdk.dart
+5
-5
No files found.
packages/flutter_tools/lib/src/fuchsia/fuchsia_device.dart
View file @
83b9497c
...
@@ -115,6 +115,9 @@ class FuchsiaDevices extends PollingDeviceDiscovery {
...
@@ -115,6 +115,9 @@ class FuchsiaDevices extends PollingDeviceDiscovery {
return
<
Device
>[];
return
<
Device
>[];
}
}
final
String
text
=
await
fuchsiaSdk
.
listDevices
();
final
String
text
=
await
fuchsiaSdk
.
listDevices
();
if
(
text
==
null
)
{
return
<
Device
>[];
}
final
List
<
FuchsiaDevice
>
devices
=
parseListDevices
(
text
);
final
List
<
FuchsiaDevice
>
devices
=
parseListDevices
(
text
);
return
devices
;
return
devices
;
}
}
...
...
packages/flutter_tools/lib/src/fuchsia/fuchsia_sdk.dart
View file @
83b9497c
...
@@ -5,12 +5,12 @@
...
@@ -5,12 +5,12 @@
import
'dart:async'
;
import
'dart:async'
;
import
'dart:convert'
;
import
'dart:convert'
;
import
'../base/common.dart'
;
import
'../base/context.dart'
;
import
'../base/context.dart'
;
import
'../base/file_system.dart'
;
import
'../base/file_system.dart'
;
import
'../base/io.dart'
;
import
'../base/io.dart'
;
import
'../base/process.dart'
;
import
'../base/process.dart'
;
import
'../base/process_manager.dart'
;
import
'../base/process_manager.dart'
;
import
'../globals.dart'
;
/// The [FuchsiaSdk] instance.
/// The [FuchsiaSdk] instance.
FuchsiaSdk
get
fuchsiaSdk
=>
context
[
FuchsiaSdk
];
FuchsiaSdk
get
fuchsiaSdk
=>
context
[
FuchsiaSdk
];
...
@@ -33,8 +33,8 @@ class FuchsiaSdk {
...
@@ -33,8 +33,8 @@ class FuchsiaSdk {
final
String
path
=
fuchsiaArtifacts
.
devFinder
.
absolute
.
path
;
final
String
path
=
fuchsiaArtifacts
.
devFinder
.
absolute
.
path
;
final
RunResult
process
=
await
runAsync
(<
String
>[
path
,
'list'
,
'-full'
]);
final
RunResult
process
=
await
runAsync
(<
String
>[
path
,
'list'
,
'-full'
]);
return
process
.
stdout
.
trim
();
return
process
.
stdout
.
trim
();
}
on
ArgumentError
catch
(
exception
)
{
}
catch
(
exception
)
{
throwToolExit
(
'
$exception
'
);
printTrace
(
'
$exception
'
);
}
}
return
null
;
return
null
;
}
}
...
@@ -57,8 +57,8 @@ class FuchsiaSdk {
...
@@ -57,8 +57,8 @@ class FuchsiaSdk {
controller
.
addStream
(
process
.
stdout
.
transform
(
utf8
.
decoder
).
transform
(
const
LineSplitter
()));
controller
.
addStream
(
process
.
stdout
.
transform
(
utf8
.
decoder
).
transform
(
const
LineSplitter
()));
});
});
return
controller
.
stream
;
return
controller
.
stream
;
}
on
ArgumentError
catch
(
exception
)
{
}
catch
(
exception
)
{
throwToolExit
(
'
$exception
'
);
printTrace
(
'
$exception
'
);
}
}
return
null
;
return
null
;
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment