Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
8291f481
Unverified
Commit
8291f481
authored
Nov 02, 2020
by
Jonah Williams
Committed by
GitHub
Nov 02, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[flutter_tools] add canvaskit hot reload integration test (#69550)
parent
0490fd75
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
22 additions
and
2 deletions
+22
-2
hot_reload_web_test.dart
...ter_tools/test/integration.shard/hot_reload_web_test.dart
+20
-2
test_driver.dart
...ges/flutter_tools/test/integration.shard/test_driver.dart
+2
-0
No files found.
packages/flutter_tools/test/integration.shard/hot_reload_web_test.dart
View file @
8291f481
...
...
@@ -30,7 +30,7 @@ void main() {
testWithoutContext
(
'hot restart works without error'
,
()
async
{
await
flutter
.
run
(
chrome:
true
);
await
flutter
.
hotRestart
();
},
skip:
platform
.
isMacOS
);
},
skip:
platform
.
isMacOS
,
retry:
1
);
testWithoutContext
(
'newly added code executes during hot restart'
,
()
async
{
final
Completer
<
void
>
completer
=
Completer
<
void
>();
...
...
@@ -48,5 +48,23 @@ void main() {
}
finally
{
await
subscription
.
cancel
();
}
},
skip:
platform
.
isMacOS
);
},
skip:
platform
.
isMacOS
,
retry:
1
);
testWithoutContext
(
'newly added code executes during hot restart - canvaskit'
,
()
async
{
final
Completer
<
void
>
completer
=
Completer
<
void
>();
final
StreamSubscription
<
String
>
subscription
=
flutter
.
stdout
.
listen
((
String
line
)
{
print
(
line
);
if
(
line
.
contains
(
'(((((RELOAD WORKED)))))'
))
{
completer
.
complete
();
}
});
await
flutter
.
run
(
chrome:
true
,
additionalCommandArgs:
<
String
>[
'--dart-define=FLUTTER_WEB_USE_SKIA=true'
]);
project
.
uncommentHotReloadPrint
();
try
{
await
flutter
.
hotRestart
();
await
completer
.
future
;
}
finally
{
await
subscription
.
cancel
();
}
},
skip:
true
,
retry:
1
);
// Currently broken: Expected a value of type 'Future<_RegisteredFont>', but got one of type '_Future<_RegisteredFont?>
}
packages/flutter_tools/test/integration.shard/test_driver.dart
View file @
8291f481
...
...
@@ -451,6 +451,7 @@ class FlutterRunTestDriver extends FlutterTestDriver {
bool
singleWidgetReloads
=
false
,
File
pidFile
,
String
script
,
List
<
String
>
additionalCommandArgs
,
})
async
{
await
_setupProcess
(
<
String
>[
...
...
@@ -471,6 +472,7 @@ class FlutterRunTestDriver extends FlutterTestDriver {
'flutter-tester'
,
if
(
structuredErrors
)
'--dart-define=flutter.inspector.structuredErrors=true'
,
...?
additionalCommandArgs
,
],
withDebugger:
withDebugger
,
startPaused:
startPaused
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment